Waterfall data point values (#25560)
* Refactor static waterfall chart to use a single entrypoint
* Consolidate static watetrfall chart
* Update waterfall chart text size to match combo-chart
* Move `<Values />` from XYChart/ to be under components/
Since it'll be used by waterfall chart
* Fix `<Values />` key error (forgot to add key attribute)
* Show data point values on waterfall chart
* Fix failed BE tests
* Fix test -> wrong `waterfall-type` used. And test both types
The waterfall component was changed to take a type argument, instead of having 2 functions for nearly identical
output. The failing test just passed the wrong string to the key argument.
* Change waterfall keys from strings to Clojure keys
* Remove redundant test. Categorical also handled in `waterfall-test`
* Fix clj-kondo lint error
* Cleanup conditional statements
* Miscellaneous code cleanup
* Update waterfall test to render data point values
* Fix waterfall chart data point values not center in the bar
* Make some API for static waterfall chart with total saner
Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
Showing
- frontend/src/metabase/internal/pages/StaticVizPage.jsx 8 additions, 8 deletionsfrontend/src/metabase/internal/pages/StaticVizPage.jsx
- frontend/src/metabase/static-viz/components/CategoricalWaterfallChart/CategoricalWaterfallChart.jsx 0 additions, 181 deletions...s/CategoricalWaterfallChart/CategoricalWaterfallChart.jsx
- frontend/src/metabase/static-viz/components/CategoricalWaterfallChart/index.js 0 additions, 1 deletion.../static-viz/components/CategoricalWaterfallChart/index.js
- frontend/src/metabase/static-viz/components/TimeSeriesWaterfallChart/TimeSeriesWaterfallChart.jsx 0 additions, 154 deletions...nts/TimeSeriesWaterfallChart/TimeSeriesWaterfallChart.jsx
- frontend/src/metabase/static-viz/components/TimeSeriesWaterfallChart/constants.ts 0 additions, 19 deletions...atic-viz/components/TimeSeriesWaterfallChart/constants.ts
- frontend/src/metabase/static-viz/components/TimeSeriesWaterfallChart/index.js 0 additions, 1 deletion...e/static-viz/components/TimeSeriesWaterfallChart/index.js
- frontend/src/metabase/static-viz/components/Values/Values.tsx 73 additions, 47 deletions...tend/src/metabase/static-viz/components/Values/Values.tsx
- frontend/src/metabase/static-viz/components/Values/index.ts 0 additions, 0 deletionsfrontend/src/metabase/static-viz/components/Values/index.ts
- frontend/src/metabase/static-viz/components/WaterfallChart/WaterfallChart.jsx 343 additions, 0 deletions...e/static-viz/components/WaterfallChart/WaterfallChart.jsx
- frontend/src/metabase/static-viz/components/WaterfallChart/constants.ts 47 additions, 0 deletions...etabase/static-viz/components/WaterfallChart/constants.ts
- frontend/src/metabase/static-viz/components/WaterfallChart/index.js 1 addition, 0 deletions...rc/metabase/static-viz/components/WaterfallChart/index.js
- frontend/src/metabase/static-viz/components/WaterfallChart/types.ts 25 additions, 0 deletions...rc/metabase/static-viz/components/WaterfallChart/types.ts
- frontend/src/metabase/static-viz/components/XYChart/XYChart.tsx 1 addition, 1 deletion...nd/src/metabase/static-viz/components/XYChart/XYChart.tsx
- frontend/src/metabase/static-viz/components/XYChart/types.ts 1 addition, 1 deletionfrontend/src/metabase/static-viz/components/XYChart/types.ts
- frontend/src/metabase/static-viz/components/XYChart/utils/scales.ts 1 addition, 1 deletion...rc/metabase/static-viz/components/XYChart/utils/scales.ts
- frontend/src/metabase/static-viz/components/XYChart/utils/series.ts 8 additions, 0 deletions...rc/metabase/static-viz/components/XYChart/utils/series.ts
- frontend/src/metabase/static-viz/components/XYChart/utils/ticks.ts 1 addition, 1 deletion...src/metabase/static-viz/components/XYChart/utils/ticks.ts
- frontend/src/metabase/static-viz/containers/StaticChart/StaticChart.tsx 4 additions, 8 deletions...etabase/static-viz/containers/StaticChart/StaticChart.tsx
- frontend/src/metabase/static-viz/containers/StaticChart/constants.ts 4 additions, 8 deletions...c/metabase/static-viz/containers/StaticChart/constants.ts
- frontend/src/metabase/static-viz/lib/axes.js 26 additions, 17 deletionsfrontend/src/metabase/static-viz/lib/axes.js
Loading
Please register or sign in to comment