Skip to content
Snippets Groups Projects
Unverified Commit fa7338e6 authored by Mahatthana (Kelvin) Nomsawadi's avatar Mahatthana (Kelvin) Nomsawadi Committed by GitHub
Browse files

Waterfall data point values (#25560)


* Refactor static waterfall chart to use a single entrypoint

* Consolidate static watetrfall chart

* Update waterfall chart text size to match combo-chart

* Move `<Values />` from XYChart/ to be under components/

Since it'll be used by waterfall chart

* Fix `<Values />` key error (forgot to add key attribute)

* Show data point values on waterfall chart

* Fix failed BE tests

* Fix test -> wrong `waterfall-type` used. And test both types

The waterfall component was changed to take a type argument, instead of having 2 functions for nearly identical
output. The failing test just passed the wrong string to the key argument.

* Change waterfall keys from strings to Clojure keys

* Remove redundant test. Categorical also handled in `waterfall-test`

* Fix clj-kondo lint error

* Cleanup conditional statements

* Miscellaneous code cleanup

* Update waterfall test to render data point values

* Fix waterfall chart data point values not center in the bar

* Make some API for static waterfall chart with total saner

Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
parent dc3db493
No related merge requests found
Showing
with 543 additions and 448 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment