Make sure jdbc/insert! quotes identifiers

src/metabase/db.clj

@@ -339,6 +339,10 @@
     :mysql    :mysql
     :postgres :ansi))
 
+(def ^:private quote-fn
+  "The function that JDBC should use to quote identifiers for our database. This is passed as the `:entities` option to functions like `jdbc/insert!`."
+  (quoting-style @(resolve 'hformat/quote-fns)))
+
 (defn- honeysql->sql
   "Compile HONEYSQL-FORM to SQL.
   This returns a vector with the SQL string as its first item and prepared statement params as the remaining items."
@@ -361,6 +365,7 @@
 
      (entity->table-name 'CardFavorite) -> :report_cardfavorite"
   ^clojure.lang.Keyword [entity]
+  {:post [(keyword? %)]}
   (keyword (:table (resolve-entity entity))))
 
 (defn- entity->fields
@@ -505,6 +510,7 @@
   ([entity k v & more]
    (delete! entity (apply array-map k v more))))
 
+
 ;;; ## INSERT!
 
 (defn insert!
@@ -513,13 +519,16 @@
    For flexibility, `insert!` OBJECT can be either a single map or individual kwargs:
 
      (insert! Label {:name \"Toucan Unfriendly\"})
-     (insert! 'Label :name \"Toucan Friendly\")"
+     (insert! 'Label :name \"Toucan Friendly\")
+
+   This fetches the newly created object from the database and passes it to the entity's `post-insert` method, ultimately returning the object."
   {:style/indent 1}
   ([entity object]
    {:pre [(map? object) (every? keyword? (keys object))]}
    (let [entity (resolve-entity entity)
          object (models/do-pre-insert entity object)
-         id     (first (vals (first (jdbc/insert! (db-connection) (entity->table-name entity) object))))]
+         id     (first (vals (first (jdbc/insert! (db-connection) (entity->table-name entity) object
+                                      :entities quote-fn))))]
      (some-> id entity models/post-insert)))
 
   ([entity k v & more]
@@ -641,7 +650,7 @@
     (db/exists? User :id 100)
    NOTE: This only works for objects that have an `:id` field."
   ^Boolean [entity & kvs]
-  (boolean (select-one entity (apply where (h/select :id) kvs))))
+  (boolean (select-one entity (apply where (h/select {} :id) kvs))))
 
 
 ;;; ## CASADE-DELETE

test/metabase/test/data/mysql.clj

@@ -36,7 +36,7 @@
 (u/strict-extend MySQLDriver
   generic/IGenericSQLDatasetLoader
   (merge generic/DefaultsMixin
-         {:execute-sql!              generic/sequentially-execute-sql!                  ; TODO - we might be able to do SQL all at once by setting `allowMultiQueries=true` on the connection string
+         {:execute-sql!              generic/sequentially-execute-sql!              ; TODO - we might be able to do SQL all at once by setting `allowMultiQueries=true` on the connection string
           :field-base-type->sql-type (u/drop-first-arg field-base-type->sql-type)
           :load-data!                generic/load-data-all-at-once!
           :pk-sql-type               (constantly "INTEGER NOT NULL AUTO_INCREMENT")

test/metabase/test_setup.clj

@@ -85,7 +85,7 @@
       (core/initialization-complete!)
       ;; If test setup fails exit right away
       (catch Throwable e
-        (log/error (u/format-color 'red "Test setup failed: %s\n%s" e (u/pprint-to-str (.getStackTrace e))))
+        (log/error (u/format-color 'red "Test setup failed: %s\n%s" e (u/pprint-to-str (vec (.getStackTrace e)))))
         (System/exit -1)))
 
     @start-jetty!))