Skip to content
Snippets Groups Projects
Unverified Commit fe5861e3 authored by Ariya Hidayat's avatar Ariya Hidayat Committed by GitHub
Browse files

Allow SCOPE (for max/min) to work also on STRING (#22302)

parent d5c8e999
No related branches found
No related tags found
No related merge requests found
......@@ -74,7 +74,7 @@ const TYPES = {
exclude: [ENTITY, LOCATION, TEMPORAL],
},
[SCOPE]: {
include: [NUMBER, TEMPORAL, CATEGORY, ENTITY],
include: [NUMBER, TEMPORAL, CATEGORY, ENTITY, STRING],
exclude: [LOCATION],
},
[CATEGORY]: {
......
......@@ -18,10 +18,11 @@ describe("issue 18207", () => {
summarize({ mode: "notebook" });
});
it("should be possible to use MIN on a string column (metabase#18207)", () => {
it("should be possible to use MIN on a string column (metabase#18207, metabase#22155)", () => {
cy.contains("Minimum of").click();
cy.findByText("Price");
cy.findByText("Rating");
cy.findByText("Ean").should("be.visible");
cy.contains("Category").click();
visualize();
......@@ -29,10 +30,11 @@ describe("issue 18207", () => {
cy.findByText("Doohickey");
});
it("should be possible to use MAX on a string column (metabase#18207)", () => {
it("should be possible to use MAX on a string column (metabase#18207, metabase#22155)", () => {
cy.contains("Maximum of").click();
cy.findByText("Price");
cy.findByText("Rating");
cy.findByText("Ean").should("be.visible");
cy.contains("Category").click();
visualize();
......@@ -40,10 +42,11 @@ describe("issue 18207", () => {
cy.findByText("Widget");
});
it("should be not possible to use AVERAGE on a string column (metabase#18207)", () => {
it("should be not possible to use AVERAGE on a string column (metabase#18207, metabase#22155)", () => {
cy.contains("Average of").click();
cy.findByText("Price");
cy.findByText("Rating");
cy.findByText("Ean").should("not.exist");
cy.findByText("Category").should("not.exist");
});
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment