Fix `createMockCard` returns a query without a source table (#36715)

* Use sample products table ID in `createMockStructuredQuery`

* Simplify things

* Fix failing tests

frontend/src/metabase-types/api/mocks/query.ts

@@ -8,6 +8,7 @@ import type {
 export const createMockStructuredQuery = (
   opts?: Partial<StructuredQuery>,
 ): StructuredQuery => ({
+  "source-table": 1,
   ...opts,
 });
 

frontend/src/metabase/containers/SavedQuestionLoader.unit.spec.js

@@ -4,18 +4,15 @@ import SavedQuestionLoader from "metabase/containers/SavedQuestionLoader";
 import { renderWithProviders } from "__support__/ui";
 import {
   setupCardEndpoints,
-  setupSchemaEndpoints,
   setupUnauthorizedSchemaEndpoints,
   setupUnauthorizedCardEndpoints,
+  setupDatabaseEndpoints,
 } from "__support__/server-mocks";
-import {
-  createMockCard,
-  createMockColumn,
-  createMockDatabase,
-} from "metabase-types/api/mocks";
+import { createMockCard, createMockColumn } from "metabase-types/api/mocks";
+import { createSampleDatabase } from "metabase-types/api/mocks/presets";
 import Question from "metabase-lib/Question";
 
-const databaseMock = createMockDatabase({ id: 1 });
+const databaseMock = createSampleDatabase();
 
 const childrenRenderFn = ({ loading, question, error }) => {
   if (error) {
@@ -48,7 +45,7 @@ const setupQuestion = ({ id, name, hasAccess }) => {
 
 const setup = ({ questionId, hasAccess }) => {
   if (hasAccess) {
-    setupSchemaEndpoints(databaseMock);
+    setupDatabaseEndpoints(databaseMock);
   } else {
     setupUnauthorizedSchemaEndpoints(databaseMock);
   }

frontend/src/metabase/dashboard/components/DashCard/DashCardMenu/DashCardMenu.unit.spec.tsx

@@ -44,6 +44,7 @@ const TEST_CARD_NATIVE = createMockCard({
 const TEST_CARD_NO_DATA_ACCESS = createMockCard({
   dataset_query: createMockStructuredDatasetQuery({
     database: SAMPLE_DB_ID,
+    query: {},
   }),
 });
 

frontend/src/metabase/dashboard/components/DashCard/DashCardParameterMapper/DashCardCardParameterMapper.unit.spec.jsx

@@ -50,7 +50,11 @@ const setup = options => {
 
 describe("DashCardParameterMapper", () => {
   it("should render an unauthorized state for a card with no dataset query", () => {
-    setup();
+    const card = createMockCard({
+      dataset_query: createMockStructuredDatasetQuery({ query: {} }),
+    });
+    setup({ card });
+
     expect(getIcon("key")).toBeInTheDocument();
     expect(
       screen.getByLabelText(/permission to see this question/i),