Merge pull request #3083 from metabase/data-reference-instrumentation

Data reference instrumentation

frontend/src/metabase/query_builder/template_tags/TagEditorHelp.jsx

@@ -57,7 +57,7 @@ const TagExample = ({ datasetQuery, setQuery }) =>
                 <div
                     className="Button Button--small"
                     data-metabase-event="QueryBuilder;Template Tag Example Query Used"
-                    onClick={ () => setQuery(datasetQuery, true) }
+                    onClick={() => setQuery(datasetQuery, true) }
                 >
                     Try it
                 </div>
@@ -101,7 +101,7 @@ const TagEditorHelp = ({ setQuery, sampleDatasetId }) => {
                 you should link that variable to a specific column. Dimensions should be used inside
                 of a "WHERE" clause.
             </p>
-            <TagExample datasetQuery={EXAMPLES.dimension} setQuery={setQueryWithSampleDatasetId} />
+            <TagExample datasetQuery={EXAMPLES.dimension} />
 
             <h4>Optional Clauses</h4>
             <p>

frontend/src/metabase/query_builder/template_tags/TagEditorParam.jsx

@@ -86,7 +86,7 @@ export default class TagEditorParam extends Component {
                         <Option value="text">Text</Option>
                         <Option value="number">Number</Option>
                         <Option value="date">Date</Option>
-                        <Option value="dimension">Dimension</Option>
+                        <Option value="dimension">Field Filter</Option>
                     </Select>
                 </div>
 

frontend/src/metabase/reference/containers/ReferenceEntity.jsx

@@ -214,6 +214,7 @@ export default class ReferenceEntity extends Component {
                                             <Link
                                                 to={section.headerLink}
                                                 className={cx("Button", "Button--borderless", R.editButton)}
+                                                data-metabase-event={`Data Reference;Entity -> QB click;${section.type}`}
                                             >
                                                 <div className="flex align-center relative">
                                                     <span className="mr1">See this {section.type}</span>

frontend/src/metabase/reference/reference.js

 import { handleActions, createAction } from 'metabase/lib/redux';
+import MetabaseAnalytics from 'metabase/lib/analytics';
 
 import i from 'icepick';
 
@@ -15,10 +16,14 @@ const END_LOADING = "metabase/reference/END_LOADING";
 export const endLoading = createAction(END_LOADING);
 
 const START_EDITING = "metabase/reference/START_EDITING";
-export const startEditing = createAction(START_EDITING);
+export const startEditing = createAction(START_EDITING, () => {
+    MetabaseAnalytics.trackEvent('Data Reference', 'Started Editing');
+});
 
 const END_EDITING = "metabase/reference/END_EDITING";
-export const endEditing = createAction(END_EDITING);
+export const endEditing = createAction(END_EDITING, () => {
+    MetabaseAnalytics.trackEvent('Data Reference', 'Ended Editing');
+});
 
 const initialState = {
     error: null,