This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 10, 2023
-
-
Alexander Polyankin authored
-
Mark Bastian authored
Adding a dev-level docker-compose file. Located in /dev and is self-documented.
-
Anton Kulyk authored
* Add script validating e2e test file names * Move helper files to helper directories * Fix whitespace before the first file name * Add node shebang Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Check if staged files include relevant files from `scenarios` folder * Distinguish between staged files and all files * Add precommit hook * Update binning folder structure * Improve glob pattern * Add back forgotten binning constants * Update cross-version folder structure * Update embedding folder structure * Update embedding folder structure * Update dashboard-filters folder structure * Use all caps for global vars * Address feedback: consistency * Simplify functions * Actually exit the process * Adjust script for use with `lint-staged` * Apply another suggestion to optimize script * Improve naming of boolean checks * Fix the init logic --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Alexander Polyankin authored
-
Aleksandr Lesnenko authored
-
Ngoc Khuat authored
* Better API error message for malli schemas * add tests * fix failed test * fix the backward tests * add api localized error message test * add require and fix test
-
Mark Bastian authored
`/api/collection/root/items` now adds `personal_owner_id` to collection results.
-
Nemanja Glumac authored
-
Anton Kulyk authored
-
Nemanja Glumac authored
[ci skip]
-
Nick Fitzpatrick authored
Removing / fixing warnings when updating a dashboard filter and when you have incorrect link templates (#28174)
-
Anton Kulyk authored
-
Ngoc Khuat authored
-
Cal Herries authored
* Create select-action * Rename to select-actions * Remove comments * Remove unnecessary () * Missed one * Fix GET /action/:uuid * Use new fns more * Fix * Remove select-action-without-implicit-params, we don't need it
-
Cam Saul authored
* Enable Kondo `:warn-on-reflection` linter * Enable warnings for metabase.api.setting-test * Add warn-on-reflection to metabase.util.jvm
-
Braden Shepherdson authored
Some JVM-specific functions are now in `metabase.util.jvm`, but they are re-exported (in CLJ) by `metabase.util`.
-
- Feb 09, 2023
-
-
Noah Moss authored
Make sure we're using a user's full list of permission groups when determining whether a sandbox should be enforced (#28198) * make sure we're using the full group list when checking whether a sandbox should be enforced * add simple test that would have caught this bug
-
dpsutton authored
https://github.com/camsaul/toucan2/pull/126 Editing the data model loads a _lot_ of data. It hits the following form from the api: ```clojure (hydrate [:tables [:fields [:target :has_field_values] :has_field_values] :segments :metrics]) ``` On my test instances, with 1500 tables each with 14 fields: 15mb and 359 tables each with 14 fields: 3.69mb. Not great. If you want to recreate, create an empty db, sync it, then ```clojure (time (let [conn (sql-jdbc.conn/db->pooled-connection-spec 3)] (dotimes [n 359] (jdbc/execute! conn [(format "create table if not exists foo_%d (id int, col_1 text, col_2 text, col_3 text, col_4 text, col_5 text, col_6 text, col_7 text, col_8 text, col_9 text, col_10 text, col_11 text, col_12 text, col_13 text, col_14 text)" n)])))) (sync/sync-database! (db/select-one 'Database :id 3) {:scan :schema}) (binding [api/*current-user-permissions-set* (delay #{"/"})] (count (#'metabase.api.database/db-metadata 3 true true))) ``` And the source of the bug was a classic recur with a lazy concat. ```diff diff --git a/src/toucan2/tools/hydrate.clj b/src/toucan2/tools/hydrate.clj index e1d0459..10c9c49 100644 --- a/src/toucan2/tools/hydrate.clj +++ b/src/toucan2/tools/hydrate.clj @@ -456,7 +456,7 @@ (if (empty? hydrated-instances) (concat acc (map :instance annotated-instances)) (let [[not-hydrated [_needed-hydration & more]] (split-with (complement :needs-hydration?) annotated-instances)] - (recur (concat acc (map :instance not-hydrated) [(first hydrated-instances)]) + (recur (vec (concat acc (map :instance not-hydrated) [(first hydrated-instances)])) more (rest hydrated-instances)))))) ```
-
Aleksandr Lesnenko authored
-
Ryan Laurie authored
* support executing actions in public dashboards * fix conflict with public actions
-
Cam Saul authored
-
Case Nelson authored
-
Nemanja Glumac authored
-
Noah Moss authored
* allow untranslated setting descriptions in tests * tweaks
-
Ngoc Khuat authored
-
Mark Bastian authored
Upgrade to Jetty 11 via https://github.com/sunng87/ring-jetty9-adapter. Required updating from javax servlet packages to jakarta, since jakarta is newer.
-
Alexander Polyankin authored
-
Nemanja Glumac authored
[ci skip]
-
Nemanja Glumac authored
[ci skip]
-
- Feb 08, 2023
-
-
Case Nelson authored
* Adding support for timezone awareness to mongo * Remove unused ddl multimethod * Remove mongo from the sql driver type test * Fix tests and linters * Add test for filtering datetimes by date in timezone * Use test-data-with-timezones dataset as it should load in more dbs * Exclude broken drivers, vertica especially returns no rows * Address pr review, add timezone to isodate, include a full year of dates in the general timezone test * Assert against each row * Presto-jdbc year was not applying timezone
-
Aleksandr Lesnenko authored
-
Braden Shepherdson authored
This is needed with the move to `deps.edn` for tracking all dependencies, since it makes shadow-cljs rely on the `clojure` binary.
-
Tim Macdonald authored
-
Braden Shepherdson authored
Includes much-improved testing for the logger in CLJ and CLJS. **This moves us from explicit `shadow-cljs.edn` dependencies to relying on deps.edn for everything. It seems to be working nicely.
-
Alexander Polyankin authored
-
Ngoc Khuat authored
-
Cam Saul authored
-
- Feb 07, 2023
-
-
Braden Shepherdson authored
This has the same interface as `clojure.tools.logging` but supports CLJS as well. It was formerly known as `metabase.shared.util.log`.
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-