Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jan 07, 2022
  2. Jan 04, 2022
    • adam-james's avatar
      JWT Login URL configured by user may have URL parameters (#19381) · 4448b34d
      adam-james authored
      * JWT Login URL configured by user may have URL parameters
      Since params may already exist in the login URL, a check is performed to make sure the generated URL
      with 'return_to' param formats correctly. If a param already exists, all subsequent params should
      have an '&
      character.
      
      * Sorted ns to pass linting
      
      * added issue number to test string for added context.
      Unverified
      4448b34d
    • Alexander Lesnenko's avatar
      Replace enterprise with license page (#19343) · b0309e2c
      Alexander Lesnenko authored
      * remove old store page
      
      * add license pages
      
      * add remove webpack cache command
      
      * lint
      
      * fix specs
      
      * remove license widget from the oss version
      
      * add missing translation
      
      * show loader only for unput when updating token
      
      * fix specs
      
      * amend the license page
      
      * unactivated state fix
      
      * add premium embedding page, refactor, fix specs
      
      * amend the license page
      
      * amend the license page
      
      * change license page padding
      Unverified
      b0309e2c
    • Alexander Polyankin's avatar
      Improve login flow (#19498) · 62f9ccd2
      Alexander Polyankin authored
      Unverified
      62f9ccd2
  3. Dec 28, 2021
    • Cam Saul's avatar
      Database-local Settings (#19399) · b9bee5dc
      Cam Saul authored
      * Rename setting/get and setting/all; GeoJSON via env var tests
      
      * Fix typo (thanks @noahmoss)
      
      * Support Database-local Settings in metabase.models.setting itself
      
      * Rework Settings code so it can handle possibly-already-deserialized values
      
      * Database-local Settings
      
      * Remove empty part of docstring
      
      * Appease linters
      
      * Update dox again
      
      * Use text.type for the new column
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * Test fix :wrench:
      
      * All negative integer values when setting :integer Setting with a string
      Unverified
      b9bee5dc
  4. Dec 26, 2021
  5. Dec 21, 2021
  6. Dec 16, 2021
  7. Dec 14, 2021
  8. Dec 07, 2021
  9. Dec 02, 2021
  10. Nov 24, 2021
  11. Nov 22, 2021
  12. Nov 18, 2021
    • Dalton's avatar
      Reimplement tooltips using tippy.js (#18880) · 80d81a10
      Dalton authored
      * add tippy and react-is
      
      * add tippy styles to vendor.css
      
      we'll probably override most things but it handles
      apply the triangle to tooltips
      
      * reimplement Tooltip using tippy
      
      * reimplement ChartTooltip using Tooltip
      
      * add tooltip theme styling
      
      * fix StoreLink styling
      
      * remove TooltipPopover
      
      * add util for easy mapping to innerRef
      
      * use innerRef util with StoreLink target
      
      * react-is type defs
      
      * convert Tooltip into tsx
      
      * convert styled-components util into typescript
      
      * fix Tooltip fallback return
      
      * use Tooltip in Icon over Tooltipify
      
      * remove Tooltipify
      
      * pass ref all the way through Icon
      
      * fix DimensionListItem styling caused by missing ref
      
      * fix ChartTooltip event target bug
      
      * fix unit test by making Icon.tsx grosser
      
      * replace popover() util with tooltip() in cy tests
      
      * fix random broken e2e test
      
      * improve types in Tooltip
      
      * move everything to a separate folder + add tests
      
      * add more examples
      
      * rmv accidental deps
      
      * fix run button styling
      
      * add Link tooltip prop to avoid tooltip on icon
      
      * wrap MetabotLogo in forwardRef
      
      * support reduced motion
      
      * remove flow type from dom.js so we can use in ts files
      
      * pass isEnabled prop to tippy's disabled prop
      
      once you've activated "control mode" in tippy you can't turn it off so
      using "visible" as a toggle doesn't work. instead, use disabled.
      
      * fix uncentered tooltip the right way
      
      tippy includes padding/margin in its centering calculations, unlike
      tether, so we will need to be careful about adding one-sides
      padding/margins to a tooltip target, otherwise the tooltip will appear
      offcenter
      
      * workaround for absolutely positioned element
      
      the tooltip appeared on the far end of the target because of a child div
      that is absolutely positioned. quick fix is to instead target the icon
      
      * fix positioning of HintIcon tooltip
      
      * lint fix
      
      * add placement prop
      
      * fix styled component tooltip target styling
      
      * place QuestionNotebookButton tooltip below
      
      * Make the NativeQueryButton an actual button
      
      * set tooltip placement to bottom
      
      * lint fix warning
      Unverified
      80d81a10
  13. Nov 09, 2021
    • Anton Kulyk's avatar
      Add ability to turn a dataset back into a question (#18873) · 6bc2fb9f
      Anton Kulyk authored
      * Add `hasPlugin` check to moderation plugin
      
      * Remove border from QuestionModerationSection
      
      * Remove padding from question description
      
      * Reorder imports and exports
      
      * Remove not used prop
      
      * Manage section border in the sidebar
      
      * Add tests for question details sidebar
      
      * Add basic dataset management section
      
      * Add icon for dataset > question action
      
      * Test dataset —> question change
      
      * Add ability to turn a dataset into a question
      
      * Use HTML buttons for dataset management
      
      * Show question verification section
      
      * Fix datasets e2e test helper
      
      * Fix hover effect for dataset action buttons
      
      * Fix question sidebar button alignment
      
      * Use CSS to handle sidebar border
      Unverified
      6bc2fb9f
  14. Nov 05, 2021
  15. Nov 04, 2021
    • Jeff Evans's avatar
      Change all active TEXT columns in MySQL app DB to LONGTEXT (#18749) · b4610877
      Jeff Evans authored
      
      * Change all active TEXT columns in MySQL app DB to LONGTEXT
      
      Add new text.type Liquibase property to dynamically select the correct text type to use, per DB (which is LONGTEXT for MySQL), very similar to the existing blob.type one
      
      Adding new migrations that update all existing app DB TEXT columns to LONGTEXT columns, only for mariadb/mysql
      
      Update migrations linter to ensure no new text types get added, via a new predicate that searches for text types being added
      
      Do the same logic for "blob" now (should be "${blob.type}"), update rule and test
      
      Add test for migrations, that checks the new types, for all types in scope for this PR, to ensure that they have all been changed to their expected DB-specific type (either LONGTEXT for MySQL or TEXT/CLOB for others)
      
      Updating a couple migrations to remove special casing that was originally done only for MySQL to simply make them universally "${text.type}", in order to unify behavior and reduce surprises going forward
      
      Co-authored-by: default avatarCam Saul <github@camsaul.com>
      Unverified
      b4610877
  16. Nov 03, 2021
    • Cam Saul's avatar
      Add NOT NULL constraint to Card.database_id; attempt to set database_id if possible (#18472) · 83de3e86
      Cam Saul authored
      * Drop long-unused Table.entity_name column
      
      * Add NOT NULL constraint to Card.database_id
      
      * Test fix :wrench:
      
      * Test fix :wrench:
      
      * Fix migration
      
      * Add note about H2 shell to deps.edn
      
      * Add new SQL migration to attempt to set database_id when unset
      
      * Remove data migration that is now done in Liquibase land
      
      * Oops, '$.database', not '$.database_id'
      
      * Parse ints as signed rather than unsigned just to be safe (they *might* be -1337 if they're really broken)
      
      * Don't run for H2
      
      * Update comment
      
      * Fix migration indentation
      
      * Clean namespace
      
      * Use new migration number.
      
      * Use the new migration numbers
      
      * Adopt new migration numbering scheme
      
      * Fix comments
      
      * Fix MySQL + MariaDB insanity
      
      * Fix ID range validation
      
      * Actually 382 is the last legacy ID
      
      * Improved validation and tests
      
      * Adopt the new-new migration ID format.
      
      * Test fixes :wrench:
      
      * Fix merge
      
      * Simplify precondition
      Unverified
      83de3e86
  17. Nov 01, 2021
  18. Oct 29, 2021
  19. Oct 26, 2021
  20. Oct 22, 2021
  21. Oct 19, 2021
  22. Oct 18, 2021
  23. Oct 15, 2021
  24. Oct 14, 2021
  25. Oct 12, 2021
  26. Oct 07, 2021
    • Anton Kulyk's avatar
      Fix new questions don't appear in the Saved Questions picker (#18095) · 8c43bd62
      Anton Kulyk authored
      * Enable repro
      
      * Move saved questions virtual DB id to own file
      
      * Add saved question helpers
      
      * Add test-id to Metabase logo component
      
      * Extend repro test to cover archived items handling
      
      * Handle saved question actions in schema entity
      
      * Handle saved question actions in table entity
      
      * Fix moved file import
      
      * Fix Cypress can't find logo in EE (whitelabeling)
      
      * Fix saved questions order
      
      * Fix saved questions included in database tables
      Unverified
      8c43bd62
  27. Oct 06, 2021
    • Howon Lee's avatar
      Erroring question page nits (#18190) · 384218e6
      Howon Lee authored
      Previous PRs for error cards page were laser focused on getting everything to work, as opposed to actually conforming to spec. This one gets it closer to spec, although product wants reloading animations which are not there yet. To wit,
      
      - Indicates to end user what the current running state is. Given the many orders of magnitude in DB query run times I think something robust and non-ephemeral is necessary here (looking at some sort of expanded QE model) but Maz suggested expedient method and I took it
      - No more left nav on the table page
      - Page heading for table page
      - Independent scroll-x behavior on the table
      - Styling for the error section on the table page
      - Select-all component. Note that the interaction behavior with pagination is fiddly. (but less fiddly now that it's all based on card id's instead of row numbers)
      - Coalescing default behavior for Our Analytics collection (default collection) and null number of dashboards
      Rename error name to error content search
      Unverified
      384218e6
  28. Oct 05, 2021
  29. Sep 30, 2021
  30. Sep 29, 2021
Loading