This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 21, 2023
-
-
Alexander Polyankin authored
-
Uladzimir Havenchyk authored
-
Kamil Mielnik authored
* Allow ReactNode as tooltip in Ellipsified - Consistently destructure all imports from react package * Introduce getMarkdownFirstLine * - Extract markdownToHtml - Refactor getMarkdownFirstLine into getLeadingText * Render description as markdown in StaticSkeleton * Cover getLeadingText with tests * Consolidate tests * Extract test-utils * Add initial markdownToHtml tests * Add a test case for a mix of h1 and p * Rename markdownToHtml to convertMarkdownToHtml * Rename convertMarkdownToHtml to renderMarkdownToHtml * Rename renderMarkdownToHtml to renderMarkdown * Add a test case for alt text of an image - e.g. Gmail does this and it's not the desired behavior * Place the tooltip at the bottom (as per design) * Add StaticSkeleton initial test suite * Add test case for not showing description tooltip when description is fully rendered * Rename renderMarkdown to parseMarkdown * Format code * Add an e2e test for markdown rendering in pinned models - Introduce changeCardDescription helper in e2e-collection-helpers - Move openRootCollection to e2e-collection-helpers * Add an e2e test for markdown rendering in pinned native questions * Remove redundant assertions * Add an e2e test for markdown rendering in pinned dashboards * Remove exact: false * Move getLeadingText & parseMarkdown to metabase/lib/markdown * Add markdown tooltip to PinnedItemCard * Add missing import * Add disallowHeading & unstyleLinks props to markdown rendered in tooltips * Add test for markdown tooltip in question visualizations * Support markdown formatting in Skeleton tooltip - add an e2e test case for it - rename changeCardDescription to changePinnedCardDescription * Fix skeleton test * Add an e2e test for model description tooltip on hover * Consolidate pinned model description tooltip tests * Wrap pinned dashboard test in describe * Add an e2e test for dashboard description tooltip on hover * Add an e2e test for pinned native question description tooltip on hover * Add an e2e test for pinned model question description tooltip when ellpsis is and isn't applied * Add an e2e test for pinned dashboard question description tooltip when ellipsis is and isn't applied * Remove unit tests for StaticSkeleton as these cases are covered in e2e tests * Rename changeDashboardDescription to changePinnedDashboardDescription * Update parseMarkdown to use remark instead of react-dom/server - We need to add remark-parse, remark-hype, and unified to package.json but these are not new - they are dependencies of react-markdown - Tests will be updated in subsequent commits * Remove rehype-filter from parseMarkdown * Bring rehypeFilter back as it fixes typing errors in getLeadingText * Remove unit tests for getLeadingText and parseMarkdown - remark-parse used by parseMarkdown is an ESM without a minified commonjs-compliant bundle. We'd have to mock it to make it work but it'd defy the purpose of these tests. They're trivial enough with the usage of remark anyway. * Remove unused test-utils * Merge markdown module into a single file * Optimize getLeadingText * Optimize getLeadingText * Remove dead link to Source Sans Pro font - it caused markdown check to fail during CI, this fixes it - it seems that the font has been removed from Google Fonts - users can still choose this font in Metabase settings - removal confirmation: https://metaboat.slack.com/archives/C5XHN8GLW/p1686320576992299?thread_ts=1686319384.637909&cid=C5XHN8GLW * Don't export types from markdown.ts - and format code * Configure transformIgnorePatterns to allow transforming ESM-based markdown-related dependencies * Add unit tests for parseMarkdown * Add unit tests for getLeadingText * Remove redundant joins * Add description-related unit tests to PinnedItemCard * Add tests for ellipsis * Add tests for description in StaticSkeleton * Revert e2e tests * Revert redundant change * Add a SkeletonCaption test suite with test for markdown support in tooltip * Make SkeletonCaption tooltip placement consistent with the one in StaticSkeleton * Remove metabase/lib/markdown usage from PinnedItemCard * Remove metabase/lib/markdown usage from StaticSkeleton * Remove metabase/lib/markdown and related changes * Update PinnedItemCard unit tests * Add extra assertion to SkeletonCaption tests * Update StaticSkeleton unit tests * Remove unused attribute * Extract MarkdownPreview component * Require children in MarkdownPreview * Fix build * Move detailed markdown tests into new, dedicated MarkdownPreview test suite
-
Dennis Schridde authored
Revert "Compile with direct_link=true (#28357)" and "Respect MB_COLORIZE_LOGS and MB_EMOJI_IN_LOGS environment variables (#31612)" (#31732) This can cause environment variables set at compile time to affect runtime, cf. https://github.com/metabase/metabase/issues/30518. We keep the changes to JVM options and logging startup time, since they were independently useful. This reverts commit e3285698 and commit 380cd8a3.
-
- Jun 20, 2023
-
-
Aleksandr Lesnenko authored
-
Maz Ameli authored
* change Data Model to Table Metadata * update doc references to the page * change name of manage data model permission * fix lint error * fix tests
-
Cam Saul authored
* MLv2: Handle missing Field metadata as long as it is present in Saved Question metadata * Address PR feedback
-
Cam Saul authored
* Implement `suggested-join-condition` * Update docstring * OOOF fix typo in `filter-clause` * Fix premature i18n lookup * Address PR feedback * MLv2 JS join function wrappers * PR feedback from #31590 * `join-conditions` returns raw MBQL clauses! * WIP * Simplify `with-join-alias` and `with-join-fields` * Simplify join and add with-join-conditions * Un-revert dev * Wow! Remove unresolved nonsense. * Remove dev * Remove dev * Test fixes
* PR feedback * WIP * defop doesn't need query or stage-number anymore * Fix Cljs tests for base PR * Test fixes * Test fix * Update JS wrappers -
metamben authored
Fixes #31677.
-
Jerry Huang authored
* initial changes * revert test * fix test
-
shaun authored
Place a nudge card below admin people sidebar if managing over 50 users without a pro account
-
Cam Saul authored
MLv2 Join API Simplification; implement `with-join-conditions`; make join `:alias` required (#31679) * Implement `suggested-join-condition` * Update docstring * OOOF fix typo in `filter-clause` * Fix premature i18n lookup * Address PR feedback * MLv2 JS join function wrappers * PR feedback from #31590 * `join-conditions` returns raw MBQL clauses! * WIP * Simplify `with-join-alias` and `with-join-fields` * Simplify join and add with-join-conditions * Un-revert dev * Test fixes
-
Jerry Huang authored
* rename folder * rename folder
-
Jeff Bruemmer authored
-
Jerry Huang authored
* initial commit * add snowplow schema * change indexmodel to model
-
Alexander Polyankin authored
-
metamben authored
* Include refs for all expressions in :fields whenever present * Remove the :fields clause if only expressions remain in it
-
Ryan Laurie authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Cam Saul authored
* Implement `suggested-join-condition` * Update docstring * OOOF fix typo in `filter-clause` * Fix premature i18n lookup * Address PR feedback * MLv2 JS join function wrappers * PR feedback from #31590 * `join-conditions` returns raw MBQL clauses!
-
Ryan Laurie authored
-
Alexander Polyankin authored
-
Noah Moss authored
* initial prototype w/out statement count parameter * new approach * default-database-role driver method * migration for connection_impersonations table * conn impersonation model, API and tests * impersonation fetch and deletion endpoints * switch test to t2 with-temp * read conn impersonation settings from DB * fix merge issue * add impersonated key to data perms graph and treat it the same as full self-service access * include impersonated key in returned permissions graph * make sure impersonated graph passes StrictDataPerms validation * fix boolean logic * make sure impersonated keyword doesnt cause error when deleting gtaps * clear impersonations as necessary when perms graphs changes * add impersonation support for postgres * fix typo * make sure impersonation updates are a non-lazy seq * add impersonated-user? fn * fix impersonation api tests * fix snippet tests * fix build & exclude connection impersonations from serialization * switch a test to use t2.with-temp * add with-impersonations helper and util tests * move macro and add a connection impersonation driver-level test for postgres * fix rebase issue * more tests and code reorganization * add snowflake test * clarify comment * fix lint errors * fix final kondo error * reorganization * fix one test * fix lint errors * revert change to sql_jdbc.execute from bad merge * make sure perms for all users gets reset after conn impersonation tests * ignore exceptions when restoring perms * fix postgres test * refactor to address bryan's comment * add note about new methods to database changelog * driver method refactor
-
Luis Paolini authored
-
Ngoc Khuat authored
* lint rule to prevent using model/defomdel and clean up model.interface * remove models/do-post-select * no more mdb.u/primary-key
-
Alexander Polyankin authored
-
john-metabase authored
-
Nemanja Glumac authored
-
Ngoc Khuat authored
* Fix cases where revision record even if a dashboard doesn't change it that dashboard has a filter
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix dashboard grid doesn't resize in Firefox * Fix wrong test name * Add FireFox E2E test
-
Cal Herries authored
-
Ngoc Khuat authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Remove unused prop Dashboard's `isEditable` doesn't seem to be passed anywhere expect from the hard-coded `defaultProps`, so it'd better be removed. * Prevent users without dashboard permission to perform Toggling auto-apply filters * Prevent auto-apply filters toast from appearing without curate permission
-
Tim Macdonald authored
[Fixes #29884]
-
- Jun 19, 2023
-
-
Nick Fitzpatrick authored
* updating chart settings popover logic * updating CI tests
-
metamben authored
Fixes #31673
-
Jeff Bruemmer authored
-
Cam Saul authored
* Fix new CSV upload driver names * `upload/load-from-csv` => `upload/load-from-csv!` * `query-table`, not `query-table!`
-
Nick Fitzpatrick authored
-