This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 12, 2024
-
-
Phoomparin Mano authored
* add filter picker skeleton * add filter picker skeleton * add picker in popover use case * reuse FilterColumnPicker * add question filter logic * remove fixed width from popover * add onClose handler * add e2e test skeleton * contain FilterBar in Box in story * add a test for adding filters * update e2e tests * add filter picker to the docs * inline props and functions * update the props
-
Aleksandr Lesnenko authored
* update subscription checkboxes * update spec
-
Noah Moss authored
-
Romeo Van Snick authored
* Allow using the arrow buttons to change the limit value * Add a min prop to the number input * Use base-10 Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Ensure number is integer * Add issue name to unit test Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Romeo Van Snick authored
* Use ParameterValueWidget for default value picker in native parameter settings * Fix e2e test * Fix native filter tests * Fix e2e test * Fix e2e test * Add repro for #44665 * Assert that filter values are shown in the popover. Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Oisin Coveney authored
-
- Nov 09, 2024
-
-
Nemanja Glumac authored
* Remove dead code from browse models page * Use the grid to control the gap * Implement "Add database" button * Add basic unit tests * Make sure the feature works when there are no databases * Add analytics to the db list * Add "Add database" button to the sidebar * Add E2E Snowplow tests * Add unit tests * Deal with authentication in each beforeEeach separately * Add Snowplow E2E test for a database card * Slightly tweak the title line height
-
Chris Truter authored
Search currently returns a detailed list of the scores for each item, which is pretty hefty, and the type is also coupled to the current rankers, which will change in future. Removing from the type to start to just validate that nothing uses it. Best to just not model this. Going to see about just removing it from the BE as well, and put in some other way to debug. Worst case an opt-in query parameter.
-
- Nov 08, 2024
-
-
adam-james authored
* Keep Pivoted Option works in Subscriptions Fixes: #49525 Even though the user could toggle 'Keep data pivoted` in the Sharing Sidebar UI, the setting was not being propagated to the backend, so attachments would not be pivoted. * add a cypress test * add viz settings to get the pivot working * fix for linter * remove eslint ignore --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Mahatthana (Kelvin) Nomsawadi authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Correct embedding hash options type semantically * Pass `X-Metabase-Locale` to embed downloads * wip locale header middleware * Allow smart scalar text to be translated * Stop using global variable * Add more details to embedding types * Extend the E2E util type and correct some properties types * Add e2e test * Fix dashboard name * Add a test for static embed question * Make a type name follows a convention Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Fix failed E2E tests due to missing default values * Fix public embed not working with `?locale` anymore * Revert "wip locale header middleware" This reverts commit 83d8d135. * Preserve locale when in the `as-admin` macro is used Motivating issue: ```shell ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Count" ] ``` I'm running a query that has aggregated columns and it is returning the untranslated. Note that these are computed and dynamically given a display name. ```clojure (case tag :count (i18n/tru "Count") :cum-count (i18n/tru "Cumulative count")) ``` The problem is that we run embedding things as admin. And that gets the current user, which in embed and public spaces is nil, and so binds a nil to user-locale, which defaults to english when translating. After: ``` ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:fr -pb | jq '.data|.cols|map(.display_name)' [ "State", "Nombre de lignes" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124' x-metabase-locale:zh -pb | jq '.data|.cols|map(.display_name)' [ "State", "行数" ] ❯ http get 'http://localhost:3000/api/embed/dashboard/eyJhbGciOiJIUzI1NiJ9.eyJyZXNvdXJjZSI6eyJkYXNoYm9hcmQiOjEyfSwicGFyYW1zIjp7fX0.QZ-tEWpgJeSMUuaPfuH6_VQwM2yXNMcuureWCtHsszU/dashcard/162/card/124 ' x-metabase-locale:es -pb | jq '.data|.cols|map(.display_name)' [ "State", "Contar" ] ``` This is fetching a dashboard's card which is a query of orders grouped by created at month, sum of total. --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> Co-authored-by:
dan sutton <dan@dpsutton.com>
-
- Nov 07, 2024
-
-
Romeo Van Snick authored
* Handle touch start capture as well as mouse down for popover * Also stop event propagation for touch events on menu item
-
Raphael Krut-Landau authored
Closes #49534
-
Raphael Krut-Landau authored
-
Raphael Krut-Landau authored
-
Nemanja Glumac authored
* Move the upload CSV button to the main nav bar * Remove the old `SidebarOnboardingSection` * Remove obsolete unit tests * Rework E2E tests * Add some spacing around the button * Fix E2E test * Break `MainNavbar` unit test down * Expand unit tests * Update E2E tests * Fix E2E test failure * Move JSDoc where it belongs * Provide context for translators * Simplify the condition
-
Oisin Coveney authored
-
Kamil Mielnik authored
Fix - Values from the returned rows not present in the visualization are interpolable in the URL but don't have values (#49530) * Fix #46318 * Add repro for #46318 * Move setup to beforeEach
-
- Nov 06, 2024
-
-
Uladzimir Havenchyk authored
-
Oisin Coveney authored
-
- Nov 05, 2024
-
-
Alexander Polyankin authored
-
Denis Berezin authored
* Add possibility to hide columns in CollectionBrowser * Add tests * Review fixes * Fix e2e
-
Ryan Laurie authored
* add base color palette * add some more comments * fix formatting and color copy-pasta errors * ignore existing bad base color usage --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
Romeo Van Snick authored
* Fix dirty yarn.lock * Use fix width popover for filter pickers * Add e2e test to reproduce #49321 * Do not rely on implementation width for test
-
Romeo Van Snick authored
* Fix missing question type for metrics * Add e2e test to reproduce #49454
-
Romeo Van Snick authored
-
- Nov 04, 2024
-
-
Oisin Coveney authored
-
Phoomparin Mano authored
feat(sdk): ability to enforce the destination collection to save to and hide the collection picker (#49251) * add ability to hide the collection picker * add save options * make sure collectionId is fresh * update sdk question form component * make collectionId accept null * apply saveOptions to sdk components * revert to use initialCollectionId as context name * target the correct collection id * add e2e tests * update e2e tests * move into within * update test * remove collectionId from default args * revert e2e of hide columns * make e2e helper more generic * use saveToCollectionId prop to save to a specific collection * update e2e tests * update comment formatting Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * clean up leftover changes from an earlier version * readme update * indicate that saveToCollectionId is only applicable to static questions * revert QuestionEditor.isSaveEnabled defaults * update comment format * remove unused initialCollectionId prop * experiment: try to fix failing custom-columns e2e --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Romeo Van Snick authored
* Consider a modified question dirty as well * Add e2e tests for 48829
-
Oisin Coveney authored
-
- Nov 03, 2024
-
-
Nick Fitzpatrick authored
* Adding moderated status to entity picker * adjusting verified icon size * size adjustments * e2e test adjustments * removing verified model icon * fixing e2e test * unit test * unit test adjustment
-
- Nov 01, 2024
-
-
Nick Fitzpatrick authored
* Adding moderation status to Dashboards * react sins * verification coll: subselect on card + dashboard * fix the 3 failing BE tests * add an api test for dashboard verification * verified dashboards are never stale * e2e tests * code cleanup * unit test and e2e test cleanup * PR Feedback * backend test fixes * Nick shouldn't touch clojure * type fix * indent * fix last 2 BE tests --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
Romeo Van Snick authored
* WIP: use list picker when searching a single value * Add test case for multi vs non-multi search fields * Update loki snapshots * Add special case to test for multiautocomplete filter * Use single select value in test * Add test for using list picker * Explicitly make sure elements are visible * Do not use list selector when search is disabled * Add margin to multi autocomplete dropdown * Update loki snapshots * Update loki snapshots
-
Raphael Krut-Landau authored
-
Raphael Krut-Landau authored
-
Raphael Krut-Landau authored
-
Denis Berezin authored
* Fix scroll for EditableDashboard in fullscreen mode * Fix scroll for InteractiveDashboard in fullscreen mode * Display fullscreen control to dashboards by default * Fix issue with public shared questions empty footer
-
Romeo Van Snick authored
This reverts commit fedd1466.
-
- Oct 31, 2024
-
-
Nick Fitzpatrick authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Update fullscreen dashboard filter on dark theme * Use the latest base color name Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com> --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-