This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 15, 2024
-
-
Dennis Schridde authored
== Goal == Hide attached DWH database details from anyone incl. admins: * Do not show them in the UI * Do not permit to change them * Do not serialize them - This is what we're adding for H2 snapshots (dumps) with this PR. The aim is that customers cannot gain access to (parts of) credentials, and they cannot break a feature they are paying for by changing connection details. == Implementation == In 592360c9 I wrongly understood that database details would be omitted when dumping to H2, but this is only true for dumping H2 databases. Fix this by omitting database details also when dumping databases with `is_attached_dwh` set. == How to test == To prepare, download a H2 JAR matching the H2 version used by Metabase: ``` wget https://repo1.maven.org/maven2/com/h2database/h2/2.1.214/h2-2.1.214.jar ``` If the H2 version does not match, you will get an error when trying to open the H2 shell: ``` Exception in thread "main" org.h2.jdbc.JdbcSQLNonTransientConnectionException: Unsupported database file version or invalid file header in file "[REDACTED]" [90048-232] ``` === New behaviour === Setting the `is_attached_dwh` field hides the database details from H2 dumps: 1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases. - In addition to the fields you would normally set, also set `is_attached_dwh: true`. - This also works when adding this flag to a database that previously did not have this flag set. 2. Start your Metabase instance. 3. Run `${metabase} dump-to-h2 ./dump-file-h2` to create the H2 snapshot file. 4. Run `java -cp h2-2.1.214.jar org.h2.tools.Shell -url "jdbc:h2:file:./dump-file-h2;ifexists=true"` to open a H2 shell. 5. Verify that `SELECT name,details FROM metabase_database;` shows `{}` for the database you added in step 1 === Original behaviour === Behaviour without setting the `is_attached_dwh` field is unchanged: 1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases. - Only set the fields you would normally set. Do not set `is_attached_dwh` (or set it to `false`). 2. Start your Metabase instance. 3. Run `${metabase} dump-to-h2 ./dump-file-h2` to create the H2 snapshot file. 4. Run `java -cp h2-2.1.214.jar org.h2.tools.Shell -url "jdbc:h2:file:./dump-file-h2;ifexists=true"` to open a H2 shell. 5. Verify that `SELECT name,details FROM metabase_database;` shows a non-empty object (i.e. not `{}`) for the database you added in step 1 Fixes: 592360c9 Closes: https://github.com/metabase/harbormaster/issues/5526
-
Nicolò Pretto authored
* fix(sdk): remove `Cannot update a component XX while rendering a different component` error * test(sdk): introduce jest test to make sure api.basename is set before loading the locale
-
Uladzimir Havenchyk authored
-
Chris Truter authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Update doc on Next JS examples * Make comments consistent and remove typos * Address review Co-Authored-by:
Poom <poom@poom.dev> * Address review Co-authored-by:
Nicolò Pretto <info@npretto.com> --------- Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Nicolò Pretto authored
-
Chris Truter authored
-
- Nov 14, 2024
-
-
Aleksandr Lesnenko authored
* fix hiding incorrect y-axis on hover * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Jeff Bruemmer authored
-
Abed Habli authored
-
Cam Saul authored
-
Oisin Coveney authored
-
Noah Moss authored
-
dpsutton authored
* sync the attached datawarehouse requires either "sync_db" true or a table name it will error ```shell ❯ http post 'localhost:3000/api/notify/db/attached_datawarehouse' x-metabase-apikey:apikey -pb Must provide `sync_db` or a `table_name` to sync ``` It will sync the db when sync_db is true [NOTE: this is outdated. now just omitting the table name will sync the db] ```shell ❯ echo '{"synchronous?": true, "sync_db": true}' | http post 'localhost:3000/api/notify/db/attached_datawarehouse' x-metabase-apikey:apikey -pb { "success": true } ``` It will sync existing tables ```shell ❯ http post 'localhost:3000/api/notify/db/attached_datawarehouse' table_name=existing schema_name=public x-metabase-apikey:apikey -pb { "success": true } ``` it will error if it cannot find a table ```shell ❯ http post 'localhost:3000/api/notify/db/attached_datawarehouse' table_name=new schema_name=public x-metabase-apikey:apikey -pb { "cause": "Unable to identify table 'public.new'", "data": { "schema_name": "public", "status-code": 404, "table_name": "new" }, "message": "Unable to identify table 'public.new'", "schema_name": "public", "table_name": "new", "trace": [], "via": [ { "data": { "schema_name": "public", "status-code": 404, "table_name": "new" }, "message": "Unable to identify table 'public.new'", "type": "clojure.lang.ExceptionInfo" } ] } ``` if i create that table ```sql attached=# create table new (id int); CREATE TABLE ``` it will then find and sync it ```shell ❯ http post 'localhost:3000/api/notify/db/attached_datawarehouse' table_name=new schema_name=public x-metabase-apikey:apikey -pb { "success": true } ``` * formatting * Tests for attached datawarehouse * PR nits typo in `thorw` -> `throw` comment explaining why `find-and-sync-new-table` is always sync gensym the db name in test remove a binding for a fn `sync!` that's only called once test `{:sync_db true}` syncs the whole db * stupid formatting
* Use absence of table_name as indicator to sync database -
Mahatthana (Kelvin) Nomsawadi authored
* Fix smartscalar texts to use user locale * Fix Pie chart texts to use user locale * Fix line chart tooltip texts to use user locale * Add trend chart assertions * Add pie chart assertions * Add line chart other series tooltip assertions * Update frontend/src/metabase/visualizations/echarts/pie/constants.ts Co-authored-by:
Nicolò Pretto <info@npretto.com> * Fix failed E2E tests --------- Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Nicolò Pretto authored
-
Chris Truter authored
-
Uladzimir Havenchyk authored
* ci: attempt to avoid rate trivy rate limit and fix jar path * drop trivy related changes
-
Oisin Coveney authored
-
Uladzimir Havenchyk authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
Chris Truter authored
-
Phoomparin Mano authored
* add background-disabled color * expect background-disabled to be mapped in tests
-
Chris Truter authored
-
- Nov 13, 2024
-
-
Case Nelson authored
Fixes: #49913 In #49786 we handled parameterized STRING types like `STRING(255)` Here we add handling for the other other types https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#parameterized_data_types `BIGDECIMAL` and `DECIMAL` are aliases for `BIGNUMERIC` and `NUMERIC` https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#parameterized_decimal_type
-
Cam Saul authored
-
adam-james authored
* Apply Column Sort To Pivot Sections Fixes #49437 This PR fixes the dataset API so that column sorts (ascending/descending settings on pivot-rows and pivot-cols) are properly parsed and passed through the QP. After that, I've also modified the post processor to use the sort orders properly in pivoted exports. * println debugging :) * fixing a few tests * fix a few more tests
-
github-automation-metabase authored
-
Ryan Laurie authored
* revert (most of) #48910 * remove test code * fix conflict
-
Cam Saul authored
-
Nicolò Pretto authored
* wip: Alert component for SDKError * use the alert component for the default sdk error component * fix tests * update e2e
-
Chris Truter authored
-
Chris Truter authored
-
Chris Truter authored
-
Chris Truter authored
-
Kamil Mielnik authored
* Fix flaky models metadata test * Improve hack
-
- Nov 12, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Update workflow on master * [DEBUG] Disable steps for testing * Add alberto as a reviewer * [DEBUG] modify the branch name for testing * Revert "[DEBUG] modify the branch name for testing" This reverts commit 7d5d8bf8. * Revert "[DEBUG] Disable steps for testing" This reverts commit a8662c9e.
-
Cam Saul authored
* Try snowflake 3.19.0 * Deafault to java 21 for drivers * Trigger CI * Try running things with --add-opens to see if it solves our problems * Fix `update-view-dashboard-timestamp-test` * Try snowflake 3.19.0 * Deafault to java 21 for drivers * Try running things with --add-opens to see if it solves our problems * Fix `update-view-dashboard-timestamp-test` * Update deps.edn * Switch to Java 21 * Docker image needs to use --add-opens option * Add note about change to Java 21 to driver changelog --------- Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Luis Paolini <paoliniluis@gmail.com>
-
Phoomparin Mano authored
* add filter picker skeleton * add filter picker skeleton * add picker in popover use case * reuse FilterColumnPicker * add question filter logic * remove fixed width from popover * add onClose handler * add e2e test skeleton * contain FilterBar in Box in story * add a test for adding filters * update e2e tests * add filter picker to the docs * inline props and functions * update the props
-
Aleksandr Lesnenko authored
* update subscription checkboxes * update spec
-