This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Dec 15, 2022
-
-
Cal Herries authored
* Add datetimeDiff tests for the same time * Fix redshift for same time args * Duplicate comment
-
Cal Herries authored
* Don't run some tests for drivers not supporting timestamptz * Format rows in tests * Add new dataset specifically for testing the time type. Some drivers don't support time with time zone, so we can't use attempted-murders. * Replace diff-type-test-cases with test-data-with-time
-
Cal Herries authored
* Replace str/lower-case with u/lower-case-en * Replace str/upper-case with u/upper-case-en * Replace more str/lower-case
-
- Dec 14, 2022
-
-
Natalie authored
-
Jeff Bruemmer authored
-
Noah Moss authored
* BE endpoint to clear group membership * update ee group manager tests with clear-memberships
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix can't change locked parameter names in full-app embedding * Remove unused param * Add tests
-
Noah Moss authored
* make auth settings adminOnly on FE * WIP backend changes * Update relevant settings * address lint warning * new tests, and a bunch of reorganization * remove broken EE settings test, and fix validation in google & ldap endpoints * fix cypress tests * add clarifying table to setting docs
-
Nemanja Glumac authored
-
Gustavo Saiani authored
-
Nick Fitzpatrick authored
* Convert to TypeScript, handle ColumnItem and MetadataTable * more progress * handled numeric inputs * Transition InputBlurChange to core Input component * Removing input class from legacy date picker just incase * Small style adjustments in Admin and Viz Settings * working on tests * Tests passing * Adjusting styling * PR Cleanup * add input size=large (#27217) * Suppress console log when using `with-log-messages-for-level` (#26468) * disable additivity when using "with-log-level" * only set when parent is root * wording * remove a test that is no longer needed * fix indents * one missing indent fix * [CI] Add `concurrency` to the `drivers` workflow (#27223) * Fix datetime-diff helper text (#27224) * Improve datetimeDiff type error message (#27225) * Update test * Update implementations * Relieve db pressure on api/health check (#27192) * Relieve db pressure on api/health check https://github.com/metabase/metabase/issues/26266 Servers under heavy load can be slow to respond to the api/health check. This can lead to k8s killing healthy instances happily humming along serving requests. One idea floated was to use QoSFilters https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/servlets/QoSFilter.html to prioritize those requests in front of others. But I suspect this might not be our bottleneck. Our health endpoint was updated to see if it could acquire an endpoint when we were dealing with connection pool issues. We were reporting the instance was healthy once it has finished the init process, but would report healthy if 60/15 app-db connections were used and no actual queries could complete. The remedy was adding `(sql-jdbc.conn/can-connect-with-spec? {:datasource (mdb.connection/data-source)})` to the endpoint. But now to get information about the health of the system we have to wait in the queue to get a datasource. The hope is that this change which monitors for recent db checkins (query success) and checkouts (query begun) can be a proxy for db activity without having to wait for a connection and hit the db ourselves. Some simple and crude benchmarking: - use `siege` to hit `api/database/<app-db>/sync_schema` - in a separate tab, use `siege` to hit `api/health` Three trials with unconditional db access and conditional db access (look for recent activity set by the new `ConnectionCustomizer`). One siege client is synching the app-db's schema with 80 clients each sending 60 requests. the other has 1 client sending 60 requests to api/health. Run | Elapsed Time | max tx | tx rate before change | 7.16s | 0.79s | 8.38 tx/s before change | 23.91s | 1.44s | 2.51 tx/s before change | 13.00s | 0.50s | 4.62 tx/s ---------------------------------------------------- after change | 4.46s | 0.27s | 13.45 tx/s after change | 5.81s | 0.61s | 10.33 tx/s after change | 4.54s | 0.44s | 13.22 tx/s Full(er) results below: ``` Unconditional db access ======================= siege -c80 -r 40 "http://localhost:3000/api/database/2/sync_schema POST" -H "Cookie: $SESSION" siege -c 1 -r 60 "http://localhost:3000/api/health " Elapsed time: 7.16 secs Response time: 0.12 secs Transaction rate: 8.38 trans/sec Longest transaction: 0.79 Shortest transaction: 0.01 Elapsed time: 23.91 secs Response time: 0.40 secs Transaction rate: 2.51 trans/sec Longest transaction: 1.44 Shortest transaction: 0.02 Elapsed time: 13.00 secs Response time: 0.22 secs Transaction rate: 4.62 trans/sec Longest transaction: 0.50 Shortest transaction: 0.06 Conditional db access ============================================================== Elapsed time: 4.46 secs Response time: 0.07 secs Transaction rate: 13.45 trans/sec Longest transaction: 0.27 Shortest transaction: 0.01 Elapsed time: 5.81 secs Response time: 0.10 secs Transaction rate: 10.33 trans/sec Longest transaction: 0.61 Shortest transaction: 0.00 Elapsed time: 4.54 secs Response time: 0.08 secs Transaction rate: 13.22 trans/sec Longest transaction: 0.44 Shortest transaction: 0.01 ``` * Remove reflection in `.put` call (not the reflections trategy) also remove the call to `classloader/the-classloader` as it did nothing * Comment and settle on a single method * tests * select from db twice had a failure in CI. give it time to do its thing with another db call * block to wait for timestamp update? * unflake the tests tasks and events from outside the thread can hit the db. the ConnectionCustomizer is also run from c3p0 controlled threads so we can't easily isolate everything to our thread Was running ```clojure (comment (dotimes [n 5] (dotimes [_ 100] (recent-activity-test) (CheckinTracker-test)) (println (* (inc n) 100))) ) ``` to run the tests 500 times and would keep getting flakes at a rate ~1/100 to 1/500. Just frustration for the future. * typehint * Switch it up a bit Tests were flaking in h2 and I don't know why. I'm switching to just updating recent activity on most methods. * final touches Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by:
dpsutton <dan@dpsutton.com>
-
dpsutton authored
* Relieve db pressure on api/health check https://github.com/metabase/metabase/issues/26266 Servers under heavy load can be slow to respond to the api/health check. This can lead to k8s killing healthy instances happily humming along serving requests. One idea floated was to use QoSFilters https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/servlets/QoSFilter.html to prioritize those requests in front of others. But I suspect this might not be our bottleneck. Our health endpoint was updated to see if it could acquire an endpoint when we were dealing with connection pool issues. We were reporting the instance was healthy once it has finished the init process, but would report healthy if 60/15 app-db connections were used and no actual queries could complete. The remedy was adding `(sql-jdbc.conn/can-connect-with-spec? {:datasource (mdb.connection/data-source)})` to the endpoint. But now to get information about the health of the system we have to wait in the queue to get a datasource. The hope is that this change which monitors for recent db checkins (query success) and checkouts (query begun) can be a proxy for db activity without having to wait for a connection and hit the db ourselves. Some simple and crude benchmarking: - use `siege` to hit `api/database/<app-db>/sync_schema` - in a separate tab, use `siege` to hit `api/health` Three trials with unconditional db access and conditional db access (look for recent activity set by the new `ConnectionCustomizer`). One siege client is synching the app-db's schema with 80 clients each sending 60 requests. the other has 1 client sending 60 requests to api/health. Run | Elapsed Time | max tx | tx rate before change | 7.16s | 0.79s | 8.38 tx/s before change | 23.91s | 1.44s | 2.51 tx/s before change | 13.00s | 0.50s | 4.62 tx/s ---------------------------------------------------- after change | 4.46s | 0.27s | 13.45 tx/s after change | 5.81s | 0.61s | 10.33 tx/s after change | 4.54s | 0.44s | 13.22 tx/s Full(er) results below: ``` Unconditional db access ======================= siege -c80 -r 40 "http://localhost:3000/api/database/2/sync_schema POST" -H "Cookie: $SESSION" siege -c 1 -r 60 "http://localhost:3000/api/health" Elapsed time: 7.16 secs Response time: 0.12 secs Transaction rate: 8.38 trans/sec Longest transaction: 0.79 Shortest transaction: 0.01 Elapsed time: 23.91 secs Response time: 0.40 secs Transaction rate: 2.51 trans/sec Longest transaction: 1.44 Shortest transaction: 0.02 Elapsed time: 13.00 secs Response time: 0.22 secs Transaction rate: 4.62 trans/sec Longest transaction: 0.50 Shortest transaction: 0.06 Conditional db access ============================================================== Elapsed time: 4.46 secs Response time: 0.07 secs Transaction rate: 13.45 trans/sec Longest transaction: 0.27 Shortest transaction: 0.01 Elapsed time: 5.81 secs Response time: 0.10 secs Transaction rate: 10.33 trans/sec Longest transaction: 0.61 Shortest transaction: 0.00 Elapsed time: 4.54 secs Response time: 0.08 secs Transaction rate: 13.22 trans/sec Longest transaction: 0.44 Shortest transaction: 0.01 ``` * Remove reflection in `.put` call (not the reflections trategy) also remove the call to `classloader/the-classloader` as it did nothing * Comment and settle on a single method * tests * select from db twice had a failure in CI. give it time to do its thing with another db call * block to wait for timestamp update? * unflake the tests tasks and events from outside the thread can hit the db. the ConnectionCustomizer is also run from c3p0 controlled threads so we can't easily isolate everything to our thread Was running ```clojure (comment (dotimes [n 5] (dotimes [_ 100] (recent-activity-test) (CheckinTracker-test)) (println (* (inc n) 100))) ) ``` to run the tests 500 times and would keep getting flakes at a rate ~1/100 to 1/500. Just frustration for the future. * typehint * Switch it up a bit Tests were flaking in h2 and I don't know why. I'm switching to just updating recent activity on most methods.
-
Cal Herries authored
* Update test * Update implementations
-
Cal Herries authored
-
Nemanja Glumac authored
-
Ngoc Khuat authored
* disable additivity when using "with-log-level" * only set when parent is root * wording * remove a test that is no longer needed * fix indents * one missing indent fix
-
- Dec 13, 2022
-
-
Nemanja Glumac authored
-
Braden Shepherdson authored
This was using the CLJS code at master, so type-checking fails if you add new CLJS functions and use them from CLJS in the same PR.
-
john-metabase authored
Updates embedded H2 driver to v2.1.212. When a local H2 v1 file-based application database is detected, it will be automatically updated in-place at startup. Migrations and tests have been updated to account for changes in H2 behavior. Sample data and test harness database files in the repo have all been updated to H2 v2 file format. Co-authored-by:
Braden Shepherdson <braden@metabase.com> Co-authored-by:
Cam Saul <github@camsaul.com> Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
Cam Saul authored
* Remove more misc unused backend stuff * Remove unused requires
-
Cam Saul authored
-
Cam Saul authored
* Remove more misc unused stuff * Ok, name field is still used
-
Cam Saul authored
-
Cam Saul authored
* Remove `sql.qp` stuff deprecated in 41 and 42 * Remove old test * We still need to import `FieldInstance`
-
Nemanja Glumac authored
* Migrate Mongo 5 ssl driver test to GitHub Actions * Migrate Mongo 4 ssl driver test to GitHub Actions * Make Mongo certificates available * Try `docker exec` for Mongo 4.0 * Remove `TTY` from the `exec` * Try overriding the entrypoint * Include `mongod` in entrypoint * Quote entrypoint command * Quote only the command * Omit `--dbpath` * Try running the docker container manually * Detach containers * Reduce the timeout
-
Nemanja Glumac authored
* Remove Presto 186 config We've already migrated it to GitHub actions. * Migrate Presto JDBC driver test to GitHub Actions * Wait for port to be ready * Try `presto-jdbc` driver * Wait for port before creating certificates
-
Anton Kulyk authored
* Add basic raw data picker for app scaffolding (#25997) * Show data app page ID params in editing mode (#25943) * Data apps layout updates (#25930) * play with grid sizes to make apps feel appier [ci skip] * move app nav to bar inside app * only hide other header buttons outside of edit mode * tweak overflow issue * fix header width on data apps * add control to see app contents * set data apps layout constants contextually [ci skip] * remove hardcoded value [ci skip] * extract conextual header styles [ci skip] * set max-width on paramaters for data apps [ci skip] * move data apps nav deeper, only show if not editing [ci skip] * add spacing to contents trigger, rm old code [ci skip] * rm table thing for now [ci skip] * Fixes for data app layout updates (#25962) * Reorder import * Fix type * Fix missing translation, move out URL * Remove not used import * Rework `getSelectedItems` utility for data apps * Fix selected data app page highlighting * Don't reload app navbar on page change * Change nav item links look * Remove `DataAppPageSidebarLink` * Turn nav into HTML list * Use styled components * Fix edit button covered by visualizations * Fix opening homepage * Remove redundant prop Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> * First take at parameterized data app page titles (#25938) * Bring `DataAppContext` back * Pass `onFocus` and `onBlur` to `EditableText` * Export `EditableTextProps` * Add basic `DataAppPageTitle` component * Use `DataAppPageTitle` * Fix component name * Add primitive autocompletion to page title input * Add `title_template` to `DataAppNavItem` type * Tweak value management in `DataAppPageTitle` * Handle `null` values in titles more gracefully * Don't show suggestions without detail cards * Don't add whitespace when pasting a token * Don't update app's collection all the time * Add data app related selectors to dashboard selectors * Add redux state to keep title template changes * Update page title template on page save * Wire up `DataAppPageTitle` with dashboard code * Fix unit tests * Reset state on exiting editing mode * Add back button to template data picker * Add `PanePicker` UI component * Add basic `RawDataPanePicker` component * displays databases, schemas, tables * allows picking a database and a schema (no tables yet) * Allow picking tables Supports single-selection and multi-selection modes * Auto-select single database schema * Use `.ts` instead of `.tsx` for hook file * Style `PanePicker` * Add `onTablesChange` callback prop to data picker * Use new data picker in new app modal * Use new data picker in add data modal * Remove `DataAppDataPicker` Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com> * Make `DataPicker` controlled (#26018) * Add data type picker to scaffolding data picker (#26019) * Move `useSelectedTables` one level up * Extract `DataPickerSelectedItem` type * Add `type` to `DataPickerValue` type * Handle `type` in `useDataPickerValue` hook * Add data type picker step * Add back button to raw data picker * Add `CardPicker` * Tweak spacing * Move `VirtualTable` to shared picker types * Temporary disable saved questions data type * Simplify schema loading for models and questions * Remove redundant `useMemo` * Rename `RawDataPanePicker` to `RawDataPicker` (#26020) * Add safety checks to scaffolding data picker (#26023) * Pass available data types as a prop to the picker * Use nested queries settings for data types list * Offer models only if instance has at least one * Check data access * Break `DataPicker` into container and view * Make `DataPicker` cover the whole container * Add items filters API to data app scaffolding data picker (#26024) * Uncomment saved questions data type * Add data picker filters API types * Apply data type filters * Auto pick a data type when only one is available * Export data picker types * Add `DataAppScaffoldingDataPicker` component * Use `DataAppScaffoldingDataPicker` * Improve collection selection for scaffolding data picker (#26033) * Add collection ID to data picker value type * Handle collection ID in `onChange` * Handle collection ID in `CardPicker` * Automatically open root collection * Add basic search to scaffolding data picker (#26039) * Add data picker context * Add global search to data picker * Add basic search UI to new app modal * Don't use database ID in search * Scope search depending on selected data type * Expose more data picker types * Style search input * Keep filtered out data types in mind for search * Move `MIN_SEARCH_LENGTH` to constants file * Fix can't select nested collection in card picker (#26122) * Fix conflicts Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com>
-
Anton Kulyk authored
* Extend `field` types * Add series types * Fix `FieldId` type import * Add `metabase/visualizations/types` * Add drill types * Specify `Question.prototype.pivot` return type * Update `AutomaticDashboardDrill` * Update `ColumnFilterDrill` * Update `CompareToRestDrill` * Update `DashboardClickDrill` * Update `DistributionDrill` * Update `ForeignKeyDrill` * Update `ObjectDetailDrill` * Update `PivotByCategoryDrill` * Update `PivotByLocationDrill` * Update `PivotByTimeDrill` * Update `QuickFilterDrill` * Update `SummarizeColumnByTimeDrill` * Update `SummarizeColumnDrill` * Update `UnderlyingRecordsDrill` * Update `ZoomDrill` * Update `FormatDrill` (former `FormatAction`) * Update `SortDrill` (former `SortAction`) * Update `NativeDrillFallback` * Fix types * Fix handling missing `clicked` object * Simplify drill type hierarchy
-
- Dec 12, 2022
-
-
Cam Saul authored
* Remove unused `metabase.models.table` `metrics` and `segments` functions * Remove more unused
-
Jeff Bruemmer authored
-
Luis Paolini authored
* Add app colors example * Update docs/configuring-metabase/environment-variables.md Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * formatting Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
jeff bruemmer <jeff.bruemmer@gmail.com>
-
Luis Paolini authored
-
Luis Paolini authored
-
Luis Paolini authored
-
Luis Paolini authored
-
Luis Paolini authored
-
Luis Paolini authored
-
Nemanja Glumac authored
* Migrate BigQuery SDK driver test to GitHub Actions * Migrate Google related classpath drivers test to GitHub Actions * Multi-line strings are not working? * Provide BQ envs
-
Cal Herries authored
* Add quarter for postgres * Add quarter to schema * Add quarter tests * Add quarter for mysql * Add quarter for bigquery * Add quarter for snowflake * Add quarter for redshift * Add quarter for vertica * Add quarter for sqlserver * Add quarter to docs * Fix snowflake implementation * Make time zone dataset smaller * Revert "Make time zone dataset smaller" This reverts commit 4c97048d6c01e0f83b259a00c39d34169036fe77. * Revert "Revert "Make time zone dataset smaller"" This reverts commit d1b8fc49c8bf86fecd9897a7c4f496dbdb1b9b06. * Fix test for drivers not supporting set-timezone
-
metamben authored
This is to enable _ as field name.
-