This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 05, 2023
-
-
metabase-bot[bot] authored
* Ensure implicit actions are created in a deterministic order * Add missing lint-staged step for JS, TS under `e2e/*` Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
metabase-bot[bot] authored
* Rework repro for 16382 * Merge multiple "connection settings" tests together * Merge multiple "scheduling settings" tests together * Merge tiny test with the main body * Remove redundant tests * Rework the sample database action sidebar * Handle database exceptions in one spec * Move stray database test to exceptions spec * Move Postgres SSL test to external * Group together Google service account JSON tests * Custom caching * Move remaining pieces of add to external * Rename spec to `add-new-database` * Move repro for 20471 to exceptions * Add segments and metrics to the database we want to delete * Add `visitDatabase` helper Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Apr 03, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Mar 29, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Mar 28, 2023
-
-
Nemanja Glumac authored
* Updating to cypress 12 * updating deps * Updating Tests. Be Green Plz * removing custom test id from select button * Select Button Tuning Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
metabase-bot[bot] authored
Add a reproduction for dashboard sticky filter incorrectly positioned when moving between dashboards (#29497) (#29596) * Add a repro for #26230 * Move the prep phase to the `beforeEach` * Use `visitDashboard` helper * Wait for the second dashboard to load * You don't have to use `within` here * Add a comment * Add main repro assertion * Greatly simplify creation of the markdown card * Update the test title --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
- Mar 27, 2023
-
-
Denis Berezin authored
-
metabase-bot[bot] authored
* Revert "Fix zoom in drilldown for FKs (#28022)" (#29551) --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com> Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
- Mar 25, 2023
-
-
metabase-bot[bot] authored
* keep standalone values when collapsing column * adjusting unit test * PR Feedback * adding space * removing only * Adjusting behavior and tests * adjusting data_grid unit tests Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
- Mar 23, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
metabase-bot[bot] authored
* Add action.dataset_query to search results * Add action.database_id to search results * Unskip repro * better FE error handling for action query display * update repro --------- Co-authored-by:
Tim Macdonald <tim@metabase.com> Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
metabase-bot[bot] authored
* Remove usages of `cy.addFilterToDashboard` custom command * Fully remove `cy.addFilterToDashboard` custom command Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Mar 22, 2023
-
-
Ryan Laurie authored
* Actions/e2e model actions tests (#29295) * extract model creation helper * update model actions test to actually mutate data * fix merge conflicts and clean up # Conflicts: # e2e/test/scenarios/models/model-actions.cy.spec.js * don't assert not found
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
metabase-bot[bot] authored
* show all subscriptions in notification management page regardless of collection perms * strip cards and recipients if necessary * indentation tweak * add backend tests * add cypress repro * fix permissions check * slightly different approach * fix cypress test * fix test * address comment Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- Mar 21, 2023
-
-
Uladzimir Havenchyk authored
-
- Mar 20, 2023
-
-
metabase-bot[bot] authored
* make object detail work for non-logged-in users * update types to account for optional params * test public object detail viz Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
metabase-bot[bot] authored
* fix missing group by columns from joined tables * fix spec Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
metabase-bot[bot] authored
* Fix custom field type aggregation not showing When the origin table don't have that field type. * Add tests * Remove puzzle driven development comments * Make `getAggregationOperators` API more apparent Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- Mar 18, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
- Mar 17, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
metabase-bot[bot] authored
* Extract `parseArguments` into utils * Allow custom browser for Cypress snapshots generation Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
- Mar 16, 2023
-
-
metabase-bot[bot] authored
* Updating graph.metrics when column is removed * updating logic and adding unit tests Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
* Fix empty database picker state * Remove redundant `requireWriteback` occurrences * Update test * Update test * Use clearer names * Don't show query language message for actions * Use database `hasActionsEnabled` method * Remove `requireWriteback` prop * Respect `readOnly` prop in `DataSourceSelectors` * Extend e2e test coverage * Use `setActionsEnabledForDB` in Cypress * Fix data picker behavior Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
- Mar 15, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
- Mar 14, 2023
-
-
metabase-bot[bot] authored
* adding hasMultipleDimensions check to hasLegend clause * Adding queryBuilderMain helper * PR Feedback * remove only Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
metabase-bot[bot] authored
* fix exclude date filter serialization * review Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
Aleksandr Lesnenko authored
* try fixing collections flake * update spec
-
metabase-bot[bot] authored
Co-authored-by:
Gustavo Saiani <gus@metabase.com>
-
- Mar 13, 2023
-
-
metabase-bot[bot] authored
* only save changed dashboards * test early return from save action * remove problematic api wait for dashboard save * deeply compare cards and add better tests * update failing e2e test Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
metabase-bot[bot] authored
Fixes #25378 When using a relative filter with a starting from n units ago on an aggregation with the same units, we were incorrectly assuming that we would be working with a field ref at the top level. However, in this scenario the field is nested such as `[:+ [:field $created_at {:temporal-unit :month}] [:interval 1 :month]]`. This change makes sure that we are altering the field-ref. Co-authored-by:
Case Nelson <case@metabase.com>
-
metabase-bot[bot] authored
* composite key object detail test * add tests for no primary keys * fix rebase * allow db sync to wait on the presence of a specific table Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
metabase-bot[bot] authored
* Adding Show Total toggle, adding unit tests * adjusting unit test, fixing logic * Adding Static Viz test. PR Feedback Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
- Mar 10, 2023
-
-
Aleksandr Lesnenko authored
-
metabase-bot[bot] authored
* List all actions previously `api/action` required `?model-id=<model-id>`. This caused the FE to DOS the backend looping over each action. On stats I found 350 or so sequential requests, with app-db saturation leading to requests taking from 400ms near the beginning to 7seconds near the end. This makes `model-id` option and now returns actions on all models the user can see. ``` ❯ http GET "localhost:3000/api/action" Cookie:$SESSION -pb [ { "archived": false, "creator": {...}, "creator_id": 1, "database_id": 3, "dataset_query": {...}, "id": 1, "model_id": 1, "name": "source = foo", "parameter_mappings": null, "parameters": [...], ... } ... ] ``` * update frontend for action picker to support single action list endpoint * list actions tests * update actions e2e tests * Return empty vector if no results Running tests locally might return some extra actions not asserted on in the tests. And there you might expect a 200. But CI runs with an empty database and returns no response so you get a 204. Quite annoying and there's no good way to expect a "2xx" status code at the moment. So just return the empty vector so it's always a 200 code. * update actions endpoint unit test mocks * Simplify logic a little * docstring tweak * schema with better error message * update mocks to accept optional modelId * simplify sorting and grouping * make sort case-insensitive * simplify action api test mocks --------- Co-authored-by:
dpsutton <dan@dpsutton.com> Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-