This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 15, 2021
-
-
Ariya Hidayat authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Oct 14, 2021
-
-
Nemanja Glumac authored
-
Noah Moss authored
-
Ariya Hidayat authored
-
Alexander Kiselev authored
-
Ariya Hidayat authored
* Move #18069 to custom column reproductions Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Alexander Lesnenko authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
- Oct 13, 2021
-
-
Alexander Lesnenko authored
-
dpsutton authored
* Relativize links when emitting html from md in pulse/subscriptions Helpful links: - https://awesomeopensource.com/project/vsch/flexmark-java - https://github.com/vsch/flexmark-java/blob/master/flexmark-java-samples/src/com/vladsch/flexmark/java/samples/PegdownCustomLinkResolverOptions.java - https://github.com/vsch/flexmark-java/blob/8a881b73109a287b5f202e2e1fc9f9c497d5eecf/flexmark/src/main/java/com/vladsch/flexmark/html/HtmlRenderer.java#L433 - https://github.com/vsch/flexmark-java/blob/8a881b73109a287b5f202e2e1fc9f9c497d5eecf/flexmark/src/main/java/com/vladsch/flexmark/html/renderer/ResolvedLink.java#L10 This was a pain in the ass. I had been looking for a way to just easily traverse the ast, but this might cause problems since there are spans and text positions everywhere. So i looked at how to change the parser. Everything is so difficult to change. Luckily there was a built-in way to do this with link resolvers, found in a github issue https://github.com/vsch/flexmark-java/issues/308 . And ideally this would be done in the parser but it seems to be done in the html emitter. https://github.com/vsch/flexmark-java/blob/master/flexmark-java-samples/src/com/vladsch/flexmark/java/samples/CustomLinkResolverSample.java And then I got turned around on what is relative or not. What happens if you do something seemingly sane like: ```markdown [a link to google](www.google.com) ``` This is apparently a relative link since it lacks a protocol. And our `resolve-uri` code treats it as such: ```clojure markdown=> (resolve-uri "www.google.com") "http://localhost:3000www.google.com" markdown=> ``` This seems strange to me but is also the behavior on gist.github.com: https://gist.github.com/dpsutton/412502ffa89186487e41885855dfa781 has a link to https://gist.github.com/dpsutton/www.google.com In all, trying to figure out this object oriented factory mess i had 24 tabs open to the source of NodeVisitor, NodeVisitorBase, AstActionHandler, VisitHandler, ParserExtension, NodePostProcessorFactory, etc. It was truly unpleasant. * Remove errant require of mb.util.urls * Ensure the site setting always has a slash when resolving relative The URI class will do some wonky things. Sometimes it feels structural, but it can also just feel like it is combining strings willy nilly. ```clojure (.. (URI. "http://example.com") (resolve "www.google.com") toString) "http://example.comwww.google.com" ``` So ensure that there is a final trailing slash
-
Nemanja Glumac authored
-
Luis Paolini authored
We had a few users who reported that they couldn't connect, this simple lineshould fix that
-
- Oct 12, 2021
-
-
Ariya Hidayat authored
-
Anton Kulyk authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
-
Ariya Hidayat authored
This is more of a quick workaround (read: hack) until we have a better parsing infrastructure. The idea is to have an extra argument to contains/startsWith/endsWith, which will be "case-insensitive" if the comparison is to be carred out by ignoring the case. If this extra argument wasn't specified, then it'll be assumed that the case-sensitive comparison is intended. IOW, this MBQL `["contains", X, Y`] or `["contains", X, Y, {case-sensitive: true}]` will be equivalent to the user-visible custom expression `CONTAINS(X)`. Meanwhile, MBQL `["contains", X, Y, {case-sensitive: false}]` will be mapped to the user-visible custom expresson `CONTAINS(X, Y, "case-insensitive")`. With this, we achieve a lossless conversion for 3 string functions (contains, startsWith, endsWith) when involving case-sensitivity.
-
Alexander Lesnenko authored
-
Luis Paolini authored
* Add MB_SEND_EMAIL_ON_FIRST_LOGIN_FROM_NEW_DEVICE * Update docs/operations-guide/environment-variables.md Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
Alexander Polyankin authored
-
- Oct 11, 2021
-
-
Ariya Hidayat authored
-
dpsutton authored
* Don't render bar charts are sparklines https://github.com/metabase/metabase/issues/18352 A simple select `SELECT 'a', 1 UNION ALL SELECT 'b', 2` would trigger as a sparkline and blow up when comparing. There are two issues: - don't render tables as a sparkline even if it only has two columns - don't compare things that aren't comparable. this solves the first issue, ensuring that tables aren't matched as sparklines * Sparkline should only compare comparable values Check that the columns are temporal or numeric before comparing them. It is only to optionally reverse the order of the results which seems questionable in itself, but we can at least check that they are comparable before attempting to * Ensure tests render as sparklines default was a :table and that adds csv attachments which throw off our tests * unskip repro * remove unnecessary extra line
-
dpsutton authored
Input: 12345.65432 Expected: 12346 Actual: 12346. We were unconditionally adding "." (repeat decimals "0") to the base formatting string. Obviously when the decimals are 0, we are appending "." to the base format string
-
Ariya Hidayat authored
-
Noah Moss authored
-
Anton Kulyk authored
* Unskip the repro test * Fix duplicate variable calc * Fix schema update with blank tables state
-
Alexander Lesnenko authored
* test * Fix inability to change field schema * include db name for diff * unskip repro
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Oct 09, 2021
-
-
Ariya Hidayat authored
tl;dr AdoptOpenJDK is now Temurin (part of Eclipse Adoptium) https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/
-
- Oct 08, 2021
-
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
-