This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jul 12, 2024
-
-
Aleksandr Lesnenko authored
-
bryan authored
* add skip_graph to coll perm PUT - also no longer ignores revision and groups so we don't print this warning: 2024-07-11 16:17:32,293 WARN api.common :: Unexpected parameters at [:put "/api/collection/graph"]: [:revision :groups] * namespace should be a keyword * decode the keyword * add a typehint to avoid reflection * Adds test for skip_graph * handle revision 0
-
Alexander Polyankin authored
* Do not reset `table.columns` when some column is deleted * Do not reset `table.columns` when some column is deleted * Fix * Fix * Make API calls more obvious
-
Alexander Polyankin authored
Add FE repro for the visual glitch when working with models that have an expression with the same name as the column (#45503) * Add FE repro for #35840 * Add FE repro for #35840
-
Uladzimir Havenchyk authored
* do not allow to render empty SaveQuestionModal content when question is already saved and QB rerenders still open SaveQuestionModal there is a moment when content is empty before modal is closed * fixup! do not allow to render empty SaveQuestionModal content
-
Kamil Mielnik authored
-
Nemanja Glumac authored
-
bryan authored
* parallelize coll perm graph group lookup w/ core.async * respond to code review * add + uses ExecutorCompletionService map function * rename test * more tests * no concurrency for cljs * fix timeout + add more tests * use claypoole * cleanup * add kondo hooks for claypoole * cleanup * Can't use libraries that don't have a license Revert "add kondo hooks for claypoole" This reverts commit 9d93b55b28d69267b65260f2b046420d67604361. * ignore unused value -- TODO: check back in on claypoole to see if the kondo config gets merged * fix linter
-
Ryan Laurie authored
* refactor and improve milestone check code * whitespace
-
Ryan Laurie authored
* fix cross-version flakes * more flake fix * fix slack message * tired_face * ref name is what I want already
-
Alexander Polyankin authored
-
Alexander Polyankin authored
* Fix fields in joins * Fix deselecting the last join column * Update frontend/src/metabase/query_builder/components/notebook/steps/JoinStep/JoinStep.unit.spec.tsx Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Fix reference --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Ryan Laurie authored
-
John Swanson authored
This was a huge footgun. We were accidentally limiting *ALL* queries run in our transducer to 1000 results. This included the query to fetch permissions, so when we checked permissions we were checking a small percentage of your *actual* permissions (e.g. 1000 / ~6300 for me on stats).
-
Uladzimir Havenchyk authored
-
metamben authored
* Preserve type namespace of base-type in legacy-expression-for-expression-clause Fixes #44584.
-
github-automation-metabase authored
-
Braden Shepherdson authored
This comes in two parts. **Rebuilt query logic** I rewrote the query exec logic to use one `future` and one `a/go` block, reporting results to a `promise`. This is easier to follow and doesn't leak threads like the original implementation with two `future`s. The single future is guaranteed to exit. It blocks on the BigQuery call. That will either complete or throw an exception. Either the exception or the BigQuery result is sent to the promise, and then the future is complete. The only reference to that future is overwritten after the `promise` resolves, so the `future`, its closure, and its thread don't persist longer than needed. **Return a reducible result** Previously the results were returned as a lazy sequence, but that brings a lot of `seq` overhead, and is a risk of retaining the entire result set in memory until the query is all done. Above all, it doesn't support `reduced?` to explicitly drop any further results. The `thunk` function style of `qp.reducible/reducible-rows` doesn't fit neatly here, so I implemented the reducible logic directly on top of the `Iterable` BigQuery results. **Verifying** This is a bit tricky. I've been testing it like this: - Add a BigQuery database to my instance - Create a saved question and note its ID (say, 123) - Create an API key in (EE) Metabase and save it in an env var - Install the `siege` load testing tool - Install VisualVM and monitor my Clojure REPL process's thread count - `siege --concurrent=15 --time=30s --header="x-api-key: $API_KEY" "http://localhost:3000/api/card/123/query POST"` That will create a bunch of new threads while it's getting called, but within a minute of the last queries they'll gradually drop out of the thread pools and it will return to the baseline number of threads.
-
Alexander Solovyov authored
-
Oisin Coveney authored
-
Uladzimir Havenchyk authored
-
Alexander Polyankin authored
-
Chris Truter authored
-
Romeo Van Snick authored
* Coerce value to array * Add reproduction for #38083
-
Nemanja Glumac authored
* Add reproduction for #44435 * Fix and skip the repro
-
- Jul 11, 2024
-
-
Denis Berezin authored
* Add event handlers docs for SDK * Invert events logic and update documentation * Apply prettier
-
Nemanja Glumac authored
-
Phoomparin Mano authored
* create sdk load question * store question result in sdk context * remove dataset data type * update question * handle navigate to new card * add loading states * fix on query change * update question change logic * refactor question loading and query params * fix ad-hoc question in dashboards * extract useLoadQuestion into a separate hook * cleanup run question on load * revert changes in interactive question component * store original question in the question result state * turn the question into ad-hoc questions * refactor run question methods * add a separate isQueryRunning state for better ux * isQueryRunning should default to false * simulate re-running the query in unit tests * add tests for rendering multiple valid questions * refactor sync question method * extract raw series and computed pivot logic * add getCardAfterVisualizationClick * separate single and multiple question tests * fix import paths * is question native * pass queryResult instead of queryResults * temporarily remove checkNotNull for aggregation picker to avoid sdk crash
-
Alexander Solovyov authored
-
Nemanja Glumac authored
* Fix the markdown preview in model details * Add repro for #34574 * Use real `Tab` instead of a blur * Fix test flakiness
-
Ryan Laurie authored
* properly handle frontend test dependencies * better yarn syntax
-
lbrdnk authored
-
Aleksandr Lesnenko authored
* handle duplicated funnel chart steps * fix import
-
Kamil Mielnik authored
-
Uladzimir Havenchyk authored
It prevents blinking during QB loading - initially we rendered an absolute container with width 0 in the top left corner which caused a blink
-
Uladzimir Havenchyk authored
-
Alexander Solovyov authored
-
Ryan Laurie authored
* WIP flaky test issue creator * add summary and workflows * adjust recent flake period * code cleanup and add tests * Update .github/workflows/flake-status.yml Co-authored-by:
Tim Macdonald <tim@metabase.com> --------- Co-authored-by:
Tim Macdonald <tim@metabase.com>
-
Oisin Coveney authored
-
Kamil Mielnik authored
- getAllCollectionItemNames was breaking the chain in Cypress, so assertions did not know how to wait for DOM to be updated
-