This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 18, 2024
-
-
Jeff Bruemmer authored
-
github-automation-metabase authored
* Fix flaky test * Add extra assertion * Reset hover state * Change order of assertions Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
github-automation-metabase authored
* fix: pass noop as navigateToNewCardFromDashboard from public or embedded dashboard * add e2e test * rework a fix Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* attempt to fix 49537 by removing position relative from the tooltip container * Make echart tooltip container cover all iframe area * Update the E2E test * Update loki snapshots from CI * Re-enable echarts tooltip assertion. I couldn't find a better way to fail these assertions on the previous version of the code, but these assertions are better than nothing. --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
github-automation-metabase authored
* fix: Sync postgres materialized view fields Fixes: #49912 * Disable test for redshift * Fix formatting Co-authored-by:
Case Nelson <case@metabase.com>
-
github-automation-metabase authored
* Update doc on Next JS examples * Make comments consistent and remove typos * Address review Co-Authored-by:
Poom <poom@poom.dev> * Address review --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
- Nov 15, 2024
-
-
github-automation-metabase authored
* XLSX Pivot Export - Initialize Pivot Table with Small Area Ref This PR changes the native pivot export so that we first initialize the pivot table with an area ref that's only the first 2 rows. Prior, I used `AreaReference/GetWholecolumn` which had the side effect of using lots of memory. I think this is related to how the Pivot Table's Cache is built up as you add rows/cols to the pivot definition. So, if you keep the area ref only as wide as the number of columns in the raw data, and just 2 rows, then the cache can stay small. After adding row/column data to the pivot table, you can then modify the area ref to be all rows in the relevant columns (`A:E` for example). This keeps the pivot-table object much smaller in size. * need the extra xml schemas to get this to work I'd like to try find a way around including this extra dep, it's a 13mb jar (ish), and I think that's a little bigger than I'd like * oops, didnt mean to have this in * Add test for pivot table initialization being fast and lean on memory * remove time based assertion, add comments in impl * cljfmt * fix test * Pesky little whitespace --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Oleksandr Yakushev <alex@bytopia.org>
-
github-automation-metabase authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
github-automation-metabase authored
Make sure the query to fetch result_metadata for native sandboxes doesn't use the streaming results handler (#50049) (#50107) Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
github-automation-metabase authored
* XLSX Pivot Exports Now Use The Sort Settings from Viz Settings Prior to this PR, the xlsx pivot exports worked correctly except for the fact that no sorting (ascending or descending) was applied to the pivot rows or columns. Now, those settings are used when they exist. * only try to set sort when a correct setting exists * add ooxml-full dep for correct classes * Update src/metabase/query_processor/streaming/xlsx.clj --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
github-automation-metabase authored
Fixes: #50072 When we `describe-fields` we are passing db details, but sometimes we have the database name in `dbname` rather than in `db` depending on the connection specs and possibly environment. So we check for both now. Co-authored-by:
Case Nelson <case@metabase.com>
-
github-automation-metabase authored
== Goal == Hide attached DWH database details from anyone incl. admins: * Do not show them in the UI * Do not permit to change them * Do not serialize them - This is what we're adding for H2 snapshots (dumps) with this PR. The aim is that customers cannot gain access to (parts of) credentials, and they cannot break a feature they are paying for by changing connection details. == Implementation == In 592360c9 I wrongly understood that database details would be omitted when dumping to H2, but this is only true for dumping H2 databases. Fix this by omitting database details also when dumping databases with `is_attached_dwh` set. == How to test == To prepare, download a H2 JAR matching the H2 version used by Metabase: ``` wget https://repo1.maven.org/maven2/com/h2database/h2/2.1.214/h2-2.1.214.jar ``` If the H2 version does not match, you will get an error when trying to open the H2 shell: ``` Exception in thread "main" org.h2.jdbc.JdbcSQLNonTransientConnectionException: Unsupported database file version or invalid file header in file "[REDACTED]" [90048-232] ``` === New behaviour === Setting the `is_attached_dwh` field hides the database details from H2 dumps: 1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases. - In addition to the fields you would normally set, also set `is_attached_dwh: true`. - This also works when adding this flag to a database that previously did not have this flag set. 2. Start your Metabase instance. 3. Run `${metabase} dump-to-h2 ./dump-file-h2` to create the H2 snapshot file. 4. Run `java -cp h2-2.1.214.jar org.h2.tools.Shell -url "jdbc:h2:file:./dump-file-h2;ifexists=true"` to open a H2 shell. 5. Verify that `SELECT name,details FROM metabase_database;` shows `{}` for the database you added in step 1 === Original behaviour === Behaviour without setting the `is_attached_dwh` field is unchanged: 1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases. - Only set the fields you would normally set. Do not set `is_attached_dwh` (or set it to `false`). 2. Start your Metabase instance. 3. Run `${metabase} dump-to-h2 ./dump-file-h2` to create the H2 snapshot file. 4. Run `java -cp h2-2.1.214.jar org.h2.tools.Shell -url "jdbc:h2:file:./dump-file-h2;ifexists=true"` to open a H2 shell. 5. Verify that `SELECT name,details FROM metabase_database;` shows a non-empty object (i.e. not `{}`) for the database you added in step 1 Fixes: 592360c9 Closes: https://github.com/metabase/harbormaster/issues/5526 Co-authored-by:
Dennis Schridde <63082+devurandom@users.noreply.github.com>
-
github-automation-metabase authored
* fix(sdk): remove `Cannot update a component XX while rendering a different component` error * test(sdk): introduce jest test to make sure api.basename is set before loading the locale Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
github-automation-metabase authored
Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
- Nov 14, 2024
-
-
github-automation-metabase authored
* fix hiding incorrect y-axis on hover * Update Loki Snapshots --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Jeff Bruemmer authored
-
github-automation-metabase authored
Co-authored-by:
Abed Habli <154609371+abdhabli@users.noreply.github.com>
-
Mahatthana (Kelvin) Nomsawadi authored
-
github-automation-metabase authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
github-automation-metabase authored
* sync the attached datawarehouse requires either "sync_db" true or a table name it will error ```shell ❯ http post 'localhost:3000/api/notify/db/attached_datawarehouse' x-metabase-apikey:apikey -pb Must provide `sync_db` or a `table_name` to sync ``` It will sync the db when sync_db is true [NOTE: this is outdated. now just omitting the table name will sync the db] ```shell ❯ echo '{"synchronous?": true, "sync_db": true}' | http post 'localhost:3000/api/notify/db/attached_datawarehouse' x-metabase-apikey:apikey -pb { "success": true } ``` It will sync existing tables ```shell ❯ http post 'localhost:3000/api/notify/db/attached_datawarehouse' table_name=existing schema_name=public x-metabase-apikey:apikey -pb { "success": true } ``` it will error if it cannot find a table ```shell ❯ http post 'localhost:3000/api/notify/db/attached_datawarehouse' table_name=new schema_name=public x-metabase-apikey:apikey -pb { "cause": "Unable to identify table 'public.new'", "data": { "schema_name": "public", "status-code": 404, "table_name": "new" }, "message": "Unable to identify table 'public.new'", "schema_name": "public", "table_name": "new", "trace": [], "via": [ { "data": { "schema_name": "public", "status-code": 404, "table_name": "new" }, "message": "Unable to identify table 'public.new'", "type": "clojure.lang.ExceptionInfo" } ] } ``` if i create that table ```sql attached=# create table new (id int); CREATE TABLE ``` it will then find and sync it ```shell ❯ http post 'localhost:3000/api/notify/db/attached_datawarehouse' table_name=new schema_name=public x-metabase-apikey:apikey -pb { "success": true } ``` * formatting * Tests for attached datawarehouse * PR nits typo in `thorw` -> `throw` comment explaining why `find-and-sync-new-table` is always sync gensym the db name in test remove a binding for a fn `sync!` that's only called once test `{:sync_db true}` syncs the whole db * stupid formatting
* Use absence of table_name as indicator to sync database Co-authored-by:dpsutton <dan@dpsutton.com>
-
github-automation-metabase authored
Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
github-automation-metabase authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
github-automation-metabase authored
* add background-disabled color * expect background-disabled to be mapped in tests Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
- Nov 13, 2024
-
-
github-automation-metabase authored
Fixes: #49913 In #49786 we handled parameterized STRING types like `STRING(255)` Here we add handling for the other other types https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#parameterized_data_types `BIGDECIMAL` and `DECIMAL` are aliases for `BIGNUMERIC` and `NUMERIC` https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#parameterized_decimal_type Co-authored-by:
Case Nelson <case@metabase.com>
-
github-automation-metabase authored
* Apply Column Sort To Pivot Sections Fixes #49437 This PR fixes the dataset API so that column sorts (ascending/descending settings on pivot-rows and pivot-cols) are properly parsed and passed through the QP. After that, I've also modified the post processor to use the sort orders properly in pivoted exports. * println debugging :) * fixing a few tests * fix a few more tests Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
github-automation-metabase authored
-
github-automation-metabase authored
* wip: Alert component for SDKError * use the alert component for the default sdk error component * fix tests * update e2e Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
github-automation-metabase authored
* Fix flaky models metadata test * Improve hack Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
* Allow using the arrow buttons to change the limit value * Add a min prop to the number input * Use base-10 * Ensure number is integer * Add issue name to unit test --------- Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Nov 12, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Update workflow on master * Add alberto as a reviewer * [DEBUG] Disable steps for testing * [DEBUG] modify the branch name for testing * Revert "[DEBUG] modify the branch name for testing" This reverts commit a2c21f4d. * Revert "[DEBUG] Disable steps for testing" This reverts commit e7ab100d.
-
github-automation-metabase authored
Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
github-automation-metabase authored
* add filter picker skeleton * add filter picker skeleton * add picker in popover use case * reuse FilterColumnPicker * add question filter logic * remove fixed width from popover * add onClose handler * add e2e test skeleton * contain FilterBar in Box in story * add a test for adding filters * update e2e tests * add filter picker to the docs * inline props and functions * update the props Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-