This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 18, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
- Oct 11, 2024
-
-
github-automation-metabase authored
* Moving diagnostic state to redux, adding CP action * changing key binding * adding e2e test * adjusting e2e test * type adjustment Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
- Oct 01, 2024
-
-
Romeo Van Snick authored
* Add 'New metric' action to command palette * Add test for 'New metric' in command palette
-
- Aug 20, 2024
-
-
Uladzimir Havenchyk authored
* refactor: sort import members inside destructuring * Show an error message when the temporal unit is not applicable to a dashboard card (#46983) * Fix tests * Add tests * Add tests * Fix types * Fix types --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Jul 08, 2024
-
-
bryan authored
* update e2e test for command pallete to use a valid setting * remove the setting from the ui, make it always true, unless set false from env * remove enable-nested-queries from admin section on fe - fix unused oldValue -> _oldValue * tests aren't allowed to change enable-nested-queries * fix test + disallow setting nested queries from code * we cannot set enable-nested-queries - set the env var instead * add checks for the enable-nested-queries setting * make resolve-source-cards work with enable-nested-queries setting * fix recents uri interception * return enable_nested_queries setting to client * adjust fetchmock url matcher --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
- Jun 11, 2024
-
-
bryan authored
* adds the endpoint and a test * add recents endpoint, todo: tests * add post recents endpoint * return recent views for both lists, but make the endpoint work * Make recent-views context aware - pruning is context aware, only checks for the recently-inserted context - Adds endpoints: - POST to create selection recents, - GET activity/recents - requres context query param to be one of: - all, views, selections - Adds context arg to update-users-recent-views! - Cleans up arg schema for update-users-recent-views * impl GET api/activity/recents - return recent-selections and recent-views from - send context == collection from pinned card reads * update callsites of recent-views/update-users-recent-views! - to use :view param where necessary * fixes models/recent-view tests * adds more activity/recent-view tests * wip - fix whitespace linter * Fix command palette e2e test - reuse util snake-keys * updates fe to use new recents endpoints * fixes fe type issue * snake-keys -> deep-snake-keys - I've been betrayed by lsp rename * snake-keys -> deep-snake-keys - I've been betrayed by lsp rename * log selection events for created collections * mysql doesn't allow default values for TEXT types * log a recent view on data-picker selection * decouple view-log context from card-event view context * fix a doc typo * stop double logging recent-views on POST * maybe fixes some tests * some e2e fixes * fix mysterious divide by zero during score search * fix divide by zero possibilities everywhere in score-items metabase.api.activity/score-items used to throw when there weren't any items being scored (even though there's a `(when (seq items) ...)` check) * more test fixes * fix more e2e tests, + rename endpoint in tests * fix oopsie * fixes a few more tests * address review comments/questions * allow for a comma delimited list in qps like ?context=views,selections returns all recent view items with those contexts, most recent first under the `:recents` key. * refactors FE around new endpoint * fixes for unit tests * use ms/QueryVectorOf for context * fix models/recent_views tests * use multiple query params instead of comma delimited value on FE * ignore timestamp when deduping recents * review comments + test fixing * update docstring * fix api/activity_test s * actually dedupe * add test for deduping by context * e2e fix: shows up-to-date list of recently viewed items after another page is visited * e2e fix: should undo the question replace action * e2e fix: should replace a dashboard card question (metabase#36984) * e2e fix: should preselect the most recently visited dashboard * fix 6 more e2e tests * fixes fe type check and unit failure * renames unit test mocking function * fix a flaky e2e test * widen Item to accept str or kw where sensible - allow strings or keywords for moderated_status, and authority_level * simplify impl + add test * add view-log to events schema * add collection context to view log * fix the final 2 failing e2e tests * click dashboard tab when the user has can-read? on recent entities --------- Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
- May 31, 2024
-
-
Nick Fitzpatrick authored
* initial commit with most types sorted * admin, binning, collections, custom-column and dashboard-cards suites * Filters, Joins, Metrics, Models, Native and Native filters suites * rest of e2e specs * filters, actions, onboarding and custom column will hopfully be green? * fixing static viz, brush filtering, login redirecting, and a few other tests * types green * linter green * hopefully fixes filter tests * I don't often cry, but when I do it's because of filter-types * hopfully sorted the last test that's failing CI * PR Feedback * yarn prettier * React 18 Upgrade - Unit Tests (#41577) * fixes for most unit tests to work with react 18 + upgraded rtl to v15 * fixes all unit tests locally * fixes from rebasing * linter shames me * fix flake in maps.cy.spec.js --------- Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
- May 30, 2024
-
-
bryan authored
* Handles card events for CRU (not D) => recent view * add tests * avoid some errors in dev We expect recent-views/post-process to return nil occasionally (for permissions reasons, or more), so let's filter those out instead of printing a noisy unactionable warning * uncomment and fix test * fix some cypress tests + docs improvements * update more cypress tests * more cypress test updates * adding a card puts it into your recents now * fix notebook-data-source * fix notebook-data-source * fixing more e2e tests * fix command palette e2e tests * run prettier * fix style issue * update notebook-data-source tests * update homepage e2e tests * Next question is in recents, now * update command palette: skip the first pagedown, since it is a noop * check the buttons for their respective names * ensure that the model is there, and no questions are
-
- May 24, 2024
-
-
Nick Fitzpatrick authored
* add media query to search button * useSmallScreen hook
-
- May 15, 2024
-
-
Nick Fitzpatrick authored
* replace search bar with command palette toggle * e2e test part one * onboarding suite * green e2e * unit tests * delete shame
-
- May 07, 2024
-
-
Nick Fitzpatrick authored
* initial attempt * search button * small adjustments * adding back the search bar * adding an extra check in e2e * i18n adjustment * impls pr feedback --------- Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
- May 02, 2024
-
-
Nick Fitzpatrick authored
* Adding Descriptions to search results in palette * Palette Results List component * adjusting e2e and unit tests * type fix * removing duplicate theme font * fix typo, palette types adjustment
-
- Apr 26, 2024
-
-
Nick Fitzpatrick authored
* prioritize recent items, do not filter search results * fixing unit test
-
- Apr 11, 2024
-
-
Nick Fitzpatrick authored
* collection and db breadcrumbs * compact breadcrumbs * adding navigation keybindings * recent_views and search changes to always include collection or db name * removing breadcrumbs, display parent name * removing unneeded components * e2e and FE unit tests * waitFor * e2e tests for keybindings * help * be tests passing * PR feedback and type adjustments * unit test adjustment
-
- Apr 05, 2024
-
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Apr 03, 2024
-
-
Nick Fitzpatrick authored
* Command Palette UI adjustments * move search to end of results list * ellipsis long command palette items, min icon size and showing debounced text * setting fixed width. adjusting admin result icons and text * fixing e2e test
-
- Apr 02, 2024
-
-
Nick Fitzpatrick authored
* command palette trigger in app bar search * remove tabbing to the trigger button
-
- Mar 22, 2024
-
-
Nick Fitzpatrick authored
* Command Palette * small adjustments * unit tests for results * removing dupe component * removing unneeded webpack config * fix linting issue * fixing scroll behavior for settings * moving search results message, adding embedding e2e test * unit tests for palette utils
-