This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 17, 2024
-
-
Noah Moss authored
Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
Romeo Van Snick authored
-
Nicolò Pretto authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .floatLeft, .floatRight * Remove unused components
-
Mahatthana (Kelvin) Nomsawadi authored
-
Nicolò Pretto authored
-
Oisin Coveney authored
-
- Apr 16, 2024
-
-
Denis Berezin authored
* Fix table styles calculation * Review fixes * Fix unit tests
-
Nemanja Glumac authored
* Define the types for the `create` user request * First draft for the create user API using RTK Query * Export RTK user API * Define explicit `create` api for the user entity * Define `updatePassword` mutation * Wire users entity `resetPasswordManual` to use RTK under the hood * Use `updatePassword` mutation * Wire users list calls * Remove unused `update_password` from services * Fix the dispatch used to list users * Dispatch the action type and the payload * Wire `deactivateUser` to work with RTK * Wire `reactivateUser` to work with RTK * Delete unused entries from `UserApi` * Convert the reducer to use `switch` statement * Remove unused user `send_invite` endpoint from FE * Wire `resetPasswordEmail` in users entity to work with RTK * Provide cache invalidation for the `userApi` * Add `provideUserListTags` helper * Pass `email` as a sole argument * Throw on `get` a user This endpoint hasn't been used in a long itme. Removed in https://github.com/metabase/metabase/pull/41334/files#diff-241e0afa11f03a0942eb322aa47695e58496379b0b6d42e6e59ecf6a20fe623cL448 * Use RTK Query to `updateUser` * Fix wrong syntax * Use RTK Query to `getUser` It was used by `.load` and `fetch` after all. * Export `useUpdateUserMutation` * Refactor `getRecipientsList` * Fix response type for the `getUser` * Pass user id as a sole argument instead of in an object * Fix users entity `get` method * Fix the user update password form * Fix unit tests * Fix deactivate and reactivate query invocations See e949812. * Adjust types according to the feedback * Order utils alphabetically * Throw on `delete` * Revert "Fix unit tests" This reverts commit 2c329e836427010ad08bfd0511eb1a9df4ba95d6. * Fix FE unit test mocks * Rename imports to use plural for consistency * Fix one last remaining FE unit test
-
Nemanja Glumac authored
-
Romeo Van Snick authored
* Add list of most popular functions and aggregations * Render 'All functions' link on expression dropdown * Suggest popular functions when no input is given * Do not return focus to search bar * Default to not matching any substring * Open suggestions when the expression editor opens * Group expressions by group * Render group titles in dropdown * Match the expression suggestions height to the design * Add tests for popular functions * Convert tests to it-style * Only return supported popular functions * Limit most used functions group to 5 items * Make the suggestion footer keyboard-accessible * Make a different group for popular aggregations * Remove padding on suggestion list * Resize list * Add test for popular functions in suggest * Move showMetabaseLinks into args * Remove unneeded optional chain * Clarify popup issue in ACE hack * Use correct target for links * Reference correct method in comment * Split up popular expressions * Remove Set around popular functions/aggregations * Do not allow interacting with suggestion header * Do not use _ prefix for variable * Add verb in test * Remove unused async in test * Test if functions are in document * Move tests for suggestWithFooter to separate file * Use correct target in link * Fix typo in key * Allow picking suggestion when textbox is empty * Remove unnecessary cast * Avoid double scroll bars * Only show link to all functions when editor is empty * Split up popular functions between expressions and filters * Fix type of popular variable * Use the same heuristic for footer as for popular expressions * Close suggestions when the editor is not focused * Add missing open prop in test * Simplify test * Add selector for expression editor widget * Fix e2e tests Fix e2e tests * Avoid non-interactive clicks from closing the dropdown * Use custom expression helpers in broken test * Fix test * Remove should exist check for selector
-
Oisin Coveney authored
-
Nicolò Pretto authored
-
Oisin Coveney authored
-
- Apr 15, 2024
-
-
Braden Shepherdson authored
The drill-thru is mostly a stub to put an entry in the context menu. Most of the logic for this is built on the FE using the existing functions for consuming and creating expressions. See [thread](https://metaboat.slack.com/archives/C06P22KS4JH/p1712264174056569) for a lot more context. This also adds `docs/developer-guide/mbql-library-changelog.md` and documents adding this function to the library as the first change in the API. I'll follow up in another PR with Github automation to expect the changelog to be updated whenever `src/metabase/lib/js.cljs` changes. Fixes #39978.
-
Jesse Devaney authored
* fix progress bar in query builder * add spec to verify regression fix
-
Denis Berezin authored
-
Ngoc Khuat authored
-
Nicolò Pretto authored
fix header being rendered (with its border) on dashboard embedded with titled=false and only one tab (#41399) * fix header being rendered (with its border) on dashboard embedded with titled=false and only one tab * embedframe-header -> embed-frame-header
-
Uladzimir Havenchyk authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
- Apr 12, 2024
-
-
Raphael Krut-Landau authored
Adds a Schedule strategy to the Admin / Performance page  [Loom](https://www.loom.com/share/5623cd5d772e417ba2e58c29ae1b8c14?sid=9844f0db-5bb1-4d35-af9b-206d263f5516) As discussed with @luizarakaki, rather than modify the legacy `SchedulePicker` to work with this use case, I made a new version of it - a `Schedule` component - that uses Mantine and a better (though imperfect) approach to localization. For now, the dropdowns are not vertically aligned in this Schedule picker - something I can try to remedy later if that is important. Tests for the Schedule component will be added in a follow-up PR.
-
Denis Berezin authored
* Add interactive question component * Remove excess click actions for embedding * Disable non-working drills * Cleaner components api * Clean up * Review fixes * Fix lint error * Review fixes --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
Uladzimir Havenchyk authored
-
Nick Fitzpatrick authored
* no implicit any on callbacks * cleaning up use of any * small adjustments * PR feedback and unit test adjustment * typing click handler
-
Romeo Van Snick authored
* Add help text icon in expression editor suggestions (#41092) * Add helptext to expression suggestions * Deduplicate getDatabase calls * Allow customising popover width * Split out help text content component * Render an info icon with the help text * Remove duplicated defaults for popover * Explicitly wait for suggestion items in test * Remove commented out code * Use React imports directly * Rename e to evt * Inline getHelpText when creating suggestions * Avoid overlapping content * Remove unnecessary Fragment * Avoid selecting item when clicking link or button inside element * Allow shifting popover * Stop Popover mouse events for bubbling * Use onMouseDown instead of onMouseDownCapture to avoid clicks inside popover from triggering select * Add help text to all suggestions that are know mbql functions * Expression suggestions clean up (#41236) * Move ExpressionEditorSuggestions to tsx * Convert ExpressionEditorSuggestions to functional component * Simplify suggestion match component * Move ExpressionEditorSuggestions a separate folder * Remove default export * Use Popover instead of Tippy for suggestions list * Fix suggestions tests * Remove data-ignore-outside-clicks * Add default for suggestions * Fix e2e test * Move helptext wrapper to ExpressionEditorTextfield * Switch to metabase/ui for Button * Use arrow function
-
Oisin Coveney authored
-
Nicolò Pretto authored
* connect the example dashboard id setting to the embedding homepage (#41138) * connect the example dashboard id setting to the embedding homepage * fix types * Update frontend/src/metabase/home/components/EmbedHomepage/StaticTabContent.tsx Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * use isNotNull --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Oisin Coveney authored
Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Nemanja Glumac authored
-
- Apr 11, 2024
-
-
Raphael Krut-Landau authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .bordered * Migrate .borderBottom, .borderTop * Fix typo * Remove unused classes * Migrate .borderRight * Migrate .borderLeft * Migrate .borderLight * Migrate .borderError * Migrate .borderSuccess * Migrate .borderBrand * Migrate .borderTransparent * Migrate .borderless * Migrate .borderMedium * Review: Add missing CS import
-
Nick Fitzpatrick authored
* collection and db breadcrumbs * compact breadcrumbs * adding navigation keybindings * recent_views and search changes to always include collection or db name * removing breadcrumbs, display parent name * removing unneeded components * e2e and FE unit tests * waitFor * e2e tests for keybindings * help * be tests passing * PR feedback and type adjustments * unit test adjustment
-
Oisin Coveney authored
Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Alexander Polyankin authored
* Replace AlertApi * Replace AlertApi * Replace AlertApi * Fix bugs * Fix bugs * Fix typo --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Uladzimir Havenchyk authored
-
Uladzimir Havenchyk authored
-