This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 17, 2020
-
-
Nemanja Glumac authored
* Restore before each test * Extract repro steps for #13000 into a helper function * Add repro for #13649
-
- Nov 16, 2020
-
-
Nemanja Glumac authored
The bug was fixed in #13808 .
-
Cam Saul authored
-
Paul Rosenzweig authored
* fix scalar error when rendering null * remove ".only" from test * make check for null more explicit
-
Nemanja Glumac authored
* Refactors an original repro for #13000 to use API instead of "clicking" around UI. * Shortens the time to run this test from an average of ~20s to a bit less than ~3s
-
Nemanja Glumac authored
(Filtering Custom Expression from aggregated result fails with column not found)
-
- Nov 13, 2020
-
-
Cam Saul authored
-
Cam Saul authored
* Mega build script improvements 2 * Fix Circle
-
Robert Roland authored
This reverts commit 23ccd0c3.
-
Robert Roland authored
This reverts commit 3e1dab30.
-
Nemanja Glumac authored
-
Cam Saul authored
-
Paul Rosenzweig authored
* pass mb-edition to webpack build * oops. pass "ee" rather than ":ee"
-
Nemanja Glumac authored
(Cannot choose granularity of dates on Summarize with Simple question from Saved Question)
-
flamber authored
-
Nemanja Glumac authored
-
- Nov 12, 2020
-
-
Tim Macdonald authored
[Fixes #7044] Render pulse bar charts with negative values well Also fixes misspelled column name in Avian Singles test dataset * Bump DB prefixes so data gets reloaded to reflect col name change [ci drivers] * Bump test DB version from v2 to v3 [ci drivers] * More BigQuery test fixes
[ci drivers] * Fix Snowflake [ci snowflake] Co-authored-by:Cam Saul <github@camsaul.com>
-
Nemanja Glumac authored
-
Walter Leibbrandt authored
(cherry picked from commit 4148885fd707b50750cefb339f994d7127dce702)
-
- Nov 11, 2020
-
-
Cam Saul authored
* Add a Postgres test [ci postgres] * Mega-optimized SELECT probe query [ci drivers] * Mega sync improvements [ci drivers] * Even more amazing sync perf improvements [ci drivers] * Fix bad edit [ci drivers] * Test/lint fixes
* Test fix [ci drivers] * Some driver fixes [ci drivers] * Address PR feedback [ci drivers] * Test fixes for everything except for Oracle [ci drivers] * Fix Oracle [ci drivers] * Fix Redshift [ci redshift]
-
- Nov 10, 2020
-
-
Cam Saul authored
* Fix Pie chart visualization error when rows contain nils (#13626) * Add positive assertion to CY test * Fix prettier linter * Quarantine the failing part of the "Pie chart" test Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
- Nov 09, 2020
-
-
Nemanja Glumac authored
* Quarantine flaky tests (#13682) (#13683) * Quarantine flaky tests (#13682) * Add TODO note re: `describeWithToken` Co-authored-by: Nemanja Glumac * Add a circleci workflow that runs a set of Cypress smoketests (#12775) * Add a circleci nightly workflow that runs a bigger set of Cypress smoketests * Run this every hour while we're testing it, add a small fix to the admin test * Smoketests: Skip some known failing tests Co-authored-by:
Ariya Hidayat <ariya@metabase.com> * Narrow down the quarantine for chart_drill spec (#13682) (#13699) * CI: Fix the cache key for uberjar for running smoketest (#13698) Smoketest for OSS edition (for now) * Fix `settings/settings.cy.spec.js` flakes (#13701) - isolated flake (`it.only("should surface an error when validation for any field fails (metabase#4506)", () => {...})`) passed 10x (https://github.com/nemanjaglumac/metabase-tests/actions/runs/348275781) - the whole spec passed 20x (https://github.com/nemanjaglumac/metabase-tests/actions/runs/348306177) * CI: Update uberjar oss key for smoketest (#13704) * Fix Cypress flakes in `dashboard/dashboard.cy.spec.js` file (#13703) * Fix flakes in `revisions screen` block * Improve test assertions (there were some rendering problems, so I adjusted the assertions) * Narrow down the quarantine for dash_drill spec (#13682) (#13706) * Fix `metrics.cy.spec.js` flakes (#13709) * Fix `metrics.cy.spec.js` flakes (#13682) * Refactor the test using API * Smoketest: run nightly at 1am PST (#13711) 1 am PST = 09:00 UTC CircleCI cron is for UTC: https://circleci.com/docs/2.0/workflows/#scheduling-a-workflow * Upgrade Cypress to v5.5.0 (#13674) * Upgrade Cypress to v5.5.0 * Needed to unset the `DISPLAY` ENV through `config.yml` to finally make this work! (Reference: https://github.com/cypress-io/cypress/issues/4034#issuecomment-486773042 ) * Improve `segments` tests with the use of API (#13718) * Unquarantine `scenarios/pulse/pulse.cy.spec.js` (#13727) * Unset `DISPLAY` ENV in smoketests CI group (#13732) * Unquarantine ee `custom_drill_through/drill_through.cy.spec.js` [ci skip] (#13734) * Unquarantine `question/nested.cy.spec.js` (#13733) Co-authored-by:
Ariya Hidayat <ariya@metabase.com> Co-authored-by:
Damon P. Cortesi <d.lifehacker@gmail.com>
-
Cam Saul authored
* Fix formatting temporal values as day of week with custom day of week (#13604) * Pretty * PR feedback * Need to update when user locale changes as well * Update Moment start of week in i18n.js instead * Make it nice * Remove some unneeded stuff
-
Robert Roland authored
* Allow the Administrators group to sync Allows the Administrators group to sync from LDAP or SAML providers. This was previously not allowed to avoid a user accidentally locking themselves out of the admin group. Fixes metabase/metabase-enterprise#445 * test that admins are properly removed Test that when a sync happens, if the user was previously in the administrators group and no longer is, they are properly removed from that group.
-
Cam Saul authored
* Split expression suggestions into separate component Fix error messages not appearing in ExpressionsWidget * Enable test * Fix suggestion popup keyboard behavior * Don't try to parse empty input (#12140) * Remove stray console.log * Revert test enabling * Prettier * Address feedback
-
Simon Belak authored
-
Nemanja Glumac authored
-
- Nov 06, 2020
-
-
dpsutton authored
* Fingerprints reduce over table-rows-sample instead of realizing all tests are failing because we test fingerprinters a lot by supplying fake results and then reducing over those results. Now we are reducing over them in the query processor and need to get a better testing strategy. I think i can stub out the query-processor to take the `:rff` and just transduce over some fake supplied results but need to verify * Hijack query-processor to use rff on fake data * Docstring and make private `table-rows-sample-query` * Fix tests to use query function rather than hijack qp also was calling empty not empty? :( * drivers check [ci drivers] * Docstring cleanup for rff and remove outdated comment * Make rff required for table-rows-sample now you must reduce over the reducible row set rather than realizing the results in memory and then working with them * empty commit for drivers [ci drivers]
-
Cam Saul authored
* Mega build script improvements * Look for project.clj to determine root directory since we delete .git on CI for speed * If .git folder is missing (i.e., in CI) fail gracefully * Don't need to generate version file to run Cypress tests, right? * Build uberjar step can cache version.properties (so the Cypress test steps don't need to generate it again) * Flush caches * Update uberjar cache key
-
- Nov 05, 2020
-
-
Simon Belak authored
* Fix SQL for custom columns referring to aggregations. Fixes #12762 * Add test & enable cypress
-
Simon Belak authored
* Rebase * Typo * Add repro for #10511 Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
- Nov 04, 2020
-
-
Robert Roland authored
Enable the OOM killer, which will allow Docker / Kubernetes / ECS to restart a container when an OOM occurs
-
Nemanja Glumac authored
* Add repro for #13626 [ci skip] Note: Once this issue is fixed, add a positive assertion to the Cypress test.
-
Paul Rosenzweig authored
* upgrade some deps to fix warnings * add back lint-yaml scrip * remove e2e/karma references
-
- Nov 03, 2020
-
-
Nemanja Glumac authored
* Add repro for #13235 [ci skip] (Cannot filter by selecting remapped display value from dropdown list)
-
- Nov 02, 2020
-
-
Nemanja Glumac authored
* Fix obsolete MBQL syntax in `localization.cy.spec.js` [ci skip] Introduced in: https://github.com/metabase/metabase/commit/6b5765718daff384a1831cd7383401369b8c1725. * Fix obsolete MBQL syntax in `dashboard.cy.spec.js` [ci skip] Introduced in: https://github.com/metabase/metabase/commit/2958b836cc73c16b74b6e6e8fd96a6dabd12f60e. * Fix obsolete MBQL syntax in `nested.cy.spec.js` [ci skip] Introduced in: https://github.com/metabase/metabase/commit/ab762e1ffb8cd79fedc050709c059e8c8b87ef9b. * Fix obsolete MBQL syntax in `dashboard-drill.cy.spec.js` [ci skip] Introduced in: https://github.com/metabase/metabase/commit/cb4371e9fcc45ec242d106c4a01c4a0d68d4c324. * Fix obsolete MBQL syntax in `nulls.cy.spec.js` Introduced in: https://github.com/metabase/metabase/commit/854f5317df724abc0a6026b06bfa539d15d34fa6. * Add positive assertion for repro for #13571
-
- Oct 30, 2020
-
-
Nemanja Glumac authored
* Add repro for #12872 (Between Dates filter behaves inconsistently based on whether the column is from a joined table or not)
-
Robert Roland authored
When a database is updated via the admin interface, any sensitive data (private keys, passwords, etc) should be handled on an "upsert" basis - only modify those fields if they were changed from the "protected password" value. This affects all database drivers. Resolves #13442
-
- Oct 29, 2020
-
-
Cam Saul authored
* Fix collections/graph stack overflow * Test fixes
[ci postgres] [ci mysql] * Show engine in Task trouble shooting logs (#13608) * Show engine in Task trouble shooting logs in an effort to get better feedback when people raise issues about long running sync processes, include the database engine in the logs. Also wrapped `th` in a `tr` inside the `thead` to remove react warning * Const intead of let on the db_id_to_engine * Swap db id for db name * Move comment out of jsx * fixup! Merge branch 'release-x.37.x' into fix-collections-graph-stack-overflow Co-authored-by:dpsutton <dan@dpsutton.com>
-