Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 21, 2022
  2. Nov 18, 2022
  3. Nov 17, 2022
  4. Nov 16, 2022
  5. Nov 15, 2022
  6. Nov 11, 2022
  7. Nov 10, 2022
  8. Nov 09, 2022
  9. Nov 05, 2022
  10. Nov 02, 2022
  11. Nov 01, 2022
  12. Oct 28, 2022
    • Nick Fitzpatrick's avatar
      Move series settings into chart settings popup (#25926) · 404006bd
      Nick Fitzpatrick authored
      
      * Initial attempt for metrics
      
      * Breakout Support
      
      * PR Cleanup
      
      * Changing how ChartSettingsPopover renders widgets
      
      * Fixing ChartSettingsPopover selected section handling
      
      * Maz Feedback
      
      * adding readonly prop to ChartSettingsWidgets
      
      * RE-adding Multiseries editing component for dashboard Viz Settings
      
      * removing readonly nonsense I added
      
      * Removing series settings for waterfall charts
      
      * Some PR Feedback
      
      * PR Cleanup
      
      * PR Feedback
      
      * more PR feedback
      
      * Fixing getColumnKey import
      
      * use rawSeries instead of series
      
      * Adjusting tests
      
      * Adjusting test
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
  13. Oct 26, 2022
  14. Oct 21, 2022
  15. Oct 20, 2022
  16. Oct 17, 2022
  17. Oct 11, 2022
    • Aleksandr Lesnenko's avatar
      Static row chart (#25829) · 23837a6f
      Aleksandr Lesnenko authored
      * support static row chart on the backend
      
      * update and add types
      
      * update types
      
      * add chart columns helper, dataset grouping
      
      * add viz settings helpers
      
      * fix text measuring
      
      * add generic row chart component for static and dynamic rendering
      
      * update deps
      
      * fix jest config for d3
      
      * allow importing cljs in static viz
      
      * add a hook for getting chart columns and series
      
      * add a static row chart
      
      * build cljs before static viz
      
      * specs
      
      * add stories, moved isomorphic row chart component to the shared folder
      
      * update import
      
      * fix backend merge
      
      * remove an extra line
      
      * one more extra line
      
      * exclude unused props from the row chart
      
      * cleanup
      
      * review
      
      * fix types
      
      * fix log scale
      
      * add visual spec, fix goal label truncate
      
      * review
      
      * fix mock path
      
      * fix specs
      Unverified
      23837a6f
  18. Oct 07, 2022
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Static gauge chart (#25651) · d4cb1e5a
      Mahatthana (Kelvin) Nomsawadi authored
      * Basic static gauge chart
      
      * Add gauge segment min max labels
      
      * Add gauge segment label
      
      * Cleanup code
      
      * Fix React list key error
      
      * Remove hard-coded colors
      
      * Make the everything calculates at the gauge center
      
      * Make gauge segment data easier to understand
      
      * Example scaling chart to avoid label overflow
      
      * Avoid long labels overflow by scaling the gauge chart down
      
      * Match gauge needle color with the design
      
      * Fix hard coded gauge segment label anchor calculation
      
      * Fix static gauge chart not rotate gauge needle correctly
      
      * Add E2E for static gauge chart
      
      * Fix `transform-origin: center` not working with BE static chart
      
      * Truncate long segment label so charts can never be too small
      
      * Fix gauge segment not connected to each other
      
      * Static chart refactor part 1
      
      * Final static gauge chart refactoring
      
      * Simplify clojure chart render function
      
      * Fix relative imports
      
      * Make overlapping gauge labels more legible
      
      * Make GaugeLabelData property orders consistent
      
      * Make a function easier to read
      
      * Make the calculation more correct
      
      though the behavior would still be the same
      
      * Separate presentational component out of the Gauge component
      
      * Remove unused tap>
      
      * Fix gauge chart not working on chart tester in internal static viz page
      
      * Fix gauge chart not rendered with Lato font
      
      * Improve internal page static chart tester option clarity
      
      * Support column settings in gauge charts
      
      * Add unit tests for static gauge chart utils
      
      * Address review
      
      * Fix unittest failure
      Unverified
      d4cb1e5a
  19. Oct 03, 2022
  20. Sep 29, 2022
  21. Sep 28, 2022
    • Nemanja Glumac's avatar
      Upgrade Cypress to `v10.9.0` (#25665) · 31546248
      Nemanja Glumac authored
      * Upgrade Cypress to `v10.9.0`
      
      * Migrate Cypress plugins to the new config
      
      * Replace deprecated `ignoreTestFiles` option
      
      * Migrate `Cypress.json` to the new config
      
      * Extend the config
      
      * Upgrade `cypress-grep` library
      Unverified
      31546248
  22. Sep 27, 2022
  23. Sep 09, 2022
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Static visualization polish fixes (#25145) · 9cd5a5f8
      Mahatthana (Kelvin) Nomsawadi authored
      * Render ordinal x-axis label 90deg instead of 45deg
      
      * Fix chart grid and x-axis size not equal when having left padding
      
      * Fix X-axis line covered by grid lines
      
      * Update static chart text size to match new designs
      
      * Handle 90deg rotated x-axis tick labels
      
      * Fix timeseries overlapping x-axis tick labels
      
      * Fix typo
      
      * Show data point circle to make reading line charts less confusing
      
      * Render data point circle only on visible data point values + fix types
      
      * Address review
      Unverified
      9cd5a5f8
  24. Aug 31, 2022
    • Anton Kulyk's avatar
      Remove `redux-logger` (#25084) · 133647b5
      Anton Kulyk authored
      * Remove `redux-logger` usage
      
      * Remove related lib file
      
      * Uninstall `redux-logger`
      Unverified
      133647b5
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Show data point values on static viz (followed-up PR) (#24938) · b8f4c6ef
      Mahatthana (Kelvin) Nomsawadi authored
      * Handle negative bar data point value
      
      * Migrate static line chart values to Values component
      
      * Migrate static bar chart values to using Values component
      
      * Migrate static area chart values to using Values component
      
      * Fix stroke rendering
      
      * Fix multiseries value collision
      
      * Fix bar + y axis collision
      
      * Fix x-axis collision
      
      * Fix collision bug
      
      * Render chart last so it's above the Y axises
      
      * Fix value stroke collide with X-axis
      
      * Tidy up <Values /> and make it more readable
      
      * Fix auto compact formatting for stacked chart
      
      * Handle overlapping value with left Y-axis
      
      * `serie` -> `series`, and `series` -> `multipleSeries`
      
      So, it's grammatically correct.
      
      * Move some types to where they should belong
      
      * Add OutlinedText for static viz
      
      This is for <Text /> that has a stroke and has `pain-order: stroke`.
      Unverified
      b8f4c6ef
  25. Aug 30, 2022
  26. Aug 29, 2022
  27. Aug 18, 2022
  28. Aug 16, 2022
  29. Aug 09, 2022
  30. Aug 08, 2022
  31. Aug 05, 2022
    • Noah Moss's avatar
      Bump shadow-cljs to 2.19.6 (#24647) · dfd93579
      Noah Moss authored
      * Bump shadow-cljs
      
      This lets us use the template tag functionality
      
      ```
      add experimental support for creating js template strings
      
      used like str but emits native JS `` template
      
        (js-template "foo" (+ 1 2) "bar")
      
      emits the literal
      
        `foo${(1 + 2)}bar`
      ```
      
      But this required a few changes on our side as well.
      
      Required for this:
      
      -- LOGGING
      
      Bumped glogi
      ```diff
         ;; new stuff
      -  [lambdaisland/glogi "1.0.106"]]
      -
      +  [com.lambdaisland/glogi "1.1.144"]]
      ```
      Annoying because it had a group name change due to Clojars policy. This
      had the same error as us below. That's why I'm hopeful that it will
      actually just work.
      
      There were some changes with the Google Closure library with things not
      included or referenceable. So I just removed these imports and the
      typehints that used them. We'll need to verify that this still works but
      both compiling for dev and release (with advanced compilation)
      work. Still possible there will be some runtime errors but i'm hopeful
      there wont be. We can grab a jar from CI and poke around
      
      ```shell
      ❯ npx shadow-cljs compile app
      shadow-cljs - config: /Users/dan/projects/work/metabase/shadow-cljs.edn
      shadow-cljs - connected to server
      [:app] Compiling ...
      [:app] Build completed. (100 files, 0 compiled, 0 warnings, 1.65s)
      
      metabase on  nm-all-options-formatting [$!+?] via :coffee: v17.30 on :cloud:
      
        metabase-query took 2s
      ❯ npx shadow-cljs release app
      shadow-cljs - config: /Users/dan/projects/work/metabase/shadow-cljs.edn
      shadow-cljs - connected to server
      [:app] Compiling ...
      [:app] Build completed. (100 files, 30 compiled, 0 warnings, 28.04s)
      ```
      
      ```diff
                   [lambdaisland.glogi.console :as glogi-console])
      -  (:require-macros metabase.shared.util.log)
      -  (:import goog.debug.Logger
      -           goog.debug.Logger.Level))
      +  (:require-macros metabase.shared.util.log))
      ```
      
      ```diff
      @@ -37,4 +35,4 @@
       (defn is-loggable?
         "Part of the impl for [[metabase.shared.util.log/js-logp]] and [[metabase.shared.util.log/js-logf]]."
         [logger-name level]
      -  (.isLoggable ^Logger (log/logger logger-name) ^Level (log/levels level)))
      +  (.isLoggable (log/logger logger-name) (log/levels level)))
      ```
      
      -- WARNINGS ABOUT shadowing `abs`
      
      -  [medley "1.3.0"]
      +  [medley "1.4.0"]
      
      Similar to what we bumped for the backend. ClojureScript 1.11.x has an
      `abs` function.
      
      * use update-keys and update-vals in cljs
      
      * bump clj-kondo in CI
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      Unverified
      dfd93579
Loading