Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 14, 2024
  2. Jun 05, 2024
  3. Jun 03, 2024
  4. May 31, 2024
  5. May 30, 2024
  6. May 29, 2024
  7. May 22, 2024
  8. May 21, 2024
  9. May 17, 2024
  10. May 16, 2024
  11. May 10, 2024
  12. May 08, 2024
  13. May 05, 2024
  14. May 01, 2024
    • Romeo Van Snick's avatar
      Combine columns (#42021) · 0dc75042
      Romeo Van Snick authored
      * [MLv2] Add `preview-expression` to eval an expression on sample data
      
      This is needed to show the previews in the UX for the combining columns
      epic #39977.
      
      Fixes #39979.
      
      * [MBQL lib] Add "Combine columns" drill-thru
      
      This is following the original plan of using a drill for this. It's hard
      to combine that with the "preview" functionality.
      
      See [thread](https://metaboat.slack.com/archives/C06P22KS4JH/p1712264174056569)
      for discussion of how we might approach that issue.
      
      Fixes #39978.
      
      * [MBQL lib] Add "Combine columns" drill-thru
      
      This is following the original plan of using a drill for this. It's hard
      to combine that with the "preview" functionality.
      
      See [thread](https://metaboat.slack.com/archives/C06P22KS4JH/p1712264174056569
      
      )
      for discussion of how we might approach that issue.
      
      Fixes #39978.
      
      * [MLv2] Add `preview-expression` to eval an expression on sample data
      
      This is needed to show the previews in the UX for the combining columns
      epic #39977.
      
      Fixes #39979.
      
      * [MLv2] Add `preview-expression` to eval an expression on sample data
      
      This is needed to show the previews in the UX for the combining columns
      epic #39977.
      
      Fixes #39979.
      
      * Revert "Merge branch 'mblib-preview-expressions' into combine-columns"
      
      This reverts commit dac17f84aaae09906a206106290f7f58dea659bd, reversing
      changes made to 2934fab19db495ca8104801d41bc8aba457e401f.
      
      * Revert "Merge branch 'mblib-preview-expressions' into combine-columns"
      
      This reverts commit 2934fab19db495ca8104801d41bc8aba457e401f, reversing
      changes made to 6a43c22e78fb616c7ac0b024811b2989a1ae0f20.
      
      * Revert "Merge branch 'mblib-preview-expressions' into combine-columns"
      
      This reverts commit 6a43c22e78fb616c7ac0b024811b2989a1ae0f20, reversing
      changes made to 2257333a8ae69f0c9a6f6fdf0c8f5d837263f97a.
      
      * [FE] "Combine columns" drill thru (#40082)
      
      * Type Section['icon'] properly, including the hack for summarize section
      
      * Add combine columns section
      
      * Add types for combine columns drill
      
      * Add combine columns drill component stub
      
      * Mock combine columns drill
      
      * Add component stub
      
      * Encapsulate typing hacks
      
      * Extract CombineColumnsDrill
      
      * Extract ColumnAndSeparatorRow
      
      * Improve naming, add button to edit separators
      
      * Translate string
      
      * Improve styling
      
      * Separator input
      
      * Handle removing columns
      
      * Rename lib.ts to utils.ts
      
      * Implement onSubmit
      
      * Add getNextColumnAndSeparator
      
      * Use form for a11y
      
      * Handle vertical overflow
      
      * Handle horizontal overflow
      
      * Extract formatSeparator
      
      * Use proper translations
      
      * Adjust min/max sizes
      
      * Fix scrollbar being unnecessarily shown
      
      * Display source column name
      
      * Avoid serializing the entire column and putting it into DOM
      
      * Use module.css extension
      
      * Format code
      
      * Improve a11y
      
      * Mock combineColumnsDrillExpression and previewExpression
      
      * Add Preview component
      
      * Move preview logic to Preview component
      
      * Style Preview
      
      * Format code
      
      * Move styles to CSS modules
      
      * Update UI to latest designs
      - move "Add another column" button
      - remove "Separated by X" button
      - always show separator inputs
      
      * Remove displayInfo mock
      
      * Add asReturned
      
      * Update CombineColumnsDrillThruInfo
      
      * Integrate new way of working with combine columns drill
      
      * Fix generating expression names
      
      * Integrate drill with click actions
      
      * Integrate new preview workflow
      
      * Revert "Update UI to latest designs"
      
      This reverts commit cda039dffe9d452c0866f63800e2e887a540fe67.
      
      * Use previewExpression interface correctly
      
      * Use new preview_expression API
      
      * Make sure columns are created with original query and stage index
      
      * Extract usePreview and handle preview errors
      
      * Update popover title
      
      * Move add column button
      
      * Fix outline being cut off
      
      * Style preview label as per design
      
      * Format empty separator
      
      * Make preview scrollable
      
      * Use project convention
      
      * Simplify ScrollArea usage
      
      * Use ScrollArea in CombineColumnsDrill
      
      * Update comment
      
      * Remove Lib.previewExpression
      
      * Clean up the preview after removing Lib.previewExpression
      
      * Implement getPreview
      
      * Change default column preview to 'text'
      
      * Remove usePreview hook which is no longer in use
      
      * Rename Preview to Example
      
      * Use different placeholder for separator input
      
      * Add whitespace placeholder
      
      * Add ColumnPicker boilerplate
      
      * Export Input
      
      * Use QueryColumnPicker for ColumnPicker
      
      * Pass width to AccordionList
      
      * Add sequences popover events with tippy
      
      * Remove unused ColumnOption helpers
      
      * Add testid to Example
      
      * Add e2e test for combine column in header
      
      * Select content of separator input on focus
      
      * Reduce padding on example
      
      * Add monospace variant to Text
      
      * Use monospace variant in Example
      
      * Use monospace font in textinput
      
      * Match faux-select label styles to our TextInput label styles
      
      * Add missing color
      
      * Remove !important
      
      * Use pre whitespace so consecutive spaces show up
      
      * Remove empty default
      
      * Add example for boolean
      
      * Remove !important
      
      * Use should.have text over contain
      
      ---------
      
      Co-authored-by: default avatarRomeo Van Snick <romeo@romeovansnick.be>
      
      * Remove duplicated code
      
      * Export useMantineTheme from metabase/ui
      
      * Use useMantineTheme instead of reading theme directly
      
      * Remove setTimeout in popover
      
      * Use plain t instead of jt
      
      * Move Popover dropdown sequence hack to metabase/ui
      
      ---------
      
      Co-authored-by: default avatarBraden Shepherdson <braden@metabase.com>
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      0dc75042
  15. Apr 29, 2024
    • Braden Shepherdson's avatar
      [MBQL lib] Add `Lib.extractionExpression` to get the expression directly (#41885) · 435d823a
      Braden Shepherdson authored
      Previously they could only be added to the query with `Lib.extract`, but
      this returns the expression the extract would add.
      Unverified
      435d823a
    • Cam Saul's avatar
      Add `Offset()` expression (BE + FE) (Part 1) (#41346) · dd0f14a5
      Cam Saul authored
      * Fix add-alias-info matching for nominal field literal refs
      
      * Minor cleanup
      
      * Minimize diff
      
      * A bit more cleanup
      
      * Cumulative aggregations w/ multiple breakouts should reset counts (#2862)
      
      * Update dox
      
      * Do the nesting FIRST before adding alias info.
      
      * Remove unused
      
      * FE for Offset()
      
      * Cleanup stray code
      
      * Prettier
      
      * Kondo
      
      * Test fixes :wrench:
      
      * Better error message when no breakout
      
      * Support offset as an expression with no breakouts. Still require an ORDER BY tho.
      
      * Fix most stuff
      
      * Hack city??????
      
      * Revert nest-query changes and disable the offset-no-breakout test for now.
      
      * Appease TypeScript
      
      * Test fix :wrench:
      
      * Oracle & MySQL test fixes
      
      * Test fixes :wrench:
      
      * Remove maxWorkers for FE unit tests
      Unverified
      dd0f14a5
  16. Apr 25, 2024
  17. Apr 23, 2024
  18. Apr 15, 2024
  19. Apr 12, 2024
    • Cam Saul's avatar
      [P1 BUG FIX] Cumulative aggregations with multiple breakouts should reset... · b93e99dc
      Cam Saul authored
      [P1 BUG FIX] Cumulative aggregations with multiple breakouts should reset counts when values of breakouts other than change (#41340)
      
      * Fix add-alias-info matching for nominal field literal refs
      
      * Minor cleanup
      
      * Minimize diff
      
      * A bit more cleanup
      
      * Cumulative aggregations w/ multiple breakouts should reset counts (#2862)
      
      * Update dox
      
      * Do the nesting FIRST before adding alias info.
      
      * Remove unused
      Unverified
      b93e99dc
  20. Apr 08, 2024
    • Cam Saul's avatar
      Use window functions for cumulative sum and cumulative count [BigQuery] (#40982) · a6291809
      Cam Saul authored
      * Use window functions for SQL drivers for cumulative count and sum
      
      * H2/Snowflake/Redshift implementation
      
      * Test fixes :wrench:
      
      * Use SELECT expression positions as the default window function implementation
      
      * Some test fixes.
      
      * Fix bugs in add-alias-info
      
      * MongoDB fixes
      
      * Another pass
      
      * BigQuery should use positions?
      
      * BigQuery almost works 100% now.
      
      * MLv2 fix conversion behavior for expressions with type info
      
      * Add transformations for nesting cumulative aggregations in expressions
      
      * Minor tweaks
      
      * MLv2 should escape aliases using driver/escape-alias (dynamically bind this)
      
      * Kondo fix
      
      * Lint fixes :wrench:
      
      * More test fixes and revert test changes
      
      * Update some tests to use correct case for nominal Field literal refs
      
      * Wow! BigQuery is fixed! Remove upgrade-field-literals middleware
      
      * Disable tests for the failing drivers, we can fix in follow-on PRs.
      
      * Enable BigQuery :window-functions
      
      * Extra info
      
      * Add GH issue numbers
      
      * Update more GH issue numbers
      
      * Fix SQL Server!!!! wooo
      
      * I THOUGHT WE WERE DISABLING SPARK SQL!!!!!!!!!!1
      
      * Cleanup to get things ready for review.
      
      * Snowflake + Vertica shouldn't use output column numbers for ORDER BY in OVER
      
      * Code cleanup
      
      * Snowflake + Vertica shouldn't use output column numbers for ORDER BY in OVER
      
      * Code cleanup
      
      * Test fixes :wrench:
      
      * Much simpler BigQuery implementation
      
      * Add GH issue context
      
      * Remove commented-out code
      
      * Remove unused add-stage-at-index
      
      * Documentation
      
      * Test fix? :wrench:
      
      * Test fix :wrench:
      Unverified
      a6291809
    • Tim Macdonald's avatar
      Remove lingering Joda Time references (#40958) · 15709fa8
      Tim Macdonald authored
      [Fixes #13922]
      Unverified
      15709fa8
  21. Apr 05, 2024
    • Cam Saul's avatar
      Use window functions for cumulative sum and cumulative count (#40752) · 9d112756
      Cam Saul authored
      * Use window functions for SQL drivers for cumulative count and sum
      
      * H2/Snowflake/Redshift implementation
      
      * Test fixes :wrench:
      
      * Use SELECT expression positions as the default window function implementation
      
      * Some test fixes.
      
      * Fix bugs in add-alias-info
      
      * MongoDB fixes
      
      * Another pass
      
      * BigQuery should use positions?
      
      * Disable tests for the failing drivers, we can fix in follow-on PRs.
      
      * Extra info
      
      * Add GH issue numbers
      
      * Update more GH issue numbers
      
      * Fix SQL Server!!!! wooo
      
      * I THOUGHT WE WERE DISABLING SPARK SQL!!!!!!!!!!1
      
      * Cleanup to get things ready for review.
      
      * Snowflake + Vertica shouldn't use output column numbers for ORDER BY in OVER
      
      * Code cleanup
      
      * Test fix? :wrench:
      Unverified
      9d112756
  22. Mar 28, 2024
  23. Mar 25, 2024
  24. Mar 22, 2024
  25. Mar 21, 2024
    • Cam Saul's avatar
      Rename `metabase.mbql` to `metabase.legacy-mbql` (#40158) · 0a15637f
      Cam Saul authored
      * Wow
      
      * Test fix :wrench:
      
      * Fixes
      
      * Actions should use strings for column names (fix :update-row and :create-row normalization)
      
      * MLv2 schema should check against keys for the other query type
      
      * Ok, have I fixed things?
      
      * More fixes :wrench:
      
      * Fix indentation
      
      * Another round of test fixes. :wrench:
      
      * Hopefully the last few test fixes :wrench:
      
      * We need to test normalization for queries that have keyword keys as well.
      
      * Fix Cljs i18n namespaces
      
      * Sort namespaces
      
      * Only test against H2
      
      * Rename `metabase.mbql` to `metabase.legacy-mbql`
      
      * Fix Kondo warnings
      
      * Test fixes :wrench:
      
      * Register MBQL clause schemas and test fixes :wrench:
      
      * Test fixes and PR feedback
      
      * Test fix
      
      * Remove the normalization tests
      
      * Test fixes :wrench:
      
      * Fix kondo
      
      * Fix import
      
      * Another fix :wrench:
      
      * Merge
      
      * FIXES
      
      * Add another missing REQUIRE
      Unverified
      0a15637f
  26. Mar 20, 2024
  27. Mar 14, 2024
  28. Mar 13, 2024
  29. Mar 11, 2024
  30. Mar 08, 2024
  31. Mar 06, 2024
  32. Feb 27, 2024
  33. Feb 22, 2024
Loading