Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Dec 22, 2022
  2. Dec 21, 2022
    • adam-james's avatar
      Fixes to static-viz datetime formatter, in particular, issues #27020 and #27105 (#27339) · 05e0cc1b
      adam-james authored
      * Handle abbreviation and date-separator in a fn, where defaults are passed in in any place where nil COULD exist
      
      Moving abbreviation and date-separator string changes into a post-processing fn allows each unit case to handle the
      date-style default formatting, and eliminates the problem of date-style being `nil` in the let statement. It was this
      scenario where `abbreviate` was `true`, but `date-style` was `nil`.
      
      In many cases, if `date-style` is nil, then so is `abbreviate` and `date-separator`, in fact, the default from the
      frontend sends nil for all of these keys. In such a case, none of the branches run and nil is safely passed
      through. It is then handled appropriately with `(or ...)` expressions in each entry for the case statement.
      
      But, it is indeed possible to have a nil `date-style` with non-nil `abbreviate` or `date-separator` keys. Now, the
      post-process-date-style function is only ever called AFTER the default date-style is set in whatever case branch is needed.
      
      * Turn frontend day format 'dddd' into backend format 'EEEE'
      
      The frontend sends a datetime format string to the backend and some elements are not equivalent to the expectations
      the java datetime formatter has.
      
      * Unskip e2e reproductions
      
      * Add a test for all 'written date' combos
      
      * These tests fail b/c I fixed the 'default' from Abbreviated to non-abbreviated
      
      * Add test 'matrix' for numerically formatted dates, and each separator
      
      * Finally, add tests to confirm that custom-formatting is applied
      Unverified
      05e0cc1b
    • Braden Shepherdson's avatar
      [metabase-lib] Port number formatting to CLJC; use it from JS (#27114) · 2537f3d0
      Braden Shepherdson authored
      This adds a cross-platform number formatting library in CLJC, which has
      (nearly) identical output in both JVM and JS environments.
      
      The only known differences are:
      - JVM Clojure has `BigDecimal` support, so isn't limited to a `double`'s
        range.
      - Exact spelling/capitalization of the full names of currencies differs.
          - JVM: "7.34 US Dollar"
          - JS: "7.34 US dollars"
      
      Some future work is required to fully land this. In particular, the
      `currency_in_header` logic should be moved to the table formatters, not
      implemented on the JS side of this change.
      Unverified
      2537f3d0
    • Nick Fitzpatrick's avatar
      Adding Subtitle to Series Name Input (#27304) · 2f44d8b0
      Nick Fitzpatrick authored
      * Adding Subtitle to Series Name Input
      
      * PR Feedback
      
      * fixing cypress test
      Unverified
      2f44d8b0
    • Ryan Laurie's avatar
      Fix Zero Filters not loading URL Parameters (#27342) · c6c98ffd
      Ryan Laurie authored
      * use null coalescing operator to allow numeric zero values
      
      * add tests
      
      * update storybook types
      Unverified
      c6c98ffd
    • Luis Paolini's avatar
    • john-metabase's avatar
      Start-of-cycle 46 basic dependency version bump (#27332) · 704a1c54
      john-metabase authored
      * Start-of-cycle 46 basic dependency version bump
      
      Some dependencies with available major version bumps are only updated
      to the latest minor version of the current major version. Some
      additional dependencies will be updated in future PRs.
      
      * Removes commons-lang from sparksql deps exceptions
      
      * Fixes MongoDB SRV test for monger 3.6.0
      
      * fixes SQLite datetime tests for new driver version 3.40
      Unverified
      704a1c54
    • Nick Fitzpatrick's avatar
    • Aleksandr Lesnenko's avatar
      bump redux (#27043) · 9147c1a9
      Aleksandr Lesnenko authored
      * check how much is broken after redux upgrade
      
      * fix popovers could not use connected components
      
      * fix a unit spec failure
      
      * fix accessing a connected component ref which is a class instance
      
      * supress typescript errors caused by better type inference of the newer react-redux
      Unverified
      9147c1a9
    • Cal Herries's avatar
      Add presto datetime-diff (#27069) · 19a9693d
      Cal Herries authored
      Unverified
      19a9693d
  3. Dec 20, 2022
  4. Dec 19, 2022
  5. Dec 16, 2022
Loading