Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 21, 2023
    • Jeff Bruemmer's avatar
      docs - update link and image (#30296) · 2b7db69e
      Jeff Bruemmer authored
      Unverified
      2b7db69e
    • adam-james's avatar
      recent_views stored in user local setting (#29631) · 2b8e282e
      adam-james authored
      * First pass at recent_views stored in user local setting
      
      This modifies the view log event handler to write a user's views to their local settings map (stored as json in the
      appdb).
      
      some notes on what causes a view
      
      :card-query
       - occurs when collection with pinned cards/models is opened. maybe shouldn't count as a view
      
      :card-read
       - happens when you view a card, like, load it in the UI and are looking at it
      
      :card-read AND :card-query
       - happens when you view a model, like, load it in the UI and are looking at it
      
      :dashboard-read
       - happens when you view a dashboard
      
      :card-create
       - when you save a card
       - this will probably cause double counts because it will save and then trigger a :card-read right away too
      
      :table-read
       - when viewing a table.
       - when selecting a db/table in dropdowns in the Question editor
      
      I think we need the view log topics to be much smaller: #{:card-read :dashboard-read :table-read}
      
      * WIP test for the recent_views user local setting.
      
      This isn't totally correct yet. I think it doesn't clean up after itself correctly. That's pending.
      
      And, I have to investigate because :table-read isn't working either. Still worth pushing this progress!
      
      * Test that works! All potential view events need :actor_id
      
      * Working test for /api/recent_views
      
      * Order of views in user-local recent-views works now
      
      If a user views something they've recently viewed, the homepage order doesn't change. Now it will, as in, the most
      recently viewed item will always be the first item in the vector.
      
      * One time recent_views expensive query done in the user-recent-views getter
      
      The logic of filling the recent-views setting was first written in the activity api namespace. Now it's handled where
      the setting is defined, which lets anyone else consuming the setting not worry about filling it if its empty.
      
      The setting can be reset with `nil` which will cause the query to run again. Otherwise, if the list of recent items is
      an empty vector, that is considered valid and will not re-run the query.
      
      Updating the setting per view is handled still in the view log handler, implemented in the private function `update-users-recent-views!`.
      
      * Add `most-recently-viewed-dashboard` setting
      
      The most recently viewed dashboard for that user, in the past 24 hours.
      
      This is not meant to be a permanent solution to providing this bit of info for the user, rather, it's a 'stop gap'
      while the audit tables are reworked.
      
      * Add test for most recent dashboard setting
      
      * Pass :context to the view log fns
      
      This lets us filter out views triggered by pinned cards.
      
      * Fix tests failing after adding :context to view metadata
      
      * See if card-query can help us filter out pinned item views
      
      * Tests should send :card-query events
      
      * Since we use :card-query, we have to filter out dashboard context too
      
      This should prevent views being recorded if someone just opens a dashboard.
      
      * ViewLog Cleanup to see if it'll let other tests pass
      Unverified
      2b8e282e
    • Aleksandr Lesnenko's avatar
      Keep only visualization Percy specs (#30245) · 72ac5858
      Aleksandr Lesnenko authored
      * drop non-viz percy tests, add a workflow that assigns visual label which triggers percy tests runs
      
      * remove push trigger in require-percy-test workflow
      Unverified
      72ac5858
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Hide multiple values option when connect dashboard filter with question with template tags (#30270) · 255412e1
      Mahatthana (Kelvin) Nomsawadi authored
      * fix typo
      
      * driveby type improvement
      
      * Fix not showing single or multiple values options
      
      When a parameter is connected to a question with template tags
      
      * Review: unit tests instead
      Unverified
      255412e1
    • john-metabase's avatar
      Fix inlined number params in native queries (#30265) · aa00c3d1
      john-metabase authored
      * Fixes inlining of numeric params in native queries
      * Updates namespaces to use sql.qp/with-driver-honey-sql-version
      Unverified
      aa00c3d1
    • Mark Bastian's avatar
      Using LLM for Model Inference (#30267) · 79fc83ae
      Mark Bastian authored
      Inferencing for models was switched from an LLM to an embedding selector. Unfortunately, this did not do a very good job as too much context was not retained. This change goes back to using the LLM for model inferencing.
      Unverified
      79fc83ae
    • Jeff Bruemmer's avatar
      fix anchor link (#30276) · a46ebad4
      Jeff Bruemmer authored
      Unverified
      a46ebad4
    • Anton Kulyk's avatar
    • Anton Kulyk's avatar
      Unverified
      17cacc2a
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Milestone 1 of [Epic] Prevent auto-apply filters in slow dashboards (#30232) · c9d14f63
      Mahatthana (Kelvin) Nomsawadi authored
      
      * Backend for allow disabling auto-apply filters in slow dashboards (#30069)
      
      * Dumb BE change before proper BE code is implemented
      
      * Add some backend tests for auto_apply_filters
      
      - included in revisions
      - included in serdes
      
      fixup some tests that didn't expect it
      
      * Fix BE for public dashboards
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      
      * Prevent auto apply filters on slow dashboards (#29569)
      
      * Able to toggle auto-apply dashboard filters
      
      Make FormField be able to show title with new style
      
      * Only apply filters when clicking apply button
      
      * Add E2E test
      
      * Fix dashboard double fetch cards onload with parameters query
      
      * Remove puzzle driven development comments
      
      * Move logic from HoC to redux 1/x
      
      * Make apply filter button works on embeddings
      
      * Fix x-ray dashboard parameters not working
      
      * Fix unit tests
      
      * Add E2E tests to public dashboard sharing
      
      * Add signed embedding E2E tests
      
      * Fix the apply button transition not working when clicked
      
      Since there's another CSS applied when the button is hovered.
      
      * Reviews: Fix x-ray dashboard actions
      
      Remove the need of 3-states boolean in `setParameterValue` action for
      x-ray dashboards. This fixes so that BE sends x-ray dashboards with
      `auto_apply_filters: true`.
      
      * Review: remove duplicate `aria-label`
      
      * Review: standadize `draftParameterValues` default values
      
      * Review: Fix `aria-label` to not change when filter values change
      
      * Review: avoid passing `ReactNode` as a prop
      
      Also fix transition not working and apply button shift when adding a
      filter.
      
      * Move selectors and actions to their own file
      
      * Review: Don't animate (un)mount of FilterApplyButton
      
      * Address: Clean up eslint ignore on tests
      
      * Review: Only test 1 scenario in E2E
      
      Since testing other scenarios are unnecessary since they're repeat the
      same thing
      
      * Review: Use E2E helper to clean up test
      
      * Review: Reuse selector
      
      * Review: Use e2e helpers to clean up the test
      
      * Fix typo
      
      * Ensure Apply button won't appear unnecessarily (#30255)
      
      ---------
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      Unverified
      c9d14f63
    • Denis Berezin's avatar
      Add a story with all icons (#30274) · 45f3c53d
      Denis Berezin authored
      Unverified
      45f3c53d
    • Nemanja Glumac's avatar
      Start using GitHub issue forms for bug reports (#30250) · 614d342e
      Nemanja Glumac authored
      * Add GitHub issues config
      
      This removes the need for a separate "Questions and help" issue template!
      
      * Convert "Bug report" into a form
      Unverified
      614d342e
  2. Apr 20, 2023
  3. Apr 19, 2023
  4. Apr 18, 2023
Loading