Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 18, 2017
  2. Jul 17, 2017
  3. Jul 14, 2017
  4. Jul 13, 2017
  5. Jul 12, 2017
  6. Jul 11, 2017
  7. Jul 07, 2017
  8. Jul 06, 2017
    • Ryan Senior's avatar
      Remapping admin fixes for the backend · 3512a730
      Ryan Senior authored
      Added a route for deleting dimensions, and added field_id to the field
      values response.
      3512a730
    • Ryan Senior's avatar
      Explicitly load driver code and fail tests when driver is present · fd99b1af
      Ryan Senior authored
      Driver loading previously was very dependent on what code clojure
      compiled first. If the Oracle driver was loaded before the plugin
      directory was examined, it would result in the Oracle driver never
      being loaded. This is due to clojure code only being loaded once when
      required and the driver loading code being free floating code that is
      only evaled when the namespace is loaded.
      
      This commit switches that code to be in an -init-driver function that
      is invoked when the driver is required. This ensures that regardless
      of code loading order, the driver will be available if it's present.
      
      This commit also includes code to fail the build if requested to test
      on an engine when that engine's driver is not available. Previously if
      you set ENGINES to "h2,oracle" but had no Oracle driver in the plugins
      directory, the test would succeed, but only test against H2.
      fd99b1af
    • Ryan Senior's avatar
      Unify test application db environment variables [ci drivers] · 72da0717
      Ryan Senior authored
      This unifies the code and the environment variables for specifying
      test database connection parameters across all supported
      databases. Existing databases that supported environment variables for
      tests have been refactored to use the new environment variable
      names. All of the connection environment variables are named similar
      to:
      
      MB_<DBNAME>_TEST_<PARAM>
      
      For user on MySQL, the variable would be named:
      
      MB_MYSQL_TEST_USER
      72da0717
  9. Jul 05, 2017
  10. Jun 27, 2017
  11. Jun 26, 2017
  12. Jun 23, 2017
    • Ryan Senior's avatar
      Druid fixes for remappings [ci drivers] · 4fb95b70
      Ryan Senior authored
      Tests were failing when attempting to reconcile expected columns with
      the actual columns returned. This commit adds code to create a list of
      expected columns as the druid query is built.
      4fb95b70
    • Ryan Senior's avatar
      Fixed up remapping issues on MongoDB · da7e09f5
      Ryan Senior authored
      Specifically added code that matches projections from mongo with the
      expected order of results coming back from the database. Also added
      code to ensure order by columns are compared correctly after the split
      of expand and resolve into two separate middlewares.
      da7e09f5
    • Ryan Senior's avatar
      Added admin routes for dimensions and human readable values · 8543e1c5
      Ryan Senior authored
      This commit adds support for adding dimensions to existing
      fields. Values and human readable values (optional) can also be
      added/updated.
      8543e1c5
    • Ryan Senior's avatar
      Added realiasing code for Oracle column remapping · 138db292
      Ryan Senior authored
      This commit fixes an issue with Oracle when using remapping, with a
      column name that is ambiguous and a limit. Those queries are wrapped
      in another query, which will fail in Oracle due to the ambiguous
      column name. Columns will not be re-aliased if they collide in Oracle
      to prevent this issue. Most of this code was written by
      @camsaul (Thanks Cam!).
      138db292
    • Ryan Senior's avatar
      java.jdbc column renames should update metadata · f82b189a
      Ryan Senior authored
      Previously when java.jdbc renamed a project column (i.e. NAME to
      NAME_2) to disambiguate them, we would discard previous information on
      that NAME column and reconstruct it based on the data that comes back
      from the query. This changes that behavior to update the existing
      column data to the new name. When we do not have metadata on that
      column it will use the existing behavior to infer that.
      
      This commit also adds some tests for remapping which uncovered this
      bug.
      f82b189a
    • Ryan Senior's avatar
      Add internal remapping support to breakouts · a90e151e
      Ryan Senior authored
      a90e151e
    • Ryan Senior's avatar
      dcf76b11
    • Ryan Senior's avatar
      a881fca4
    • Ryan Senior's avatar
      Add dimensions/human_readable_values to the query_metadata response · db4f3222
      Ryan Senior authored
      This moves values to be nested under the related fields object, and
      includes dimension along with human_readable_values in the field as
      well.
      db4f3222
    • Ryan Senior's avatar
      Refactor field test values to reduce duplication · fe4fe346
      Ryan Senior authored
      This commit just defs a map with a default map of key/values for
      fields/placeholders/columns and merges that with a map of what's
      different for that test.
      
      Fixes up eastwood warnings, add docstrings to public functions
      fe4fe346
    • Ryan Senior's avatar
      Add FK related remapping · 029130cb
      Ryan Senior authored
      This commit adds logic around an FK remapping found in the
      dimensions table. It will follow a foreign key to the related
      table and use the indicated column from that table as the remapped
      value for the source column.
      
      This commit also switches the "remapped_from" and "remapped_to"
      attributes returned in the query response to use the "name" of the
      remapped column as there could be ambiguity with the previously used
      display name.
      029130cb
Loading