Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 27, 2021
  2. Jul 26, 2021
  3. Jul 23, 2021
    • Dalton's avatar
      add question details sidebar (#16803) · bc90e069
      Dalton authored
      
      * add question details sidebar (code from bucm)
      
      update some cy tests
      
      rmv moderation-related code
      
      rmv padding on description
      
      merge history button logic into label
      
      lint fix
      
      update some clicks in cy tests
      
      update styles to use styled-components
      
      fix more cy tests
      
      rmv unused component
      
      rmv unused reference
      
      rmv unused prop
      
      remove styling code that is no longer necessary
      
      rmv extraneous space
      
      fix translation
      
      rmv added util class
      
      move styled component to own file
      
      * add revision util tests
      
      * rmv some unneeded question panel styling
      
      * move files into query_builder directory
      
      * rearrange stuff in file
      
      * ClampedDescription unit test
      
      * add QuestionActionButtons unit tests
      
      * add SavedQuestionHeaderButton test
      
      * add QuestionActivityTimeline tests
      
      * tweak/improve props/propTypes
      
      * fix cy test referencing question description
      
      * fix revision history cy test
      
      * Question sidebar visual polish (#16942)
      
      * style tweaks
      
      * restyle Revert button
      
      * add a little breadcrumb spacing
      
      * make LastEditInfoLabel use Badge instead of TextButton
      
      * bring back TextButton
      
      * Revision History => History
      
      * fix activity timeline unit test
      
      * rmv unused styled components
      
      Co-authored-by: default avatarDalton Johnson <daltojohnso@users.noreply.github.com>
      
      * hide 'add a description' button when read only
      
      * update permissions cy tests
      
      * update ClampedDescription unit test
      
      * use size enum instead of boolean
      
      * move export to bottom of file
      
      * move modal magic strings to a constants file
      
      * clobber all qb state when reloading
      
      * Fix reversion cy tests
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      Unverified
      bc90e069
    • Jeff Evans's avatar
      Implement JDBC based Presto driver (#16194) · 80b46b1f
      Jeff Evans authored
      Implement JDBC based Presto driver
      
      Adding new Presto JDBC driver using the PrestoDB JDBC driver from `https://github.com/prestodb/presto`
      
      Marking the old Presto driver as being `superseded-by` the new one
      
      Pulling out common Presto code into new presto-common driver (modeled after the relationship between, ex: `googleanalytics` and `google)`
      
      Putting common QP/HoneySQL logic into the new (abstract) :presto-common driver
      
      Updating :presto driver to extend from the new common driver and only adding HTTP/REST API related methods
      
      Adding implementation of Presto JDBC driver, named :presto-jdbc, extending from :presto-common and :sql-jdbc
      
      Using com.facebook.presto/presto-jdbc as underlying JDBC driver dependency (since this is explicitly for Presto clusters, as opposed to Trino)
      
      Adapting code from the existing Presto driver where appropriate
      
      Adding new dependency-satisfied? implementation for :env-var, to allow for a plugin to require an env var be set, and making the Presto JDBC driver depend on that (specifically: `mb-enable-presto-jdbc-driver`)
      
      Adding CircleCI configuration to run against the newer Presto (0.254) Docker image
      
      Adding explicit ordering in a few tests where it was missing
      
      Fixing presto-type->base-type (timestamps were being synced as :type/Time because the regex pattern was wrong)
      
      Add tx/format-name test implementation for :presto-jdbc to lowercase table name
      
      Make modified test Oracle friendly
      
      Fixing bug parsing the `[:zone :time]` case within `metabase.util.date-2.parse/parse-with-formatter`; the offset is nil so it can't be passed directly in this case, so use the `standard-offset` fn (which was moved from `date-2` to `common` to get a standard offset for that zone
      
      Fixing more test failures by adding explicit ordering
      
      Changing sync to check whether the driver supports foreign keys before attempting to sync those (since drivers might throw an exception if attempting to check)
      
      Moving some common test dataset functionality between :presto and :presto-jdbc to a new test.data ns for :presto-common
      
      Adding HoneySQL form for :count-where, since we have to explicitly give a higher precision Decimal in order for Presto to not reduce the precision in results
      
      Put limit within subquery for `expression-using-aggregation-test` (since ordering from subquery is not guaranteed in Presto)
      
      Adding impls for ->prepared-substitution to handle substitutions for native query params
      
      Adding HoneySQL impls for `mod` (to do as "mod(x,y)" and `timestamp` (since it's a function with no parens to invoke) functions
      
      Adding various `sql.qp/date` impls that use the `AT TIME ZONE` operator to account for report tz, and make bucketing tests happy
      Unverified
      80b46b1f
    • Nemanja Glumac's avatar
    • Nemanja Glumac's avatar
    • Nemanja Glumac's avatar
      [Dashboard filters coverage] Add initial set of tests for dashboard number filters (#17188) · 7748d094
      Nemanja Glumac authored
      * Add initial set of tests for dashboard number filters
      
      * Fix `describe` title for date fitlers
      Unverified
      7748d094
    • Nemanja Glumac's avatar
    • Jeff Evans's avatar
      Add support for driver deprecation (#17028) · 3ddcb263
      Jeff Evans authored
      
      # Backend changes
      
      Introducing new `superseded-by` property to plugin manifest YAML, which will indicate the driver that is to eventually replace this one (and will drive UI/UX behavior).  If a driver declares this property, then it's considered to be deprecated in favor of the specified one.
      
      Adding top level `test_modules` directory (with the same structure as modules) for the sole purpose of module/plugin testing of YAML files, which will not be included with the driver build
      
      Updating `driver-plugin-manifest` to look for the new `test_modules` directory in addition to `modules`, when loading the driver manifest
      
      # Frontend changes
      
      Calculate `supersededBy` and supersedes maps from the "superseded-by" property for each engine
      
      Change the options for the engine field to use a function to dynamically show the legacy driver if allowed by rules (either the new driver is selected, or the legacy driver was already selected for an existing DB, or the driver is not superseded by anything)
      
      Add new `DriverWarning` component to show these warnings based on supersede status
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      3ddcb263
    • Nemanja Glumac's avatar
    • Gustavo Saiani's avatar
    • Gustavo Saiani's avatar
    • Nemanja Glumac's avatar
      Upgrade `xlsx` library (#17181) · a8d1e946
      Nemanja Glumac authored
      Unverified
      a8d1e946
  4. Jul 22, 2021
  5. Jul 21, 2021
  6. Jul 20, 2021
Loading