This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 20, 2023
-
-
metamben authored
-
Nick Fitzpatrick authored
-
Denis Berezin authored
-
Alexander Solovyov authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Nov 19, 2023
-
-
Ngoc Khuat authored
-
- Nov 17, 2023
-
-
Noah Moss authored
-
bryan authored
* audit-log only when hosted or has-feature: audit * lint fix * check for the right feature name, and test better * fix metabase.api.setting-test * fix a bunch of tests * fix a couple more tests * bit of cleanup * lint fixes * fix testing function * fix whitespace * linter fix * fix so many tests * fix the rest of the tests, IIUC * fix the last test * lint fix * remove outdated tests (from the merge conflict) * disable-other-sso-types needs to _reset_ premium features. - patches in the audit-app feature by default. * Just need to re-add :audit-app as a premium feature * try improving disable-other-sso-types
-
Jeff Bruemmer authored
-
Braden Shepherdson authored
Expressions which just wrap a real Field get `:id`, `:table_id` etc. so they match a `[:field {} 7]` ref. If that real field exists (table default or joined), prefer that over the expressions.
-
Jerry Huang authored
-
Uladzimir Havenchyk authored
-
metamben authored
-
Mark Bastian authored
Fixes #33499 We added a bunch of OTEL spans to figure out what was going on with super long page loads. Turns out it was a slow pprint of massive objects. This PR removes a few spans, but not all. The ones removed are either redundant or almost certainly not needed (I did remove the one around the offending code, but the negative space that would show if it happened again would reveal the issue -- LMK if we think we should put that one back). One important thing to consider when reviewing this PR is if we like the current coverage level around the `metabase.events` code (plus a couple extra things that were instrumented). It feels right, but if it seems too onerous we could remove some. As an observation, it _might_ make sense to add instrumentation to the high level functions in toucan2 itself, such as hydrate, select, etc. This would give us transparent instrumentation on the library and we could easily view traces to see the bounds of our db hot spots.
-
Denis Berezin authored
-
Jacob Joseph authored
-
Jeff Bruemmer authored
-
Roman Abdulmanov authored
-
Cal Herries authored
-
Alexander Solovyov authored
resolves #35880
-
Denis Berezin authored
-
Nemanja Glumac authored
* Fix "slugify collection url" flake * Remove the `@flaky` tag
-
Uladzimir Havenchyk authored
-
Nicolò Pretto authored
* try to restore the original position even when another card stole it * avoid calling fetchCardData in undoRemoveCardFromDashboard for virtual dashcards * test: e2e test for undo movement and card removal * test to make the ci pass * empty commit * restore old scrollbehaviour * refactored the magic number in a function so that also docs are in a single place
-
Nemanja Glumac authored
* Fix recent-views flake(s) * Remove the `@flaky` tag
-
Nemanja Glumac authored
* Visit model query directly * Use helper to save model metadata changes * Limit the number of results even more * Improve assertions * Increase the viewport width in order to see all columns
-
- Nov 16, 2023
-
-
Cam Saul authored
-
Cam Saul authored
-
Mark Bastian authored
Spans on stats for massive models are very long, on the order of 4s. The bad span seems to encompass a small amount of logging and assertion logic, including a with-out-str pprint, which I've found to be notoriously slow for large objects. This PR slims down the logged object. If this is the culprit we should see a substantial performance improvement.
-
Mark Bastian authored
* Adding more spans to understand stats `publish-event!` https://stats.metabase.com/dashboard/2117 still takes 4s to load and the current spans don't seem to provide fine granularity around the hot spot, but it seems to be happening in the early stages of `publish-event!`. These extra spans provide finer granularity. * Adding what is probably a non-needed span, but we want to over-instrument this, if anything. Once we id the hotspot we can remove what we want. * add more spans * remove :object from new spans --------- Co-authored-by:
Noah Moss <noahbmoss@gmail.com>
-
Nemanja Glumac authored
* [E2E] Fix dashboard card resize flake * Remove the `@flaky` tag * Add test to the slow group
-
Case Nelson authored
* [MLv2] Put duplicate implicit join columns in separate column-groups * Add tests for cards without id fields in metadata * Fix linter * Fix test
-
Anton Kulyk authored
* Add Mantine `Modal` * Add guidelines link * Fix heading in storybook
-
Nemanja Glumac authored
-
Ryan Laurie authored
-
Uladzimir Havenchyk authored
-
Nicolò Pretto authored
-
Oisin Coveney authored
* Auto apply dashboard filters with the same field (#35280) * Add explanatory toast and `Undo` when auto-applying filters (#35461) * Add data test ID to dashboard sidebar * Auto apply filters to added cards * Discard changes to frontend/src/metabase/parameters/utils/dashboards.ts * Discard changes to frontend/src/metabase/dashboard/components/Sidebar.jsx * Make sure that util functions work * Attempt to split code to where it belongs * Remove useless function * Remove useless function * Discard changes to frontend/src/metabase/dashboard/utils.ts * Change names to match nomenclature * Move more files around * More fixes to types * Move to helpers * Solve some of the top levels * Attempt to fix types * Attempt to make types work without exploding * Add undo elements for mapping existing parameters and adding a new card with a parameter * Add undo toast to tests * First attempt at setting up undos and disabling behavior for cards that have had their auto-wiring undone * Add undo toasts and post-undo toast * More changes * Discard changes to frontend/src/metabase-lib/parameters/utils/targets.ts * Discard changes to frontend/src/metabase-types/api/card.ts * Split into files * Split files * Discard changes to e2e/test/scenarios/permissions/admin-permissions.cy.spec.js * Fix typescript errors * Make unit tests work * Remove toasty states * Add type for more complex parameter * Fix type errors * Remove disabled cards logic * Fix e2e tests * Add e2e tests to make sure everything works * Update e2e/test/scenarios/dashboard-filters/parameters.cy.spec.js Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Use helpers in tests and refactor to keep dashcardAttributes in dashboard code * fix undo timeout leak by clearing timeouts when undo is dismissed * e2e: add e2e for timeout edge case * test: add unit test for undo * fix typo --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Nicolò Pretto <info@npretto.com> * remove e2e test with cy.wait (#35850) * removes a test that uses a cy.wait * Revert "removes a test that uses a cy.wait" This reverts commit 52d51140bbd3bc053fc7272d42a53feaa9c1c1bb. * use cy.clock and cy.tick instead of cy.wait --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Noah Moss authored
-
Alexander Solovyov authored
when linkType is "url", serialization broke since there is no corresponding model Resolves #35855
-