Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 25, 2022
    • Case Nelson's avatar
      [Actions] Add emitter and action tests (#24199) · e6aded3d
      Case Nelson authored
      * wip
      
      * Update kondo hook for with-temp*
      
      `with-temp*` allows for unpaired bindings if you just want the default
      model. This would break the `let` that the hook was binding if you had
      an unpaired temp model followed by others.
      
      * Adding tests for emitters and actions
      
      Test hydration of :emitters
      
      Test hydration of :action
      
      Test http emitter execution
      
      Test emitter crud
      
      Test failure cases around emitter execution
      
      Small consistency changes made to non-test code that shouldn't affect happy path FE code, largely 404 checking and keyword/string consistency.
      
      * Fix unused requires
      
      * Fix macro resolution
      Unverified
      e6aded3d
  2. Feb 01, 2022
    • dpsutton's avatar
      Unused bindings part1 (#19995) · dd300077
      dpsutton authored
      * Unused bindings cleanup
      
      `clj-kondo --lint src:shared/src > lint` and then just work my way
      through it. Note that there are warnings about deprecations that we will
      need to get rid of as well. Most likely by turning off that warning
      until we are ready to tackle the project.
      
      * More unused and a sort ns
      
      * Removing unused svg helpers that eastwood is complaining about
      
      * Restore accidentally deleted `begin!` impl for xlsx
      
      * clean ns
      
      * clean ns
      
      * Last few unused bindings
      
      * kondo checks for empty docstrings
      
      * Little more cleanup
      Unverified
      dd300077
  3. Aug 04, 2021
  4. Mar 16, 2021
    • dpsutton's avatar
      Add lsp (#15181) · 3edc7d0b
      dpsutton authored
      * Add lsp and config
      
      ```emacs-lisp
        (use-package lsp-mode
          :ensure t
          :hook ((clojure-mode . lsp)
                 (clojurec-mode . lsp)
                 (clojurescript-mode . lsp))
          :config
          (setq lsp-enable-indentation nil)
          (setq lsp-enable-file-watchers nil) ;; annoying and i can't specify paths
          ;; add paths to your local installation of project mgmt tools, like lein
          (dolist (m '(clojure-mode
                       clojurec-mode
                       clojurescript-mode
                       clojurex-mode))
             (add-to-list 'lsp-language-id-configuration `(,m . "clojure"))))
      ```
      
      * Add socket repl support to project.clj (also include reveal)
      
      * Configure lsp so that enterprise is on the classpath
      Unverified
      3edc7d0b
Loading