This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 22, 2023
-
-
shaun authored
disable submit button if form is unchanged, and fix spacing
-
Uladzimir Havenchyk authored
-
John Swanson authored
When loading from a backup, we should not fail if the previous version saved keys that are no longer needed in the current version. This adds a step (after ingestion but before loading) that removes any "extra" keys from the ingested entity. How? - make `load-xform-basics` remove extraneous keys from the ingested model. - by default, it identifies the "extraneous keys" as keys *other than* keys corresponding to column names in the database. - for *some* ingested models, there is not a 1:1 correlation between an ingested model and a `:metabase/model`. For example, when we ingest an `"Action"`, that corresponds to the `:model/Action` model. But that model has three "submodels" - `:model/QueryAction`, `:model/HttpAction`, and `:model/ImplicitAction` - and when we load the ingested map into the database, `action/insert!` will insert subsets of the map it receives into _two_ tables (`action` plus one of the submodel tables). - to handle this case, `serdes/ingested-model-columns` is a multimethod, which we can override. For example, for `"Action", we override it to include the full set of columns that exist in any of the model/submodel tables. Co-authored-by:
bryan <343288+escherize@users.noreply.github.com>
-
Braden Shepherdson authored
If this drill is targeting an aggregation column, the query needs an extra stage added. To enable the custom filtering UI, this (possibly updated) query, stage number, and the correct column *in that new stage* are returned as part of the opaque `column-filter` drill. `lib.js/column-filter-drill-details` is added to hand those details to the FE as a JS object containing opaque CLJS values.
-
Nemanja Glumac authored
* Unskip previously quarantined test * Fix lint errors in subscriptions test * Fix lint errors in the alert test
-
Oleg Gromov authored
-
Alexander Solovyov authored
resolves #30133 and #30134
-
Alexander Solovyov authored
extracting was fixed in 0f1c1943, also resolves #35880
-
Kamil Mielnik authored
-
Nemanja Glumac authored
* Re-enable custom mapping null values test * Remove misleading comment * Address review comments
-
Ryan Laurie authored
-
Nemanja Glumac authored
-
- Nov 21, 2023
-
-
metamben authored
-
Nemanja Glumac authored
* Revert "Improve external filter checks (#35740)" This reverts commit 8ef7eb59. * Revert "Make Chromatic workflow 3rd party friendly (#35708)" This reverts commit 931029e0. * Revert "Make E2E workflow 3rd party friendly (#35643)" This reverts commit b547eb7e. * Revert "PoC External workflow run trigger (#34951)" This reverts commit df16fc89.
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Fix E2E dashboard cards "default sizes" flake * Increase the request timeout and remove the `@flaky` tag * Add test to the "slow" E2E group
-
Ngoc Khuat authored
* Revert "When attemp to delete inactive tables, skip tables that have active cards (#35693)" This reverts commit 2586ef0d. * Revert "Daily task to delete old inactive tables (#35443)" This reverts commit cd975913.
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix static/public embed crashes when query returns error * Add E2E test to reproduce the issue * Sort the key more consistently
-
- Nov 20, 2023
-
-
Ngoc Khuat authored
-
Aleksandr Lesnenko authored
* fix TableSimple styles * tweak sorting icon opacity * Update TableSimple.styled.tsx
-
Jerry Huang authored
-
shaun authored
-
Cam Saul authored
-
Alexander Polyankin authored
Revert "Revert "Rollback mbqlv2 drills - sort, fk-filter, summarize-column-by-time (#35917)" (#35926)" (#35951)
-
dpsutton authored
* Revert "Clarify stacktraces from malli validation errors (#34712)" This reverts commit 1a0f2d65. * Alternative fix for mu/defn correctness issue https://github.com/metabase/metabase/pull/34712 introduced a correctness bug: ```clojure (macroexpand '(metabase.util.malli/defn foo [x :- string?] :foo)) (def foo "Inputs: [x :- string?]\n Return: :any" (clojure.core/fn ([a] (metabase.util.malli.fn/validate-input {:fn-name 'user/foo} string? a) ((clojure.core/fn [x] :foo) a)))) ``` The simplest demo of the bug is ```clojure user=> (metabase.util.malli/defn foo [x] a) #'user/foo ``` The macro used simple and predictable args for it's emitted functions. This was not a problem with the original shape: (different macroexpansions of `(mu/defn foo [x :- int?] (inc x))`): prior to 34712: ```clojure (def foo "Inputs: [x :- int?]\n Return: :any" (clojure.core/let [&f (clojure.core/fn [x] (inc x))] (clojure.core/fn ([a] ;; simple argument name not a problem (metabase.util.malli.fn/validate-input {:fn-name (quote metabase.util.malli.fn-test/foo)} int? a) (&f a))))) ``` after 34712: ```clojure (def foo "Inputs: [x :- int?]\n Return: :any" (clojure.core/fn ([a] ;; simple argument name is now a problem (metabase.util.malli.fn/validate-input {:fn-name 'user/foo} int? a) ((clojure.core/fn [x] (inc x)) a)))) ``` after this PR: ```clojure (def foo "Inputs: [x :- int?]\n Return: :any" (clojure.core/let [&f (clojure.core/fn [x] (inc x))] (clojure.core/fn ([a] ;; again simple argument name is not a problem (try (metabase.util.malli.fn/validate-input {:fn-name (quote metabase.util.malli.fn-test/foo)} int? a) (&f a) (catch java.lang.Exception error (throw (metabase.util.malli.fn/fixup-stacktrace error)))))))) ``` And the fix here is just to remove the StackTraceElements which reference `validate`, `validate-input`, or `validate-output`. * fix tests tests are run in the user namespace similar to ```clojure user=> (clojure.test/run-tests 'metabase.util.malli.fn-test) Testing metabase.util.malli.fn-test Ran 8 tests containing 43 assertions. 0 failures, 0 errors. {:test 8, :pass 43, :fail 0, :error 0, :type :summary} ``` But we still want the namespace of _this_ file m.u.m.fn-test
-
Nemanja Glumac authored
-
-
Oleg Gromov authored
-
metamben authored
-
Nick Fitzpatrick authored
-
Denis Berezin authored
-
Alexander Solovyov authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Nov 19, 2023
-
-
Ngoc Khuat authored
-
- Nov 17, 2023
-
-
Noah Moss authored
-
bryan authored
* audit-log only when hosted or has-feature: audit * lint fix * check for the right feature name, and test better * fix metabase.api.setting-test * fix a bunch of tests * fix a couple more tests * bit of cleanup * lint fixes * fix testing function * fix whitespace * linter fix * fix so many tests * fix the rest of the tests, IIUC * fix the last test * lint fix * remove outdated tests (from the merge conflict) * disable-other-sso-types needs to _reset_ premium features. - patches in the audit-app feature by default. * Just need to re-add :audit-app as a premium feature * try improving disable-other-sso-types
-
Jeff Bruemmer authored
-
Braden Shepherdson authored
Expressions which just wrap a real Field get `:id`, `:table_id` etc. so they match a `[:field {} 7]` ref. If that real field exists (table default or joined), prefer that over the expressions.
-