Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 07, 2023
  2. Jun 06, 2023
  3. Jun 02, 2023
  4. Jun 01, 2023
  5. May 31, 2023
  6. May 30, 2023
  7. May 29, 2023
  8. May 28, 2023
  9. May 26, 2023
  10. May 24, 2023
    • metabase-bot[bot]'s avatar
      8fa982cd
    • metabase-bot[bot]'s avatar
    • metabase-bot[bot]'s avatar
      Embedded link cards (#30917) (#30985) · ac70e3c7
      metabase-bot[bot] authored
      
      * open metabase links in same iFrame when embedding
      
      * unit test link behavior
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      ac70e3c7
    • Noah Moss's avatar
      Backport recent_views in user-local settings (#29631) to 46 release branch (#30965) · b40e1a35
      Noah Moss authored
      
      * recent_views stored in user local setting (#29631)
      
      * First pass at recent_views stored in user local setting
      
      This modifies the view log event handler to write a user's views to their local settings map (stored as json in the
      appdb).
      
      some notes on what causes a view
      
      :card-query
       - occurs when collection with pinned cards/models is opened. maybe shouldn't count as a view
      
      :card-read
       - happens when you view a card, like, load it in the UI and are looking at it
      
      :card-read AND :card-query
       - happens when you view a model, like, load it in the UI and are looking at it
      
      :dashboard-read
       - happens when you view a dashboard
      
      :card-create
       - when you save a card
       - this will probably cause double counts because it will save and then trigger a :card-read right away too
      
      :table-read
       - when viewing a table.
       - when selecting a db/table in dropdowns in the Question editor
      
      I think we need the view log topics to be much smaller: #{:card-read :dashboard-read :table-read}
      
      * WIP test for the recent_views user local setting.
      
      This isn't totally correct yet. I think it doesn't clean up after itself correctly. That's pending.
      
      And, I have to investigate because :table-read isn't working either. Still worth pushing this progress!
      
      * Test that works! All potential view events need :actor_id
      
      * Working test for /api/recent_views
      
      * Order of views in user-local recent-views works now
      
      If a user views something they've recently viewed, the homepage order doesn't change. Now it will, as in, the most
      recently viewed item will always be the first item in the vector.
      
      * One time recent_views expensive query done in the user-recent-views getter
      
      The logic of filling the recent-views setting was first written in the activity api namespace. Now it's handled where
      the setting is defined, which lets anyone else consuming the setting not worry about filling it if its empty.
      
      The setting can be reset with `nil` which will cause the query to run again. Otherwise, if the list of recent items is
      an empty vector, that is considered valid and will not re-run the query.
      
      Updating the setting per view is handled still in the view log handler, implemented in the private function `update-users-recent-views!`.
      
      * Add `most-recently-viewed-dashboard` setting
      
      The most recently viewed dashboard for that user, in the past 24 hours.
      
      This is not meant to be a permanent solution to providing this bit of info for the user, rather, it's a 'stop gap'
      while the audit tables are reworked.
      
      * Add test for most recent dashboard setting
      
      * Pass :context to the view log fns
      
      This lets us filter out views triggered by pinned cards.
      
      * Fix tests failing after adding :context to view metadata
      
      * See if card-query can help us filter out pinned item views
      
      * Tests should send :card-query events
      
      * Since we use :card-query, we have to filter out dashboard context too
      
      This should prevent views being recorded if someone just opens a dashboard.
      
      * ViewLog Cleanup to see if it'll let other tests pass
      
      * fix build
      
      * clean ns and fix build
      
      ---------
      
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      b40e1a35
    • metabase-bot[bot]'s avatar
    • Ngoc Khuat's avatar
      Manual backport: Fix Add Series modal performance issues by moving the logic to the BE (#30971) · 89f599d1
      Ngoc Khuat authored
      * backport 30321 with lots of custom code that take from 47
      
      * rm src/metabase/lib/isa.clj
      
      * fix isa_test
      89f599d1
    • metabase-bot[bot]'s avatar
      Use display name from model for implicit actions (#30356) (#30501) · a96ce5f7
      metabase-bot[bot] authored
      
      * Use display name from card for implicit actions
      
      * Remove fields arg from generateFieldSettingsFromParameters
      
      * Update implicit action test to include display-name
      
      * Tidy
      
      * Fix unit tests
      
      * Fix e2e test
      
      * Only include display-name in the parameters for implicit action types
      
      * Use `field.displayName()`
      
      * Fix some tests
      
      * Attempt to fix test
      
      * Fix ActionParametersInputForm unit tests
      
      * Only generate field settings from parameters if action.type is implicit
      
      * Fix e2e tests
      
      * Fix unit tests
      
      * Fix tests
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      a96ce5f7
    • Nemanja Glumac's avatar
      :cherries: Backport pre-release improvements (#30972) · 08958265
      Nemanja Glumac authored
      
      * CI: Prerelease workflow improvements (#30819)
      
      - Abort if the intended version conflicted with a past release
      - Bail out if the commit hash isn't part of a release branch
      
      * CI prerelease workflow: pretend to be the intended version (#30915)
      
      ---------
      
      Co-authored-by: default avatarAriya Hidayat <ariya@metabase.com>
      08958265
    • metabase-bot[bot]'s avatar
  11. May 23, 2023
Loading