This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 07, 2023
-
-
metabase-bot[bot] authored
Updates Snowflake driver to decode uploaded private key file data if necessary Co-authored-by:
john-metabase <92878045+john-metabase@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Jun 06, 2023
-
-
Luis Paolini authored
* Fix native source query handling for mongo * Add test for mongo nested native query * Fix mongo `aggregation-at-index` usage * Add test for source query with aggregation and sort * Adjust test for presto and oracle * Add PR suggestions Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com>
-
metabase-bot[bot] authored
-
Kamil Mielnik authored
Manual backport - Fix - Native editor buttons are incorrectly rendering on top of model metadata screen (#31142) (#31348) * Manually backport #31142 - Replace createSampleDatabase with createMockDatabase - Add missing metrics, schemas, and segments attributes in EntitiesState type - EntitiesState type has been heavily refactored in master and that version should be used - Tests will will crash without it these set in state.entities * Fix types
-
- Jun 02, 2023
-
-
Nemanja Glumac authored
* CI pre-release: Add sanity check (#31202) * Pre-build the specific version and edition of MB (#31296) Simply invoking `.bin/build.sh` will produce the uberjar without a version. This is why @ariya created #30915 in the first place. But the build script already takes `:version` and `:edition` arguments. That is exactly what this PR is doing rather than manually unzipping the uberjar in order to tweak its `version.properties` file. --------- Co-authored-by:
Ariya Hidayat <ariya@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Natalie <nat@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
john-metabase <92878045+john-metabase@users.noreply.github.com>
-
- Jun 01, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Natalie <nat@metabase.com>
-
Nemanja Glumac authored
Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Nemanja Glumac authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
Nemanja Glumac authored
* Make custom `button` command chainable * Chain `.button` directly No need to use `.within()` anymore. We can chain the button command directly because it now receives the previously yielded subject. * Fix collections bulk actions test
-
Kamil Mielnik authored
Manual backport - Fix - Cannot run native queries against MongoDB unless explicitly selecting the table (#31111) (#31198) * Update 15946 e2e test - modal() expects ModalContent to be present in DOM, but NativeQuerymodal uses ModalBody directly - add extra check for run button to be enabled * Add `collection` to `NativeQuery` type * Ensure collection is present in dataset query during query conversion * Unskip e2e test for #15946 * Handle string tableId --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
- May 31, 2023
-
-
Nemanja Glumac authored
[ci skip]
-
Nemanja Glumac authored
* Make E2E custom icon command chainable * Refactor E2E helpers We can now chain the `.icon()` command on the previous subject. * Chain `.icon()` on prev subject in all tests * Fix moderation-question test
-
metabase-bot[bot] authored
* Repro #23293: Retain filter on drill-through with implicit column (#31187) The underlying issue was fixed, but we are not sure exactly when. This reproduction should prevent future regressions. * Adjust the test for the release branch --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
- May 30, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Natalie <nat@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Natalie <nat@metabase.com>
-
metabase-bot[bot] authored
Fix not able to Enable/Disable Actions when Choose when syncs and scans happen is Enabled (#30976) (#31061) * Fix not being able to Enable/Disable Actions when Choose when syncs and scans happen is Enabled * Fix test Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
Mark Bastian authored
Manual Backport of #31102
-
Mahatthana (Kelvin) Nomsawadi authored
This is because `source-field` was missing from a field dimension.
-
Nemanja Glumac authored
-
metabase-bot[bot] authored
Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- May 29, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- May 28, 2023
-
-
Ngoc Khuat authored
-
- May 26, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Natalie <nat@metabase.com>
-
metabase-bot[bot] authored
* Add a test case for #28981 * Always open ActionParametersInputModal when clicking an action - update unit tests to reflect this behavior Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- May 24, 2023
-
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
* open metabase links in same iFrame when embedding * unit test link behavior Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
Noah Moss authored
* recent_views stored in user local setting (#29631) * First pass at recent_views stored in user local setting This modifies the view log event handler to write a user's views to their local settings map (stored as json in the appdb). some notes on what causes a view :card-query - occurs when collection with pinned cards/models is opened. maybe shouldn't count as a view :card-read - happens when you view a card, like, load it in the UI and are looking at it :card-read AND :card-query - happens when you view a model, like, load it in the UI and are looking at it :dashboard-read - happens when you view a dashboard :card-create - when you save a card - this will probably cause double counts because it will save and then trigger a :card-read right away too :table-read - when viewing a table. - when selecting a db/table in dropdowns in the Question editor I think we need the view log topics to be much smaller: #{:card-read :dashboard-read :table-read} * WIP test for the recent_views user local setting. This isn't totally correct yet. I think it doesn't clean up after itself correctly. That's pending. And, I have to investigate because :table-read isn't working either. Still worth pushing this progress! * Test that works! All potential view events need :actor_id * Working test for /api/recent_views * Order of views in user-local recent-views works now If a user views something they've recently viewed, the homepage order doesn't change. Now it will, as in, the most recently viewed item will always be the first item in the vector. * One time recent_views expensive query done in the user-recent-views getter The logic of filling the recent-views setting was first written in the activity api namespace. Now it's handled where the setting is defined, which lets anyone else consuming the setting not worry about filling it if its empty. The setting can be reset with `nil` which will cause the query to run again. Otherwise, if the list of recent items is an empty vector, that is considered valid and will not re-run the query. Updating the setting per view is handled still in the view log handler, implemented in the private function `update-users-recent-views!`. * Add `most-recently-viewed-dashboard` setting The most recently viewed dashboard for that user, in the past 24 hours. This is not meant to be a permanent solution to providing this bit of info for the user, rather, it's a 'stop gap' while the audit tables are reworked. * Add test for most recent dashboard setting * Pass :context to the view log fns This lets us filter out views triggered by pinned cards. * Fix tests failing after adding :context to view metadata * See if card-query can help us filter out pinned item views * Tests should send :card-query events * Since we use :card-query, we have to filter out dashboard context too This should prevent views being recorded if someone just opens a dashboard. * ViewLog Cleanup to see if it'll let other tests pass * fix build * clean ns and fix build --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Ngoc Khuat authored
* backport 30321 with lots of custom code that take from 47 * rm src/metabase/lib/isa.clj * fix isa_test
-
metabase-bot[bot] authored
* Use display name from card for implicit actions * Remove fields arg from generateFieldSettingsFromParameters * Update implicit action test to include display-name * Tidy * Fix unit tests * Fix e2e test * Only include display-name in the parameters for implicit action types * Use `field.displayName()` * Fix some tests * Attempt to fix test * Fix ActionParametersInputForm unit tests * Only generate field settings from parameters if action.type is implicit * Fix e2e tests * Fix unit tests * Fix tests Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
Nemanja Glumac authored
* CI: Prerelease workflow improvements (#30819) - Abort if the intended version conflicted with a past release - Bail out if the commit hash isn't part of a release branch * CI prerelease workflow: pretend to be the intended version (#30915) --------- Co-authored-by:
Ariya Hidayat <ariya@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Roman Abdulmanov <roman@metabase.com>
-
- May 23, 2023
-
-
Aleksandr Lesnenko authored
* Remove activity (#29056) * remove activity frontend * remove the activity page code * remove GET api/activity/ route + tests * regen dox for activity routes - Not for GET /api/activity/ which has been removed. * nix more things only used for GET /api/activity/ * pull out more only-used-for-get-api/activity/ code * force namespace to be loaded (?) to be found --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com> Co-authored-by:
Bryan Maass <bryan.maass@gmail.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> * fix ns requires in api/activity + test * remove most-recently-viewed-dashboard-views-test * linter fix --------- Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com> Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-