Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 16, 2023
    • john-metabase's avatar
      Always create a transient dataset for BigQuery tests (#31605) · 40a3d6e7
      john-metabase authored
      
      Resolves #28792 
      
      * Always create a transient dataset for BigQuery tests
      
      * Simplifies BigQuery test data code
      
      * More BigQuery test data code cleanup
      
      * More BigQuery test data code cleanup, test fix
      
      * Extracts test-db-name in bigquery tests, restores normalize-name
      
      * Fixes BigQuery QP tests for new test DB name scheme
      
      * Removes extraneous clojure.core
      
      * Updates bigquery QP test helper code style
      
      * Cleans up comments and code in bigquery test data
      
      * Update modules/drivers/bigquery-cloud-sdk/test/metabase/driver/bigquery_cloud_sdk/query_processor_test.clj
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      ---------
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Unverified
      40a3d6e7
    • Nemanja Glumac's avatar
      Fix wrong issue reference in E2E test (#31547) · 6297bbff
      Nemanja Glumac authored
      [ci skip]
      Unverified
      6297bbff
    • Nemanja Glumac's avatar
      [E2E] Add `actions` to stubbed skipped job (#31640) · 01fbd97d
      Nemanja Glumac authored
      I forgot to do this in #31432.
      As the result, some PRs have been stuck in CI due to the required check.
      
      This PR will run the fallback job for `actions` E2E group when changed
      files don't require E2E tests to run.
      
      [ci skip]
      Unverified
      01fbd97d
    • Nick Fitzpatrick's avatar
      custom homepage modal (#31398) · dca89cc3
      Nick Fitzpatrick authored
      
      * WIP showing Toast
      
      * add dismissed_toasts stub on GET api/user/current
      
      * backend to save dismissed toast names as user-local-settings
      
      - adds dismissed_toasts key to GET user/current
      - introduces POST /user/:user-id/dismissed/:toast-name
        - For now, only custom_homepage_changed is a valid `toast-name`, but
          it can be extended to others.
        - I nearly put in a DELETE to unset it, which could be useful for
          tests, but took it out.
      
      * add untested DELETE route to ease devtime pains
      
      * setup dismissed-custom-dashboard-toast to be "yet another setting"
      
      - remove specific endpoints
      - keep the result on GET api/user/current
      
      * dismissed_toasts + improve setting api to take Snake Case
      
      - with tests
      
      * Adding dismiss action
      
      * dismissed toast map
      
      * Ensure that toast is dismissed for admin who set the custom homepage property
      
      * Fixing 2 toasts on login
      
      * Moving dismissed toast to settings
      
      * updateSettings, undo.canDismiss
      
      * adding loading state to settings, removing unneeded CLJ tests
      
      
      ---------
      
      Co-authored-by: default avatarBryan Maass <bryan.maass@gmail.com>
      Unverified
      dca89cc3
    • Ngoc Khuat's avatar
    • Ngoc Khuat's avatar
      Rest of models to toucan2 :tada: (#31385) · 647181fc
      Ngoc Khuat authored
      * User to toucan2
      
      * Pulse to toucan2
      
      * PulseCard to toucan 2
      
      * PulseChannel and PulseChannelRecipient to toucan2
      
      * Query, QueryCache, QueryExecution to toucan2
      
      * Metric, Segment, MetricImportantField to toucan2
      
      * ParameterCard to toucan2
      
      * DataMigrations and FakeCard to toucan2
      
      * NativeQuerySnippet to toucan2
      Unverified
      647181fc
    • metamben's avatar
      Disable slow test to prevent flakiness (#31594) · c7ddd5b5
      metamben authored
      * Disable slow test to prevent flakiness
      
      Fixes #29266.
      Unverified
      c7ddd5b5
  2. Jun 15, 2023
  3. Jun 14, 2023
    • bryan's avatar
      update audit log view migration (#31589) · b8c61c12
      bryan authored
      
      * update audit log view migration
      
      * separate mysql and fix h2
      
      * typo
      
      * fix views
      
      ---------
      
      Co-authored-by: default avatarLuiz Arakaki <luiz.arakaki@metabase.com>
      Unverified
      b8c61c12
    • Denis Berezin's avatar
      Fix dashboard description markdown overflow (#31534) · e3ac91c2
      Denis Berezin authored
      * Fix dashboard description markdown overflow
      
      * Review fixes, Improved e2e test
      Unverified
      e3ac91c2
    • shaun's avatar
      Fix boolean icons in SQL query editor (#31538) · d76dc232
      shaun authored
      
      * Fetch field icon from dimension instead of semantic_type (#28622)
      
      * simplify field.dimension().icon() → field.icon()
      
      * resync tooltip to reflect non-semantic icon
      
      * add ts-ignore to iconName with justification
      
      * Updating eslint rules to allow importing types to metabase-lib
      
      * Revert "Updating eslint rules to allow importing types to metabase-lib"
      
      This reverts commit 1b6aca4362a7ca530046466bc9c1bfc02d5b116c.
      
      ---------
      
      Co-authored-by: default avatarAbdul Aziz Ali <abdulazizali@acm.org>
      Co-authored-by: default avatarNick Fitzpatrick <nickfitz.582@gmail.com>
      Unverified
      d76dc232
    • Anton Kulyk's avatar
      Migrate notebook breakout step to MLv2 (#30693) · 75b6d921
      Anton Kulyk authored
      * Add `BreakoutClause` type
      
      * Extend `displayInfo` for breakouts
      
      * Add wrappers for `breakouts` and `breakout`
      
      * Fix property names in breakout clause types
      
      * Add TypeScript wrappers for temporal buckets
      
      * Add basic `ColumnPrecisionPickerPopover`
      
      * Add TypeScript wrappers for binning strategies
      
      * Add `BinningStrategyPickerPopover`
      
      * Rename to `TemporalBucketPickerPopover`
      
      * Remove type properties from breakout clause type
      
      * Unify temporal bucket and binning strategy types
      
      * Unify bucket pickers
      
      * Fix `isCalculated` property name
      
      * Fix bucket methods usage in Jest
      
      * Allow calling `displayInfo` with `Clause`
      
      * Add `isClauseColumn` helper
      
      * Make bucket pickers optional in `QueryColumnPicker`
      
      * Highlight selected column in `QueryColumnPicker`
      
      * Add a11y labels to bucket pickers
      
      * Use `createMockMetadata` in notebook tests
      
      * Use MLv2 in `BreakoutStep`
      
      * Update `SortStep`
      
      * Fix stage index for `BreakoutStep`
      
      * Tweak bucket types
      
      * Use named exports for bucket popovers
      
      * Format temporal bucket name in the column picker
      
      * Update `binning` and `temporalBucket` types
      
      * Add `isSameBucket` utility
      
      * Tweak the column picker
      
      * highlight selected bucket
      * prevent unexpected bucket reset
      
      * Use temporal buckets JS wrappers
      
      * Use default bucket in the column picker
      
      * Fix temporal bucket test
      
      * Add test IDs for compatibility with e2e tests
      
      * Fix "Unbinned" bucket handling
      
      * Fix e2e test to use a11y selectors
      
      * Add long-display-name to display-info
      
      * Use long display name in the notebook
      
      * Skip getting metadata from nil
      
      * Handle JS objects as fingerprint metadata
      
      * Set max height for bucket picker popover
      
      * Fix `summarization.cy.spec` test
      
      * Fix `joins.cy.spec` test
      
      * Attempt to fix MLv2 query validation
      
      * Test that integer expressions are recognized by isa/numeric?
      
      * Make stage index explicit
      
      * Fix custom-columns e2e tests
      
      * Fix breakout validation
      
      * Remove `React` imports
      
      * Break down `hasBucketing` prop
      
      * Keep the metadata from the tables list for questions (#31162)
      
      * Keep the metadata from the tables list for questions
      
      Previously, the metadata loaded from "questions" would overwrite
      the metadata loaded from "tables" if both existed. This PR changes
      that to merge the information from the two sources instead.
      
      * Skip using _plainObject when parsing cards from table metadata
      
      * Format saved question display names in joins as "Question <card-id>"
      
      * Deal with field-ref shaped field IDs in the JS provided metadata
      
      * Fix long display name source question breakout (#31312)
      
      * Fix icon import
      
      * Fix e2e test
      
      * Fix e2e test
      
      * Allow field references by name
      
      * Make sure no temporal buckets and binning strategies are offered for expressions
      
      * Fix MLv2 tests
      
      * Return empty vector for visible-columns on nil
      
      * Add `base-type` to MLv1 compatible field rfs
      
      * Use `selected` flag on buckets
      
      * Recognize expression columns when marking selected breakouts
      
      * Add backend regression test for expression breakout column handling
      
      * Test fix
      
      * Rework column bucket pickers
      
      * delegate more responsibilities to binning/temporal pickers
      * include "Don't bin" option on FE vs BE
      
      * Fix e2e test
      
      * Rework bucket pickers 2
      
      Forgot to push this in the first place :man_facepalming:
      
      
      
      * Fix redundant eslint-disable comment
      
      * Use *-position to check if a column is selected
      
      * Remove dont-bin pseudo binning strategy (#31443)
      
      * Fix matching breakout columns with binning (#31441)
      
      * Stop filtering out "Don't bin" on the FE
      
      * Fix #31482 not showing join display name for busted breakout from drill thru
      
      * MLv2: Fix matching of field literals to field integer IDs (#31487)
      
      * MLv2: Fix matching of field literals to field integer IDs
      
      * Better test
      
      * Update src/metabase/lib/equality.cljc
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      ---------
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Remove infinite recursion when resolving fields by name (#31485)
      
      * Remove infinite recursion when resolving fields by name
      
      * Remove stray tap>
      
      ---------
      
      Co-authored-by: default avatarCase Nelson <case@metabase.com>
      Co-authored-by: default avatarTamás Benkő <tamas@metabase.com>
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Co-authored-by: default avatarCam Saul <github@camsaul.com>
      Co-authored-by: default avatarCam Saul <1455846+camsaul@users.noreply.github.com>
      Unverified
      75b6d921
    • shaun's avatar
      fix funnel tooltip artifacts in safari (#31494) · 74cfb332
      shaun authored
      
      * fix funnel tooltip artifacts in safari
      
      * force composite-layer instead of forceRedraw
      
      * used styled components
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      74cfb332
    • shaun's avatar
      fix frontend dev for safari (#31457) · 6ede838b
      shaun authored
      Unverified
      6ede838b
    • Nemanja Glumac's avatar
      [E2E] Do not hardcode admin id (#31576) · 0438823a
      Nemanja Glumac authored
      We're trying to minimize the amount of hard coded IDs (or any other data) in E2E tests. This change doesn't assume admin's ID is always going to be 1. It fetches the id from the current user instead.
      
      This should make test more resilient to change.
      Unverified
      0438823a
    • bryan's avatar
      Auditv2 modify views: add v_audit_log + update v_content (#31563) · a38b6464
      bryan authored
      * add the migrations
      
      * edit comment
      
      * add 'if exists' to drop view statements
      
      * update yaml: move sql to the right spot
      Unverified
      a38b6464
    • Nemanja Glumac's avatar
      Refactor E2E tests in the `sharing` folder (#31455) · 4c01a8cf
      Nemanja Glumac authored
      * Extract `questionDetails`
      
      * Move `public-sharing` to the `sharing` folder
      
      * Remove redundant test
      
      This part was covered in `public-sharing.cy.spec.js`.
      
      * Create a separate `public-dashboard` E2E spec
      
      - Extract relevant part from `public.cy.spec.js`
      - Make all tests in `public-dashboard.cy.spec.js` run in isolation
      
      * Make tests in `public.cy.spec.js` run in isolation
      
      * Remove redundant wait
      
      * Limit the query results to speed test up
      
      * Merge public questions E2E tests
      
      * Merge `downloads` with the `sharing` E2E group
      
      * Remove `downloads` from the folder list
      
      * Refactor `public-dashboard.cy.spec.js`
      
      - Clean up linter warnings by using semantic selectors
      - Speed test up by using API
      Unverified
      4c01a8cf
    • Tim Macdonald's avatar
    • Ngoc Khuat's avatar
  4. Jun 13, 2023
  5. Jun 12, 2023
Loading