This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 16, 2023
-
-
john-metabase authored
Resolves #28792 * Always create a transient dataset for BigQuery tests * Simplifies BigQuery test data code * More BigQuery test data code cleanup * More BigQuery test data code cleanup, test fix * Extracts test-db-name in bigquery tests, restores normalize-name * Fixes BigQuery QP tests for new test DB name scheme * Removes extraneous clojure.core * Updates bigquery QP test helper code style * Cleans up comments and code in bigquery test data * Update modules/drivers/bigquery-cloud-sdk/test/metabase/driver/bigquery_cloud_sdk/query_processor_test.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Nemanja Glumac authored
[ci skip]
-
Nemanja Glumac authored
I forgot to do this in #31432. As the result, some PRs have been stuck in CI due to the required check. This PR will run the fallback job for `actions` E2E group when changed files don't require E2E tests to run. [ci skip]
-
Nick Fitzpatrick authored
* WIP showing Toast * add dismissed_toasts stub on GET api/user/current * backend to save dismissed toast names as user-local-settings - adds dismissed_toasts key to GET user/current - introduces POST /user/:user-id/dismissed/:toast-name - For now, only custom_homepage_changed is a valid `toast-name`, but it can be extended to others. - I nearly put in a DELETE to unset it, which could be useful for tests, but took it out. * add untested DELETE route to ease devtime pains * setup dismissed-custom-dashboard-toast to be "yet another setting" - remove specific endpoints - keep the result on GET api/user/current * dismissed_toasts + improve setting api to take Snake Case - with tests * Adding dismiss action * dismissed toast map * Ensure that toast is dismissed for admin who set the custom homepage property * Fixing 2 toasts on login * Moving dismissed toast to settings * updateSettings, undo.canDismiss * adding loading state to settings, removing unneeded CLJ tests --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
Ngoc Khuat authored
-
Ngoc Khuat authored
* User to toucan2 * Pulse to toucan2 * PulseCard to toucan 2 * PulseChannel and PulseChannelRecipient to toucan2 * Query, QueryCache, QueryExecution to toucan2 * Metric, Segment, MetricImportantField to toucan2 * ParameterCard to toucan2 * DataMigrations and FakeCard to toucan2 * NativeQuerySnippet to toucan2
-
metamben authored
* Disable slow test to prevent flakiness Fixes #29266.
-
- Jun 15, 2023
-
-
john-metabase authored
-
metamben authored
This should not really happen, but parts of the code handle this situation while others don't.
-
Dennis Schridde authored
Due to AOT (Ahead Of Time) compilation (specifically direct linking), the `MB_COLORIZE_LOGS` and `MB_EMOJI_IN_LOGS` env vars where not respected. Marking `metabase.util.format/colorize` and `metabase.util/emoji` with `^:redef` metadata prevents the compiler from using direct linking for calls to these functions (and thus evaluating the env vars at compile time) and thus delays resolution of what function to call until runtime when the actual user-provided value of the env var is known. cf. https://clojure.org/reference/compilation#directlinking Closes: https://github.com/metabase/metabase/issues/30518
-
metamben authored
Also make sure that the attached columns have the right temporal bucket information.
-
john-metabase authored
* Filter import on YAML extension * sorts namespaces --------- Co-authored-by:
Luiz Arakaki <luiz.arakaki@metabase.com>
-
Cal Herries authored
-
Tim Macdonald authored
* Avoid expensive call to fetch DB metadata Double-checking the schema name is unnecessarily defensive since we already call include-schema? * Check that schema is set
-
Lena authored
Previously: one “feature or project” template with the `.Epic` label automatically attached. Now: two templates, one for epics, one for smaller things that don't require milestones (or `.Epic` label; they get `.Task` instead). Squashed commit messages follow: * Remove unused optional field * Update title to current convention * Fix typo * Remove unused section * Change capitalization for consistency * Remove redundant description * Rename the issue template to mention epic * Shorten the description of the issue template * Lighten up the milestones section Unfortunately, it doesn't seem possible to prepopulate the issue with an empty tasklist (https://github.com/orgs/community/discussions/50502). * Add an issue template for tasks [ci skip] We had one for epics, with milestones and `.Epic` label. Pretty often that label was accidentally left on smaller issues that were created using the same template. Now the smaller issues have their own template and their own label. Yay. https://metaboat.slack.com/archives/C04CGFHCJDD/p1686548875239219 * Remove redundant angle brackets * Use a string to get a valid yaml file Without the quotes, github says `Error in user YAML: (<unknown>): did not find expected key while parsing a block mapping at line 1 column 1` * Remove rarely if ever used placeholders * Call out optional-ness of some links * Contextualize a header Context can be some text, a slack thread, a notion page, another issue, whatever.
-
- Jun 14, 2023
-
-
bryan authored
* update audit log view migration * separate mysql and fix h2 * typo * fix views --------- Co-authored-by:
Luiz Arakaki <luiz.arakaki@metabase.com>
-
Denis Berezin authored
* Fix dashboard description markdown overflow * Review fixes, Improved e2e test
-
shaun authored
* Fetch field icon from dimension instead of semantic_type (#28622) * simplify field.dimension().icon() → field.icon() * resync tooltip to reflect non-semantic icon * add ts-ignore to iconName with justification * Updating eslint rules to allow importing types to metabase-lib * Revert "Updating eslint rules to allow importing types to metabase-lib" This reverts commit 1b6aca4362a7ca530046466bc9c1bfc02d5b116c. --------- Co-authored-by:
Abdul Aziz Ali <abdulazizali@acm.org> Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
Anton Kulyk authored
* Add `BreakoutClause` type * Extend `displayInfo` for breakouts * Add wrappers for `breakouts` and `breakout` * Fix property names in breakout clause types * Add TypeScript wrappers for temporal buckets * Add basic `ColumnPrecisionPickerPopover` * Add TypeScript wrappers for binning strategies * Add `BinningStrategyPickerPopover` * Rename to `TemporalBucketPickerPopover` * Remove type properties from breakout clause type * Unify temporal bucket and binning strategy types * Unify bucket pickers * Fix `isCalculated` property name * Fix bucket methods usage in Jest * Allow calling `displayInfo` with `Clause` * Add `isClauseColumn` helper * Make bucket pickers optional in `QueryColumnPicker` * Highlight selected column in `QueryColumnPicker` * Add a11y labels to bucket pickers * Use `createMockMetadata` in notebook tests * Use MLv2 in `BreakoutStep` * Update `SortStep` * Fix stage index for `BreakoutStep` * Tweak bucket types * Use named exports for bucket popovers * Format temporal bucket name in the column picker * Update `binning` and `temporalBucket` types * Add `isSameBucket` utility * Tweak the column picker * highlight selected bucket * prevent unexpected bucket reset * Use temporal buckets JS wrappers * Use default bucket in the column picker * Fix temporal bucket test * Add test IDs for compatibility with e2e tests * Fix "Unbinned" bucket handling * Fix e2e test to use a11y selectors * Add long-display-name to display-info * Use long display name in the notebook * Skip getting metadata from nil * Handle JS objects as fingerprint metadata * Set max height for bucket picker popover * Fix `summarization.cy.spec` test * Fix `joins.cy.spec` test * Attempt to fix MLv2 query validation * Test that integer expressions are recognized by isa/numeric? * Make stage index explicit * Fix custom-columns e2e tests * Fix breakout validation * Remove `React` imports * Break down `hasBucketing` prop * Keep the metadata from the tables list for questions (#31162) * Keep the metadata from the tables list for questions Previously, the metadata loaded from "questions" would overwrite the metadata loaded from "tables" if both existed. This PR changes that to merge the information from the two sources instead. * Skip using _plainObject when parsing cards from table metadata * Format saved question display names in joins as "Question <card-id>" * Deal with field-ref shaped field IDs in the JS provided metadata * Fix long display name source question breakout (#31312) * Fix icon import * Fix e2e test * Fix e2e test * Allow field references by name * Make sure no temporal buckets and binning strategies are offered for expressions * Fix MLv2 tests * Return empty vector for visible-columns on nil * Add `base-type` to MLv1 compatible field rfs * Use `selected` flag on buckets * Recognize expression columns when marking selected breakouts * Add backend regression test for expression breakout column handling * Test fix * Rework column bucket pickers * delegate more responsibilities to binning/temporal pickers * include "Don't bin" option on FE vs BE * Fix e2e test * Rework bucket pickers 2 Forgot to push this in the first place
* Fix redundant eslint-disable comment * Use *-position to check if a column is selected * Remove dont-bin pseudo binning strategy (#31443) * Fix matching breakout columns with binning (#31441) * Stop filtering out "Don't bin" on the FE * Fix #31482 not showing join display name for busted breakout from drill thru * MLv2: Fix matching of field literals to field integer IDs (#31487) * MLv2: Fix matching of field literals to field integer IDs * Better test * Update src/metabase/lib/equality.cljc Co-authored-by:metamben <103100869+metamben@users.noreply.github.com> --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Remove infinite recursion when resolving fields by name (#31485) * Remove infinite recursion when resolving fields by name * Remove stray tap> --------- Co-authored-by:
Case Nelson <case@metabase.com> Co-authored-by:
Tamás Benkő <tamas@metabase.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> Co-authored-by:
Cam Saul <github@camsaul.com> Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
shaun authored
* fix funnel tooltip artifacts in safari * force composite-layer instead of forceRedraw * used styled components --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
shaun authored
-
Nemanja Glumac authored
We're trying to minimize the amount of hard coded IDs (or any other data) in E2E tests. This change doesn't assume admin's ID is always going to be 1. It fetches the id from the current user instead. This should make test more resilient to change.
-
bryan authored
* add the migrations * edit comment * add 'if exists' to drop view statements * update yaml: move sql to the right spot
-
Nemanja Glumac authored
* Extract `questionDetails` * Move `public-sharing` to the `sharing` folder * Remove redundant test This part was covered in `public-sharing.cy.spec.js`. * Create a separate `public-dashboard` E2E spec - Extract relevant part from `public.cy.spec.js` - Make all tests in `public-dashboard.cy.spec.js` run in isolation * Make tests in `public.cy.spec.js` run in isolation * Remove redundant wait * Limit the query results to speed test up * Merge public questions E2E tests * Merge `downloads` with the `sharing` E2E group * Remove `downloads` from the folder list * Refactor `public-dashboard.cy.spec.js` - Clean up linter warnings by using semantic selectors - Speed test up by using API
-
Tim Macdonald authored
-
Ngoc Khuat authored
-
- Jun 13, 2023
-
-
Cal Herries authored
* Add snowplow event tracking * Use integer type for model_id and size_mb instead of size_bytes * Rename upload_speed to upload_seconds and avoid wasting time if the upload was successful
-
Ryan Laurie authored
-
Denis Berezin authored
* Add action edit modal call (#31171) * Add action edit from action call form modal * Code review, unit tests * Add e2e test * fixup! Code review, unit tests * Code review, more tests * Add edit action trigger tooltip * Possible fix for read only model * Fix e2e tests
-
Cal Herries authored
-
Nemanja Glumac authored
* Remove unnecessary intercept * Add limit (3) to the source query Adding limit to the source query doesn't affect the reproduction confidence, but it greatly improves performance. * Fix eslint warning * Improve assertions
-
Noah Moss authored
* fix migrations and add new test * fix migration IDs in test * dont fail migration if FK already exists * rewrite without table aliases to try to fix error on mysql/mariadb * try to rewrite again * revert to prior version of query * another attempt at a rewrite * fix typo * fix typo * bump ci * replace LIKE with =
-
Ngoc Khuat authored
-
Oisin Coveney authored
-
Tim Macdonald authored
* Restrict uploading to people with correct perms [Fixes #30322]
-
Kamil Mielnik authored
* Remove unused openCollection prop * Preserve collection sorting given by API in getExpandedCollectionsById - Fixes #31294 * Use Collections.getListStatePath() to unhardcode the object path * Use CollectionId instead of any * Extract Collections.selectors.getCollectionList * Convert Collections selectors unit tests to TypeScript * Remove redundant selector * Add a unit test for Collections.selectorsgetExpandedCollectionsById * Use createMockCollection for all test collections - Use Partial<Collection> instead of MockCollection type * Add a test case for non-nested collections * Rename identifiers * Add a test suite for snippet collections * Fix SnippetCollections.selectors.getExpandedCollectionsById * Refactor tests * Refactor tests * Revert unit tests for selectors * Revert convert selectors to TypeScript * Add error support to setupCollectionsEndpoints * Introduce useCollectionsQuery * Fix tests * Add unit tests for preserving order of collections in ItemPicker * Make assertions more semantic * Allow mocking root collection - Make ROOT_COLLECTION object match Collection type * Add tests for preserving order in snippet collections list - fix case with an undefined snippet collections list * Update test case with data loading necessary for ItemPicker underneath the EditSandboxModal after updating selectors * Update test case with data loading necessary for ItemPicker underneath the AddToDashSelectDashModal after updating selectors * Rename useCollectionsQuery to useCollectionListQuery * Remove leftover fetchMock * Move error out of setupCollectionsEndpoints * Fix ModelDetailPage unit tests setup * Remove leftover fetchMocks * Revert changes to ROOT_COLLECTION constant - use createMockCollection * Fix typing * Remove dead link to Source Sans Pro font - it caused markdown check to fail during CI, this fixes it - it seems that the font has been removed from Google Fonts - users can still choose this font in Metabase settings - removal confirmation: https://metaboat.slack.com/archives/C5XHN8GLW/p1686320576992299?thread_ts=1686319384.637909&cid=C5XHN8GLW * Fix getExpandedCollectionsById selector * Revert adding useCollectionListQuery in unit tests
-
- Jun 12, 2023
-
-
shaun authored
-
Nemanja Glumac authored
-
Alexander Polyankin authored
-
Cam Saul authored
* MLv2: Fix matching of field literals to field integer IDs (#31487) * MLv2: Fix matching of field literals to field integer IDs * Better test * Update src/metabase/lib/equality.cljc Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Fix #31482 not showing join display name for busted breakout from drill thru --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-