Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 05, 2023
    • Kamil Mielnik's avatar
      Adding filter of summarized field grouped by latitude and longitude on a map... · 443a8ced
      Kamil Mielnik authored
      Adding filter of summarized field grouped by latitude and longitude on a map changes visualization type (#31646)
      
      * Take sourceQuery into account if StructuredQuery does not have any aggregations or breakouts when determining Question's default display
      - It's an attempt to fix #30057
      
      * Don't check source query for models
      
      * Use source query breakouts and aggregations to determine default display only if the question does not have any breakouts, aggregations, and joins
      - Make the condition to always use "table" display for Models more prominent
      
      * Revert first attempt
      
      * Introduce CardObject and fix displayIsLocked typing
      
      * Refactor maybeUnlockDisplay into maybeResetDisplay
      
      * Revert "Introduce CardObject and fix displayIsLocked typing"
      
      This reverts commit 770e7a50d3b9f381741ba7cb1655c1d9be5f295c.
      
      * Improve diff
      
      * Update unit tests after maybeUnlockDisplay to maybeResetDisplay refactoring
      
      * Update maybeResetDisplay unit tests
      
      * Improve test case names
      
      * Add tag for the test that reproduces the issue
      
      * Add test for issue #30057
      - use visualize() helper
      - extract addCountGreaterThan2Filter()
      
      * Add a test case for adding columns
      
      * Add a test case for removing columns (resetting to default value)
      
      * Add a test case for adding aggregations
      
      * Add another test case
      
      * Reuse e2e helpers
      - add missing "field" parameter support in addSummaryGroupingField
      - add removeSummaryGroupingField
      
      * Remove redundant condition
      
      * Update issue id in tests after extracting separate GitHub issue
      Unverified
      443a8ced
  2. Jul 04, 2023
  3. Jul 03, 2023
  4. Jul 01, 2023
  5. Jun 30, 2023
  6. Jun 29, 2023
Loading