Co-authored-by: Nick Fitzpatrick <nickfitz.582@gmail.com>

Co-authored-by: Sloan Sparger <sloansparger@users.noreply.github.com>

* css animation on disclosure triangle

* Full page modal using mantine transition

* removing comment

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

Co-authored-by: Nick Fitzpatrick <nickfitz.582@gmail.com>

* using CSS animations for notebook previews (#39717)

* using CSS animations for notebook previews

* useMemo

* optimizations on question creation

* backporting use-modal-open hook

---------

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Co-authored-by: Nick Fitzpatrick <nickfitz.582@gmail.com>

Co-authored-by: Alexander Solovyov <alexander@solovyov.net>

* removes react motion usage from bulk action related components and replaces with mantine transition component

* removes unused eslint disable comment

* fixes e2e tests

Co-authored-by: Sloan Sparger <sloansparger@users.noreply.github.com>

Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

Avoid showing the help test dialog for unsupported features

Co-authored-by: Romeo Van Snick <romeo@romeovansnick.be>

Co-authored-by: Raphael Krut-Landau <raphael.kl@gmail.com>

This setting key is defined using kebab-case.
Not sure how it worked (if it worked) using the snake_case?

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

* [HDS] Prep/cleanup steps for Highlighting the data source (#39681)

* Rename `DATA_BUCKET` key to `MODELS`

* Rename misleading method

`isSavedQuestionSelected` is too narrow because we can also have
other saved entities, such as models (and soon metrics) as the selected source.

* Fix type for `selectedTableId`

* Extract `sourceId`

* Rename saved question instances to saved entity

* Rename related components

* Show models correctly in the data source picker (#39686)

* Show models correctly in the data source picker

* Address review comments

* Destructure props

* Add E2E reproduction for #39699

* Prevent accessing potentially stale value

Closes #39699

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

* Revision Diff Should handle `nil` Dashboard Width

Even though there shouldn't be `nil` values in dashboard.width, because the migration populates w/ the default value
of `full`, it is still true that because of the version before the migration, revisions  can have `nil` for the width
value. The diff string impl didn't consider this, causing an NPE with `(name nil)`.

* Use :guard to prevent nil values from matching

* Add test checking that dashboard width change is described correctly

Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>

Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>

Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>

Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>

Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>

Co-authored-by: Raphael Krut-Landau <raphael.kl@gmail.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>

* fix dashcard text gets cut off

* fix magic number

Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>

Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>

Fix click behavior not working for pivot table header cells and tables pivoted (pivoted column cells) (#39569) (#39663)

* update pivot table header cells clicked format to match the expected format

* fix clicked table pivoted click behavior for the chosen pivot column

* fix failing tests

* add tests

Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>

* Metadata Table columns use Sortable List

* cleanup

* e2e test adjustments

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

* ChartSettingOrderedItems using SortableList

* e2e test adjustments

* unit tests

Co-authored-by: Nick Fitzpatrick <nick@metabase.com>

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>

Repro #11994 - Clicking RawData-toggle on pivoted table makes the question dirty and shows Save-button (#39629) (#39689)

* Convert commands/api/question to TS

* Add missing embedding_params and collection_position attributes to Card

* Type question function

* Move types to the top of file

* Inline throwIfNotPresent

* Add types for logAction

* Define StructuredQuestionDetails & NativeQuestionDetails

* Add typing to commands

* Return for consistency

* Remove queryType argument from question

* Define typing for archiveQuestion command

* Format code

* Define typing for createQuestion and createNativeQuestion commands

* Make options optional

* Remove TODO

* Use arrow functions, update JSDoc

* Use type for consistency

* Add missing attributes in mocks

* Make embedding_params non-optional

* Add boilerplate for 11994 repro

* Add temporary code

* Improve typing

* Implement test for combo chart

* Simplify code

* Convert updatePermissions to TS and add typing for updatePermissionsGraph

* Add typing for updatePermissionsSchemas

* Add typing for API responses, make updatePermissionsSchemas parameters optional

* Add JSDocs

* Explicitly specify types in commands

* Use CardId

* Fix the test
- add missing visuzalization_settings to the pivot question
- use "readonly" user and drop permissions manipulations

* Remove TODO

* Add an explanatory comment

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>

* Scroll dashboard tabs to the end when adding a tab

* Fix useEffect deps

* Handle typescript error

Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>

Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>

* Use timestamp in attachment filenames

Fixes: #39120

This modifies the subscriptin attachment filenames to match the same format used when doing a direct download from a
dashboard or question.

That is:
 - card names are slugified (spaces and dashes turned to underscores, etc.)
 - a timestamp is appended to the slugified card name

* Fix tests

* Change docstring to use example local to the namespace

Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>