Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 23, 2023
  2. Feb 22, 2023
  3. Feb 21, 2023
    • john-metabase's avatar
      Improves consistency of substring in MBQL (#28067) · a39b710e
      john-metabase authored
      
      * Improves consistency of substring in MBQL
      
      Standard SQL SUBSTRING() uses a 1-based start index, with various drivers
      handling a 0 start index in different ways. To make the behavior of substring
      consistent across drivers, we will always convert a 0 start index in MBQL
      to a 1 in SQL. The ->honeysql implementation of substring has been generalized
      and drivers can now override just the name of the substring function, or the
      entire expression if necessary. SQL Server now calls the parent implementation.
      
      Resolves #12445
      
      * Fixes substring from 0 in Mongo
      
      * Adds arg to substring parent call
      
      * Fix docs and helper text for substring()
      
      * Adds schema to require positive integer index for substring
      
      * WIP, adds frontend validation for substring index arg
      
      * Adds frontend test for substring arg validation
      
      * Updates substring test to expect exception on index 0
      
      * Update src/metabase/driver/sql/query_processor.clj
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      
      * Use s/if instead of s/conditional
      
      * Fix substring call in mysql substring spec
      
      * Reverts driver and sql.qp changes for substring index
      
      * Reverts changes to dispatch-by-clause-name-or-class
      
      * Fixes typeinferencer test substring index
      
      * Adds test for canonicalizing substring
      
      * Fixes substring canonicalization with extra args
      
      * Updates string extracts test to account for substring canonicalization
      
      * Rewrites resolver validation application
      
      * Adds test case for frontend expression validation errors
      
      * Fixes frontend compiler spec for new substring validation
      
      ---------
      
      Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
      Unverified
      a39b710e
  4. Feb 20, 2023
    • metamben's avatar
      Mongo joins (#28293) · 32854d3c
      metamben authored
      * Make joins work
      
      * Run fuzzy-field-info-test only against H2
      
      * Set driver/*driver* when performing actions
      
      * Restrict expressions+joins-test to DBs supporting date arithmetics
      
      * Fix ordering of (top level) fields in mongo tables
      
      * Explicitly exclude mongo from tests requiring foreign key support
      
      * Optimize away $sort stage for implicit order-by.
      Unverified
      32854d3c
    • Ryan Laurie's avatar
      Custom Table e2e Tests 5: Simple actions testing (#27989) · cecbdc20
      Ryan Laurie authored
      * add helpers for actions testing
      
      * add basic action execution test
      
      * update add action test
      
      * add tags and documentation for tags
      
      * add tags to model actions spec
      
      * update test for new actions adding flow
      
      * fix merge conflicts
      
      * fix merge conflict again
      
      * address review comments
      
      * make test more reliable
      
      * prettier
      
      * prettier
      Unverified
      cecbdc20
  5. Feb 17, 2023
  6. Feb 16, 2023
  7. Feb 15, 2023
  8. Feb 14, 2023
  9. Feb 13, 2023
  10. Feb 10, 2023
  11. Feb 09, 2023
  12. Feb 07, 2023
  13. Feb 06, 2023
  14. Feb 01, 2023
  15. Jan 31, 2023
  16. Jan 30, 2023
  17. Jan 27, 2023
  18. Jan 26, 2023
  19. Jan 25, 2023
  20. Jan 19, 2023
  21. Jan 18, 2023
Loading