This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 20, 2024
-
-
github-automation-metabase authored
-
Uladzimir Havenchyk authored
* Adjust undo toast timeout 12s -> 8s * typo * Address review
-
Alberto Perdomo authored
Remove warnings about not using MB versions in production. This is a left over from the time we were pointing to builds off master and RCs.
-
- Jun 19, 2024
-
-
Raphael Krut-Landau authored
* Use an indicator-agnostic testid * Run sed * Use correct testid
-
Case Nelson authored
* Update e2e test * Update e2e test * fix: populate param-fields for named fields on public dashboards * Add name to public hydration * Add tests * Add tests * Fix tests --------- Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
Raphael Krut-Landau authored
Ensures that minimum query durations are correctly displayed in the form post-save (#44249) and that all times can be used in the Schedule component (#44257)
-
Raphael Krut-Landau authored
-
Cal Herries authored
Exclude native query matches in search scoring when the search should exclude native queries (#43982) Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
adam-james authored
* UserParameterValue transforms wrapped to properly escape string vals The `json-in` and `json-out` functions used for toucan model transforms do not perform any string escaping logic. This makes sense as we don't want to make assumptions about the shape of data flowing in/out of the db. But, this did mean that for the User paramter values table, string values were causing an error to be logged. This doesn't break anything, as the function will still correctly return the string, but it can clutter up logs. So, this PR wraps all incoming values in a map and unwraps it for outgoing values. * Add migration to wrap existing user param values with ::wrapper key Since the in/out transform for UserParameterValues is updated, we need to migrate any existing values to have this wrapping. * Simplify the solution to the problem. Since we're already getting what we need from the json-in/json-out *except* that it's logging a parse error, we can create a json-out that works the same way (tries to parse and returns the string as-is if it fails) without logging an error at all. * take away the arg and keywordize inside the json-out fn * remove irrelevant comment Signed-off-by:
Adam James <adam.vermeer2@gmail.com> * Add a little more test coverage for different value types * faster test thanks to Dan! * Add a comment about the data being tested --------- Signed-off-by:
Adam James <adam.vermeer2@gmail.com>
-
Alexander Polyankin authored
-
adam-james authored
* XLSX Pivot Table Downloads have 'Native' Pivot Table Addresses: #2473 The xlsx downloads work fine for regular tables. However, on Pivot Table downloads, the resulting file isn't pivoted and is formatted somewhat strangely (it contains additional rows related to totals, has an extra 'pivot-grouping' column). Now, the downloaded xlsx file contains 2 sheets: - the data sheet containing the question's rows unpivoted. If you were constructing a pivot table yourself, you would probably start with this shape of data. - the pivot sheet containing a 'native' Pivot table whose reference points to the data on the data sheet, and whose columns, rows, and values align with the cols, rows, and measures set up in Metabase * Silly typo! * Exported Pivot uses correct aggregation (sum, count, stddev, avg, min, max) * data for pivot exports now also uses the formatting * Add a test asserting that a pivot table exists in the xlsx file * add-row! is a method dispatching on sheet class * remove unnecessary hint * address review feedback: - consolidate the aggregation function key fns into one function in the .xlsx namespace this was moved out of postprocessing so that the xlsx specific fns don't litter the post processing namespace at this time - clean up an unnecessary destructiring inside the native-pivot function - don't shadow 'name' inside the body of a fn * Add tests that confirm zero-col and zero-row situations work * Consolidate the atoms used to store pivot rows/options
-
Alex Yarosh authored
* call attention to POST * wording
-
Nemanja Glumac authored
* Expose "Include this {period}" in timeseries chrome * Fix type errors * Simplify type guards * Add unit tests * Remove Flex wrapper around Switch * Extract `IncludeCurrentSwitch` component * Add E2E smoke tests * Cover the toggle behavior with E2E tests * Simplify test with a simple helper
-
Chris Truter authored
-
Denis Berezin authored
* Temp * Add support for saved questions * Try to fix question not found issue * Try to fix question not found issue * Fix unit tests * Add basic unit test * Fix unit tests * Fix unit tests, fix question not found issue * Review fixes * Review fixes * Refactor components structure, review fixes * Adjust readme
-
Anton Kulyk authored
* Add repro test * Fix null check
-
Braden Shepherdson authored
Fixes #43993 for real. The earlier fix #44182 was needlessly restricting the "nominal refs" check to fields which were using numeric IDs, when really any match on nominal refs is valid.
-
Braden Shepherdson authored
Part of #44298.
-
Mahatthana (Kelvin) Nomsawadi authored
-
github-automation-metabase authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Update readme pointing to newer 50 release * Update enterprise/frontend/src/embedding-sdk/README.md Co-authored-by:
Phoomparin Mano <poom@metabase.com> --------- Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
Ryan Laurie authored
* automatically add milestones to prs and issues * test code * test code * test commit (#3138) * test commit (#43320) * test commit (#44357) * remove test code * add newlines * prefer older version milestones
-
Alex Yarosh authored
* docs: change paid to pro/enterprise * Apply suggestions from code review Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Jeff Bruemmer authored
* add 50.6 to list of releases * 49.17
-
Ryan Laurie authored
-
dependabot[bot] authored
Bumps [ws](https://github.com/websockets/ws) from 7.5.9 to 7.5.10. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/compare/7.5.9...7.5.10 ) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
Uladzimir Havenchyk authored
* fix: Do not pass template variables to findColumnIndexesFromLegacyRefs * Add repro
-
Alexander Solovyov authored
Also OpenAPI generation now handles parameter renaming, like in `{c :count}` destructuring.
-
Uladzimir Havenchyk authored
-
github-automation-metabase authored
-
Kamil Mielnik authored
* Upgrade @reduxjs/toolkit from ^1.9.3 to ^2.2.5 * Fix typing * Upgrade redux-actions and @types/redux-actions * Fix type errors * Fix type errors * Upgrade react-redux from ^8.0.5 to ^9.1.2 - remove @types/react-redux as it's no-longer-needed * Upgrade redux-promise from ^0.5.0 to ^0.6.0 - upgrade @types/redux-promise * Remove unused @types/redux-logger * Revert "Upgrade redux-actions and @types/redux-actions" This reverts commit 65005a00. * Remove createWeakSelector as weakMapMemoize is the default memoization strategy now * Do not call unsubscribe if it does not exist * Do not subscribe * Remove console.log * Make DelayedLoadingSpinner always render something with data-testid="spinner" so that tests can be aware of when things are loading * Fix JoinStep unit tests * Fix AddToDashSelectDashModal unit tests * Fix SegmentApp unit tests * Bring back original subscription logic * Fix DataUsageStep unit tests * Fix ManageApiKeys unit tests * Simplify comment * Fix MainNavbar unit tests * Fix HomeRecentSection unit tests * Use afterEach instead of afterAll to reset mocks * Remove explanatory variable
-
Ngoc Khuat authored
-
Ryan Laurie authored
-
Nemanja Glumac authored
* Rename "empty" date/time filter options * Add repro for #44101
-
Oisin Coveney authored
-
- Jun 18, 2024
-
-
adam-james authored
* Pivot Tables with no Pivot Columns should still download Fixes #44159 Pivot Tables can still be valid without columns, and therefore the download should respect such a query and be successfully exported. In this PR, the postprocessing of pivot results into 'visual pivot' exports for csv takes into account the zero-column configuration and the download no longer fails. * add a test to confirm that zero cols and >1 measures works as well * Handle the case where there are zero pivot-rows. This is a similar problem to the zero pivot-cols case, just with rows. The app actually doesn't render these tables correctly, but that's a separate frontend bug
-
Benoit Vinay authored
* DWH plans added * UploadCSV button component created * Comments added * Main nav bar updates * Misc * Align main nav bar button with link * Misc comment * Upload package created * Various upload cleanup * Misc * Display button rule cleaned up * Tracking added to upload CSV button * Misc comment * e2e tests WIP * More comments * e2e tests basic created * NEw tracking schema * e2e tests updated / Tracking WIP * Analytics cleanup for button * Misc * Misc e2e tests Snowplow * Removed forced Upload CSV button in FE * Upload helpers created * Misc unit tests updates * Updated analytics * Fix for e2e tests * Upload fixture paths updated * Misc for Snowplow * Misc for plan * More tests cleanup * Misc * Source added to analytics * Plan unit tests fixed * Update frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/MainNavbarView.tsx Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> * Update frontend/src/metabase/components/upload/constants.ts Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> * Misc imports * Retrieving `uploads-settings` DB * Remove default UploadCSV component export * Misc * Button copy updated * Analytics updated with optional properties * Default upload file input id updated * csvupload schema updated * Removed before * No bad Snowplow events added --------- Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
Romeo Van Snick authored
* Add RTK endpoints for loading and searching parameters * Add Parameter API types * Move types to metabase-types * Add return type to normalizeQuery
-
Oisin Coveney authored
-
Anton Kulyk authored
* Add repro test * Fix timeline events filtering * Don't include first date of next interval
-