This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Dec 08, 2022
-
-
Aleksandr Lesnenko authored
-
Cam Saul authored
* Add import and export (SerDes v2) commands * Allow use of deprecated dump/load in EE tests
-
metamben authored
* Store DBMS version in Database * Add DBMS version to anonymous stats * Add dbms_version sync tests * Add test for DBMS versions in anonymous stats
-
Bryan Maass authored
* memoize snowflake describe-database w/ 5 min ttl * pass in db-metadata where it is used, - rather than querying for it in random functions * update callsite of sync-tables-and-database! * let sync-metabase-metadata! look up db-metadata - only when needed * pass catalog (db), and schema to .getPrimaryKeys * let describe-table* add in the nil table-name * cleanup * use :snowflake instead of driver for inheritance * concurrent-sync-test should call describe-database once * cleaning up * call add-table-pks with 3 args * call add-table-pks with 3 args * try escaping entity names to appease Oracle Driver - Oracle wants the table-name to be escaped - escape is usually a no-op * pass driver to escape entity * pull get-table-pks into a multimethod, - handle the discrepancy directly in Oracle driver * remove inline def * fix colliding consistent-namespace linting - metabase.driver.sql-jdbc.common and metabase.driver.sql-jdbc.sync.common were mapped to sql-jdbc.common - metabase.driver.sql-jdbc.sync.common is now mapped to sql-jdbc.sync.common * fix reflection warnings * apply fix for getting oracle pks * nix an unused arg
-
metamben authored
* Fingerprint bigquery by previewing tables * Address review comments
-
Nemanja Glumac authored
-
Cam Saul authored
* MongoDB test data config should not hardcode the user and password we use in CI * Minor test data interface dox improvements * Support standard deviation and variance for MongoDB * Oops I got :expressions mixed up with :expression-aggregations * Note about calculating variance * `connection-type` instead of `db-or-server`
-
Mahatthana (Kelvin) Nomsawadi authored
* Upgrade `react-markdown` version to the latest * Fix external link in markdown not having a proper target * Add tests
-
Ariya Hidayat authored
-
Ngoc Khuat authored
-
Nemanja Glumac authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Hide side bar toggle when appropriate * Show collection breadcrumbs by default * Address review: Simplifying the code. * Address review: Cleanup boolean names * Fix Cypress test failure after behavior change * Rename some boolean flag to avoid confusion * Add embedding tests
-
Cal Herries authored
* Remove hard-coded drivers from datetime-diff-type-test * Add requirement for set-timezone for datetime-time-zones-test * Add sqlserver implementation * Change datetime-diff-time-zones-test to test drivers that don't support set-timezone * Refactor * Temporarily remove snowflake from datetime-diff-type-test
-
Cal Herries authored
-
Cal Herries authored
* Add redshift implementation * Add failing tests * Fix bigquery * Formatting * fix? set-param for redshift * Replace literals for datetime-diff-time-zones-test * Actually use fields * Fix typo * Rename dataset * Add type/DateTimeWithTZ column, since redshift doesn't like type/DateTimeWithZoneOffset * Cast to timestamp for week diff * Revert "fix? set-param for redshift" This reverts commit 235f3aca2a4b3bf41469d7bb73266d3f5e54f5d2. * Fix leap years * Remove redundant date-trunc * Formatting * Fix mismatched types * Fix extract * Add comment for why redshift needs an implementation Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
Cal Herries authored
* vertica datetime-diff implementation * Don't need type info * Refactor implementation * Fix seconds * Cast to timestamp before comparison * Fix set-parameter for vertica * formatting * Sort ns * Remove set-parameter changes * Replace literals for datetime-diff-time-zones-test * Fix requires * Actually use fields * Fix typo * Rename dataset * Add type/DateTimeWithTZ column, since redshift doesn't like type/DateTimeWithZoneOffset * Add failing tests * Fix bigquery * Formatting * Fix mismatched types
-
- Dec 07, 2022
-
-
dpsutton authored
* Fix numeric parameter values in jwt Don't call `seq` on numbers. If its a string, assert it isn't blank, otherwise check that it is non-null. * bind (:value request-param)
-
dpsutton authored
* Fix flaky `remap-human-readable-string-column-test` Quite annoying test that would flake quite a bit in CI. the problem is that the mechanism for `mt/with-column-remappings` wasn't aware of the case when there were pre-existing mappings. It just blindly added a new mapping. But when the middleware fetching the remappings, it found the preexisting ones. For the venue.name field in this test, that was ("20th Century Cafe","25°","33 Taps","800 Degrees Neapolitan Pizzeria", ...). We were passing in fake names like "apple", "banana", "kiwi" and it found no remappings for those in the db. So the fix is to check for pre-existing ones, and if found, use `tu/with-temp-vals-in-db` to temporarily set them to the desired values, otherwise use some new ones with `tt/with-temp*` as it was doing previously. * log errors for CI * Only use type :full field values when remapping we store cached chained filter values in here (with type :linked-filter, there are also type :sandbox in there) but the :full are the ones that are used for remapping. In the tests, if the chain link tests have already run, there can be 6 field values for the field here (`(mt/id :venues :name)`) and we want to make sure we update the full one, not the chain filter ones ```clojure [{:hash_key "576275248", :has_more_values false, :last_used_at #t "2022-12-07T21:08:35.592931Z", :type :linked-filter, :updated_at #t "2022-12-07T21:10:22.972907Z", :human_readable_values ("Appletini" "Bananasplit" "Kiwi-flavored Thing"), ;; the test updatedthe existing :linked-filter one :id 560, :values ("apple" "banana" "kiwi"), :field_id 15, :created_at #t "2022-12-07T21:08:35.592931Z"} {:hash_key "-897793959", :has_more_values false, :last_used_at #t "2022-12-07T21:08:35.695344Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:35.695344Z", :human_readable_values [], :id 564, :values ("Kinaree Thai Bistro" "Krua Siri"), :field_id 15, :created_at #t "2022-12-07T21:08:35.695344Z"} {:hash_key "388078290", :has_more_values false, :last_used_at #t "2022-12-07T21:08:35.742561Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:35.742561Z", :human_readable_values [], :id 566, :values ("Tacos Villa Corona" "Tito's Tacos"), :field_id 15, :created_at #t "2022-12-07T21:08:35.742561Z"} {:hash_key "-299897589", :has_more_values false, :last_used_at #t "2022-12-07T21:08:35.777517Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:35.777517Z", :human_readable_values [], :id 567, :values ("Festa" "Fred 62"), :field_id 15, :created_at #t "2022-12-07T21:08:35.777517Z"} {:hash_key "-391654650", :has_more_values false, :last_used_at #t "2022-12-07T21:08:36.681046Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:36.681046Z", :human_readable_values [], :id 569, :values ("Baby Blues BBQ" "Beachwood BBQ & Brewing" "Bludso's BBQ"), :field_id 15, :created_at #t "2022-12-07T21:08:36.681046Z"} {:hash_key "1784886858", :has_more_values false, :last_used_at #t "2022-12-07T21:08:36.860010Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:36.860010Z", :human_readable_values [], :id 572, :values ("Baby Blues BBQ" "Beachwood BBQ & Brewing" "Bludso's BBQ"), :field_id 15, :created_at #t "2022-12-07T21:08:36.860010Z"} {:hash_key nil, :has_more_values false, :last_used_at #t "2022-12-07T21:04:04.299251Z", :type :full, ;; but should have updated this one :updated_at #t "2022-12-07T21:04:04.299251Z", :human_readable_values [], :id 4, :values ("20th Century Cafe" "25°" "33 Taps" "800 Degrees Neapolitan Pizzeria" "BCD Tofu House"), :field_id 15, :created_at #t "2022-12-07T20:57:21.896298Z"}] ``` * remove CI logging
-
Natalie authored
-
Case Nelson authored
Resolves #16132 We have been simplifying $expr operations for [awhile](https://github.com/metabase/metabase/blob/8e989499e936c04000b13a88f4934e96692083a2/modules/drivers/mongo/src/metabase/driver/mongo/query_processor.clj#L571-L588), since at least 4fba5cfe. It's possible that there are some cases that we do not simplify that we should, but from this investigation, they seem like legit uses remaining.
-
Natalie authored
-
Luiz Arakaki authored
* review athena manifest * review case and add helper text * add better helper text to AWS Credentials Provider Chain * fix capitalization * add helper text to password too * Update modules/drivers/athena/resources/metabase-plugin.yaml Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Jeff Bruemmer authored
-
Aleksandr Lesnenko authored
* remove TextInput and use core/Input * review
-
Cal Herries authored
* Add snowflake datetime-diff implementation * Get timestamps without timezones or offsets working * Convert to timestamp_tz, not timestamp * Format rows in tests * Fix snowflake set-parameter * Add failing tests * Fix bigquery * Formatting * Replace literals for datetime-diff-time-zones-test * Revert "Fix snowflake set-parameter" This reverts commit c24348a436f3f0f2639a12d6ea368399d1549739. * Actually use fields * Fix typo * Rename dataset * Add type/DateTimeWithTZ column, since redshift doesn't like type/DateTimeWithZoneOffset * Fix snowflake for time zones * Undo changes to extract and date-trunc * Explicitly set UTC timezone * Fix mismatched types * Remove redundant bindings * Remove redundant comment * Add failing tests * Remove duplicate dataset
-
- Dec 06, 2022
-
-
Cam Saul authored
-
Nick Fitzpatrick authored
* Change hasBreakout check * Adding computedSettings prop to ChartSettings
-
Case Nelson authored
* Disable field value scanning for inactive fields Fixes #26863 Adds `last-used-at` to `metabase_fieldvalues` table. This is used to track when full FieldValues are fetched, which should always happen through `get-or-create-full-field-values!` If an inactive FieldValues is queried, they will be updated immediately to be returned to the user and a new last-used-at will be set so that sync will start picking it up. During field values sync, if `last-used-at` occurred more than 14 days ago, then we will no longer query and synchronize this field until it is queried for again. * Fix flaky test by waiting half a second for last-used-at to change * Updates from review * Remove flakiness from test by checking sync
-
Nemanja Glumac authored
* [Docs] Fix external broken link * Link to the Cypress intro page without anchors * Exclude Cypress links from checks all together * Add back `.html` extension to the link
-
Ariya Hidayat authored
-
Braden Shepherdson authored
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Ngoc Khuat authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
-
Anton Kulyk authored
* Add `SnippetCollectionForm` * Add `SnippetCollectionFormModal` * Use new form * Remove old form * Clean up snippet collections entity * Fix submit button title * Fix initial values
-
Anton Kulyk authored
* Add `NativeQuerySnippet` type * Add `NativeQuerySnippet` mocks * Add `snippets` to entities store type * Add `SnippetCollectionName` component * Support snippet folders in `FormCollectionPicker` * Add `SnippetForm` * Add `SnippetFormModal` * Use new `SnippetFormModal` * Remove `SnippetModal` * Fix initial values formatting * Ensure errors are displayed * Simplify archive button * Remove commented out code * Detach entity loader props from own props * Add unit tests * Fix test names * Fix modal props usage * Use `NativeQuerySnippetId` type * Make description field nullable * Fix `FormTextArea` styling
-
Ngoc Khuat authored
-
Cal Herries authored
* Add failing tests * Fix bigquery * Formatting
-