This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 13, 2024
-
-
Oisin Coveney authored
Co-authored-by:
Tim Macdonald <tim@metabase.com>
-
Jeff Bruemmer authored
This reverts commit 9413706b.
-
Romeo Van Snick authored
* Add reproduction for spaces breaking the search in filter pickers * Search using display name too * Search using display name in summarize picker
-
Alexander Polyankin authored
-
Ngoc Khuat authored
-
Cal Herries authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
* v1 * v1 * v1 * Move sync code * Small refactor
-
Kamil Mielnik authored
Repro #29943 - Wrong field highlighted when editing model metadata if custom column added to left of column (#39996) * Repro #29943 - Wrong field highlighted when editing model metadata if custom column added to left of column * Refactor assertions * Reuse getHeaderCell
-
- Mar 12, 2024
-
-
Ngoc Khuat authored
-
Braden Shepherdson authored
This matches how models are visualized, and how the parameters are attached to them in the first place - an extra ad-hoc query is wrapped around the model. Because of that wrapping, a parameter will be targeting a model's field by name rather than by ID, but that parameter cannot be applied directly on the model's last stage. Fixes #39940.
-
Noah Moss authored
-
bryan authored
* move log-enabled? into premium-features * only `record-views!` when `log-enabled?` * test that view-log entries arent created in oss * simplify test * fix new test fails: we don't log views in OSS. * fix 3 more view logging tests (they dont do anything in oss) * fix dashboard-read-ee-test - check for `log-enabled?` not `ee-available?` * fix the rest of the tests - Only check for view logs when (premium-features/log-enabled?) is falsey * adjusting e2e test --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
adam-james authored
* Add issue number to todos in models.card * Add issue number to todos in models.pulse * Add issue number to todos in models.dashboard-card
-
Braden Shepherdson authored
Fixes #39657.
-
Jesse Devaney authored
-
Vamsi Peri authored
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Cal Herries authored
-
Jeff Bruemmer authored
-
Nicolò Pretto authored
* setup e2e with token activation * add assertion that the step is actually present
-
Romeo Van Snick authored
* Detect the use of unsupported features in the expression editor * Use an object to pass parameters to resolve * Handle clauses that do not require feature * Use postgres-12 for testing datetime functions
-
Ngoc Khuat authored
Co-authored-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
Noah Moss <noahbmoss@gmail.com>
-
Ngoc Khuat authored
-
Romeo Van Snick authored
* Convert QueryVisualization to a functional component * Add a custom message after loading for a while * Add test for slow database message * Loop through different custom messages * Use cy.clock to test timeouts * Make getLoadingMessage a function
-
Cal Herries authored
-
- Mar 11, 2024
-
-
Ngoc Khuat authored
-
Braden Shepherdson authored
This includes some generative testing, since that felt like a great way to try all kinds of permutations of swapping clauses. This also patches `metabase.types/assignable?` to memoize it. Deeply nested `assignable?` calls made 100 tests of swapping filters take 1600ms rather than the 50-60ms of the other clauses. I think this is safe and reasonable on memory to cache forever, but speak up if you're concerned. There's perhaps O(60) type keywords, so `type X type -> Boolean` is a small space impact. Fixes #39215.
-
Case Nelson authored
* [Metrics V2] query processor phase 1 * Use :sources drop and :metric-dimensions for now * Fix tests, address review comments * Fix as bug
-
Cam Saul authored
* Keep fetch_source_query.clj * Copy fetch_source_query.clj into fetch_source_query_legacy.clj * Set back fetch_source_query.clj file * Convert QP to MLv2, part 1 * Keep legacy implementation around for time being * Port thru convert-to-legacy * expand-macros is converted to legacy * Test fixes
* Test fixes and better keys * Test fixes * Test fixes * More test fixes * Test fix? * Wow, maybe I finally fixed everything * Last few test fixes * PR feedback; lib.walk should support splicing in multiple replacement stages * Update fetch-source-query to use improved lib.walk * Have I fixed everything now? * Remove stray println * Another MongoDB fix * Convert QP to MLv2 Part 2 * Remove most of the fetch-source-query-legacy stuff * Remove the changes to expand-macros for now, we can do that in a follow-on PR. * Test fix * Test fix * TEST FIXES?! * Kondo & test fixes * Oops, make sure we have the updated tests * Fixes * Test fixes * Convert resolve-source-table * Appease Kondo * Unparallelize the tests * Another test that shouldn't be parallel * Make tests more robust * Test fixes -
lbrdnk authored
* Update expression-parts to satisfy filter picker * Address review remarks and implement to-range for quarter * Add coercion check to extensibility condition * Make coerce-to-timestamp return nil for uncoercible arg value
-
Noah Moss authored
-
dpsutton authored
* first move to a db api * mdb.spec into mdb * mdb.u/isa -> mdb.query/isa * mdb.u/qualify -> mdb.query/qualify * last of mbql.u -> mbql.query and
mbql.u * remove last of the mdb.connection/db-type and use from mdb/db-type * remove the last non-cmd usages of mdb.connection had some circularity in models.interface requires mdb/db-type for sql flavored "now" mdb requires db/setup which requires db/custom_migrations to ensure they are on cp custom migration requires json functions in models.interface so had to do a dynamic require for the db-type * get db-type from mdb not mdb.env * invoke `(mdb/app-db)` and not pass a var. lots of things fail * mdb.setup/migrate! into mdb with potemkin * remove get-connection. call .getConnection on the app-db perhaps invites clumsy usage outside of `with-open` if it's a top level function * namespace docstrings * last few and grab db.env/db-file into api ns * lint cleanup * addresses PR comments -
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Anton Kulyk authored
* Fix card summarize endpoint * Fix "AI features" setting section visibility * Add setting * Use `ee-ai-features-enabled` setting * Add test for new LLM defsetting. Add note in settings UI --------- Co-authored-by:
Adam James <adam.vermeer2@gmail.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
Romeo Van Snick authored
* Allow hiding empty TableInfoIcons * Hide info icon if it is empty in header * Do not show info icon on subheader * Replace hideIfEmpty for showIfEmpty
-
Ryan Laurie authored
* Add metabase user id to log lines * add modal to select error data to include * trigger on global keyboard shortcut --------- Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
Tim Macdonald authored
-