Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 13, 2024
  2. Mar 12, 2024
  3. Mar 11, 2024
    • Ngoc Khuat's avatar
    • Braden Shepherdson's avatar
      [MLv2] Introduce `swap-clauses` to reorder aggregations, etc. (#39850) · 796256c5
      Braden Shepherdson authored
      This includes some generative testing, since that felt like
      a great way to try all kinds of permutations of swapping clauses.
      
      This also patches `metabase.types/assignable?` to memoize it.
      Deeply nested `assignable?` calls made 100 tests of swapping
      filters take 1600ms rather than the 50-60ms of the other clauses.
      
      I think this is safe and reasonable on memory to cache forever,
      but speak up if you're concerned. There's perhaps O(60) type
      keywords, so `type X type -> Boolean` is a small space impact.
      
      Fixes #39215.
      Unverified
      796256c5
    • Case Nelson's avatar
      [Metrics V2] query processor phase 1 (#39955) · 7a5912e1
      Case Nelson authored
      * [Metrics V2] query processor phase 1
      
      * Use :sources drop and :metric-dimensions for now
      
      * Fix tests, address review comments
      
      * Fix as bug
      Unverified
      7a5912e1
    • Cam Saul's avatar
      Convert QP to MLv2 Part 2 (#39824) · 5bbc0aa7
      Cam Saul authored
      * Keep fetch_source_query.clj
      
      * Copy fetch_source_query.clj into fetch_source_query_legacy.clj
      
      * Set back fetch_source_query.clj file
      
      * Convert QP to MLv2, part 1
      
      * Keep legacy implementation around for time being
      
      * Port thru convert-to-legacy
      
      * expand-macros is converted to legacy
      
      * Test fixes :wrench:
      
      * Test fixes and better keys
      
      * Test fixes
      
      * Test fixes :wrench:
      
      * More test fixes :wrench:
      
      * Test fix? :wrench:
      
      * Wow, maybe I finally fixed everything :wrench:
      
      * Last few test fixes :wrench:
      
      * PR feedback; lib.walk should support splicing in multiple replacement stages
      
      * Update fetch-source-query to use improved lib.walk
      
      * Have I fixed everything now? :wrench:
      
      * Remove stray println
      
      * Another MongoDB fix :wrench:
      
      * Convert QP to MLv2 Part 2
      
      * Remove most of the fetch-source-query-legacy stuff
      
      * Remove the changes to expand-macros for now, we can do that in a follow-on PR.
      
      * Test fix
      
      * Test fix
      
      * TEST FIXES?! :wrench:
      
      * Kondo & test fixes
      
      * Oops, make sure we have the updated tests
      
      * Fixes :wrench:
      
      * Test fixes :wrench:
      
      * Convert resolve-source-table
      
      * Appease Kondo
      
      * Unparallelize the tests
      
      * Another test that shouldn't be parallel
      
      * Make tests more robust
      
      * Test fixes :wrench:
      Unverified
      5bbc0aa7
    • lbrdnk's avatar
      Update expression-parts to satisfy filter picker (#39650) · 0dc04853
      lbrdnk authored
      * Update expression-parts to satisfy filter picker
      
      * Address review remarks and implement to-range for quarter
      
      * Add coercion check to extensibility condition
      
      * Make coerce-to-timestamp return nil for uncoercible arg value
      Unverified
      0dc04853
    • Noah Moss's avatar
      Clean up unused perms code (#39875) · 8c279277
      Noah Moss authored
      Unverified
      8c279277
    • dpsutton's avatar
      Db api (#39731) · 1e7823d1
      dpsutton authored
      * first move to a db api
      
      * mdb.spec into mdb
      
      * mdb.u/isa -> mdb.query/isa
      
      * mdb.u/qualify -> mdb.query/qualify
      
      * last of mbql.u -> mbql.query and :gun:mbql.u:sparkler:
      
      * remove last of the mdb.connection/db-type and use from mdb/db-type
      
      * remove the last non-cmd usages of mdb.connection
      
      had some circularity in
      
      models.interface requires mdb/db-type for sql flavored "now"
      mdb requires db/setup
      which requires db/custom_migrations to ensure they are on cp
      custom migration requires json functions in models.interface
      
      so had to do a dynamic require for the db-type
      
      * get db-type from mdb not mdb.env
      
      * invoke `(mdb/app-db)` and not pass a var. lots of things fail
      
      * mdb.setup/migrate! into mdb with potemkin
      
      * remove get-connection. call .getConnection on the app-db
      
      perhaps invites clumsy usage outside of `with-open` if it's a top level
      function
      
      * namespace docstrings
      
      * last few and grab db.env/db-file into api ns
      
      * lint cleanup
      
      * addresses PR comments
      Unverified
      1e7823d1
    • Jeff Bruemmer's avatar
      Unverified
      41aed8c3
    • Jeff Bruemmer's avatar
      add embedding step (#39790) · 6966d201
      Jeff Bruemmer authored
      Unverified
      6966d201
    • Anton Kulyk's avatar
      Fixes for LLM auto-description (#39858) · a16b4d5c
      Anton Kulyk authored
      
      * Fix card summarize endpoint
      
      * Fix "AI features" setting section visibility
      
      * Add  setting
      
      * Use `ee-ai-features-enabled` setting
      
      * Add test for new LLM defsetting. Add note in settings UI
      
      ---------
      
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      Unverified
      a16b4d5c
    • Romeo Van Snick's avatar
      Remove info icon on table (#39853) · a1e31348
      Romeo Van Snick authored
      * Allow hiding empty TableInfoIcons
      
      * Hide info icon if it is empty in header
      
      * Do not show info icon on subheader
      
      * Replace hideIfEmpty for showIfEmpty
      Unverified
      a1e31348
    • Ryan Laurie's avatar
      Diagnostic Information Modal (#39817) · aed35c65
      Ryan Laurie authored
      
      * Add metabase user id to log lines
      * add modal to select error data to include
      * trigger on global keyboard shortcut
      ---------
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
      Unverified
      aed35c65
    • Tim Macdonald's avatar
Loading