This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 10, 2023
-
-
Ngoc Khuat authored
-
Cal Herries authored
* Create select-action * Rename to select-actions * Remove comments * Remove unnecessary () * Missed one * Fix GET /action/:uuid * Use new fns more * Fix * Remove select-action-without-implicit-params, we don't need it
-
Cam Saul authored
* Enable Kondo `:warn-on-reflection` linter * Enable warnings for metabase.api.setting-test * Add warn-on-reflection to metabase.util.jvm
-
Braden Shepherdson authored
Some JVM-specific functions are now in `metabase.util.jvm`, but they are re-exported (in CLJ) by `metabase.util`.
-
- Feb 09, 2023
-
-
Noah Moss authored
Make sure we're using a user's full list of permission groups when determining whether a sandbox should be enforced (#28198) * make sure we're using the full group list when checking whether a sandbox should be enforced * add simple test that would have caught this bug
-
dpsutton authored
https://github.com/camsaul/toucan2/pull/126 Editing the data model loads a _lot_ of data. It hits the following form from the api: ```clojure (hydrate [:tables [:fields [:target :has_field_values] :has_field_values] :segments :metrics]) ``` On my test instances, with 1500 tables each with 14 fields: 15mb and 359 tables each with 14 fields: 3.69mb. Not great. If you want to recreate, create an empty db, sync it, then ```clojure (time (let [conn (sql-jdbc.conn/db->pooled-connection-spec 3)] (dotimes [n 359] (jdbc/execute! conn [(format "create table if not exists foo_%d (id int, col_1 text, col_2 text, col_3 text, col_4 text, col_5 text, col_6 text, col_7 text, col_8 text, col_9 text, col_10 text, col_11 text, col_12 text, col_13 text, col_14 text)" n)])))) (sync/sync-database! (db/select-one 'Database :id 3) {:scan :schema}) (binding [api/*current-user-permissions-set* (delay #{"/"})] (count (#'metabase.api.database/db-metadata 3 true true))) ``` And the source of the bug was a classic recur with a lazy concat. ```diff diff --git a/src/toucan2/tools/hydrate.clj b/src/toucan2/tools/hydrate.clj index e1d0459..10c9c49 100644 --- a/src/toucan2/tools/hydrate.clj +++ b/src/toucan2/tools/hydrate.clj @@ -456,7 +456,7 @@ (if (empty? hydrated-instances) (concat acc (map :instance annotated-instances)) (let [[not-hydrated [_needed-hydration & more]] (split-with (complement :needs-hydration?) annotated-instances)] - (recur (concat acc (map :instance not-hydrated) [(first hydrated-instances)]) + (recur (vec (concat acc (map :instance not-hydrated) [(first hydrated-instances)])) more (rest hydrated-instances)))))) ```
-
Aleksandr Lesnenko authored
-
Ryan Laurie authored
* support executing actions in public dashboards * fix conflict with public actions
-
Cam Saul authored
-
Case Nelson authored
-
Nemanja Glumac authored
-
Noah Moss authored
* allow untranslated setting descriptions in tests * tweaks
-
Ngoc Khuat authored
-
Mark Bastian authored
Upgrade to Jetty 11 via https://github.com/sunng87/ring-jetty9-adapter. Required updating from javax servlet packages to jakarta, since jakarta is newer.
-
Alexander Polyankin authored
-
Nemanja Glumac authored
[ci skip]
-
Nemanja Glumac authored
[ci skip]
-
- Feb 08, 2023
-
-
Case Nelson authored
* Adding support for timezone awareness to mongo * Remove unused ddl multimethod * Remove mongo from the sql driver type test * Fix tests and linters * Add test for filtering datetimes by date in timezone * Use test-data-with-timezones dataset as it should load in more dbs * Exclude broken drivers, vertica especially returns no rows * Address pr review, add timezone to isodate, include a full year of dates in the general timezone test * Assert against each row * Presto-jdbc year was not applying timezone
-
Aleksandr Lesnenko authored
-
Braden Shepherdson authored
This is needed with the move to `deps.edn` for tracking all dependencies, since it makes shadow-cljs rely on the `clojure` binary.
-
Tim Macdonald authored
-
Braden Shepherdson authored
Includes much-improved testing for the logger in CLJ and CLJS. **This moves us from explicit `shadow-cljs.edn` dependencies to relying on deps.edn for everything. It seems to be working nicely.
-
Alexander Polyankin authored
-
Ngoc Khuat authored
-
Cam Saul authored
-
- Feb 07, 2023
-
-
Braden Shepherdson authored
This has the same interface as `clojure.tools.logging` but supports CLJS as well. It was formerly known as `metabase.shared.util.log`.
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Kyle Doherty authored
* fix hover behavior on collection item table names * make sure name click target fits cell height
-
Alexander Polyankin authored
-
Bryan Maass authored
* handle nil return schemas for docstring gen * adds more mu/defn docstring generation tests
-
Aleksandr Lesnenko authored
-
Jeff Bruemmer authored
-
Anton Kulyk authored
* Add tests for `Navbar` * Add tests for `MainNavbar` * Highlight model collection while on the detail page * Extract path checks into functions * Add dashboard server mocks * Use entity loaders instead of redux selectors * Revert to `getDashboard` selector
-
Mahatthana (Kelvin) Nomsawadi authored
* Suppress console error on CopyWidget * Remove old component lifecycle deprecation warning from a library * Fix inconsistent modal transition * Fix ESLint error
-
Anton Kulyk authored
* Add `is_saved_questions` to database type * Support saved questions DB in db endpoint mocks * Add tests * Show questions section only when there are questions * Move `SAVED_QUESTIONS_DB` to `databases/constants`
-
Ngoc Khuat authored
-
Cal Herries authored
* Whitespace * Add Action to entities list * Add entity_id column migration * Correct migration ids * Add entity-id property to action model * Extract and serdes-dependencies for action * storage for Action * ingest for Action * Generate for Action * load for Action * Remove comment * Add entity_id to action submodels * Add submodels to copy entities * Add submodels to exported-models * Add submodels to legal-top-level-paths * Slufigy extracted label for action * Extract for QueryAction * Generate query_action * Fix query_action extract test * Add action subtype extract tests * Update Action-subtype-IModel-impl docstring * Generate ImplicitAction and HTTPAction * Export and Import action_id FK with dashcards * Generate nano-id * Add load tests to e2e test * Nest subtypes directories in actions * Remove prn * Add docstring * Fix copy * Add select-action fn * Change extract tests to only extract Action model * Update action/select-one tests * Update legal-top-level-paths * Rename select-action -> select-one * Implement extract-one for Action only, not subtypes * Move subtype models from exported to inlined * Remove entity_id from subtypes * Reuse type->model * Ingest Action with inlined subtype info * Fix serdes-dependencies for Action * Add action to serdes-descendants for Dashboard * Add docstring to action update! * Reuse update! for PUT API * Add missing ns * Remove serdes-generate-path impl * Tidy * Sort ns * Restore add-entity-id * Update entity_id_test * Undo refactor * Include id in action arg for update! * Delete action, with delete cascading to the subtype * Fix clj-kondo warning * Fix returning nil Action in dashboard serdes-descendants * Braden's suggestions
-
Anton Kulyk authored
-