Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 20, 2024
    • Phoomparin Mano's avatar
      feat(sdk): revamp CreateQuestion and create question behaviour (#50088) · 5fb95767
      Phoomparin Mano authored
      * revamp the create question component
      
      * docs updates
      
      * add stories and update styles
      
      * prevent switching to visualization when it is not ready
      
      * ensure CreateQuestion works in flex parents
      
      * add basic e2e tests for CreateQuestion
      
      * ensure that switching between editor and visualization works
      
      * use the save button for the disabled state
      
      * update the question title when the question is saved
      
      * implement updating questions in place
      
      * rename replaceQuestion
      
      * make CreateQuestion props all optional
      
      * add background color to modal header
      
      * hide the save button if question is dirty
      
      * hide save button instead of disabling per design feedback
      
      * update e2e tests
      
      * revert e2e helpers
      
      * add title update assertions
      
      * whitespace changes
      5fb95767
  2. Nov 19, 2024
  3. Nov 04, 2024
    • Phoomparin Mano's avatar
      feat(sdk): ability to enforce the destination collection to save to and hide... · de559f49
      Phoomparin Mano authored
      feat(sdk): ability to enforce the destination collection to save to and hide the collection picker (#49251)
      
      * add ability to hide the collection picker
      
      * add save options
      
      * make sure collectionId is fresh
      
      * update sdk question form component
      
      * make collectionId accept null
      
      * apply saveOptions to sdk components
      
      * revert to use initialCollectionId as context name
      
      * target the correct collection id
      
      * add e2e tests
      
      * update e2e tests
      
      * move into within
      
      * update test
      
      * remove collectionId from default args
      
      * revert e2e of hide columns
      
      * make e2e helper more generic
      
      * use saveToCollectionId prop to save to a specific collection
      
      * update e2e tests
      
      * update comment formatting
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      
      * clean up leftover changes from an earlier version
      
      * readme update
      
      * indicate that saveToCollectionId is only applicable to static questions
      
      * revert QuestionEditor.isSaveEnabled defaults
      
      * update comment format
      
      * remove unused initialCollectionId prop
      
      * experiment: try to fix failing custom-columns e2e
      
      ---------
      
      Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
      de559f49
  4. Sep 25, 2024
  5. Sep 06, 2024
  6. Sep 03, 2024
  7. Sep 02, 2024
  8. Aug 21, 2024
  9. Aug 20, 2024
  10. Aug 16, 2024
  11. Aug 14, 2024
    • Phoomparin Mano's avatar
      fix(sdk): optimistic update query builder and update questions in notebook (#46652) · 3df927c9
      Phoomparin Mano authored
      
      * update question state
      
      * update question state
      
      * reload metadata for runQuestionOnNavigate
      
      * fix runnable queries
      
      * fix cannot run question
      
      * extract question predicate functions to question.ts
      
      * update types
      
      * create utils subfolder for query builder
      
      * fix query builder predicate imports
      
      * naming tweaks to be more self-explanatory
      
      * document the non-intuitive loadQuestion useEffect
      
      * change imports to support metric
      
      * remove unused import
      
      * revert originalQuestion check to try to fix e2e failures
      
      ---------
      
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
      3df927c9
  12. Aug 12, 2024
  13. Jul 11, 2024
    • Phoomparin Mano's avatar
      feat(sdk): support multiple interactive questions by decoupling from query builder reducer (#45133) · 49926e68
      Phoomparin Mano authored
      * create sdk load question
      
      * store question result in sdk context
      
      * remove dataset data type
      
      * update question
      
      * handle navigate to new card
      
      * add loading states
      
      * fix on query change
      
      * update question change logic
      
      * refactor question loading and query params
      
      * fix ad-hoc question in dashboards
      
      * extract useLoadQuestion into a separate hook
      
      * cleanup run question on load
      
      * revert changes in interactive question component
      
      * store original question in the question result state
      
      * turn the question into ad-hoc questions
      
      * refactor run question methods
      
      * add a separate isQueryRunning state for better ux
      
      * isQueryRunning should default to false
      
      * simulate re-running the query in unit tests
      
      * add tests for rendering multiple valid questions
      
      * refactor sync question method
      
      * extract raw series and computed pivot logic
      
      * add getCardAfterVisualizationClick
      
      * separate single and multiple question tests
      
      * fix import paths
      
      * is question native
      
      * pass queryResult instead of queryResults
      
      * temporarily remove checkNotNull for aggregation picker to avoid sdk crash
      49926e68
  14. Jul 01, 2024
  15. Jun 28, 2024
  16. Jun 27, 2024
Loading