Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 05, 2021
  2. May 03, 2021
    • Nemanja Glumac's avatar
      Merge e2e CI improvements from the `release-x.39.x` branch (#15907) · d83cd8f0
      Nemanja Glumac authored
      * Improve Cypress runner command line config (#15854)
      
      * Rename Cypress CI groups to `e2e-tests` (#15877)
      
      * Remove the `node` parameter from Cypress CI job matrix (#15878)
      
      * Merge EE Cypress tests with the OSS ones (#15887)
      
      * Reorganize test folder: Move e2e support files into a separate folder (#15899)
      
      * Refine CI checksum calculation - extract e2e files (#15900)
      Unverified
      d83cd8f0
  3. Apr 30, 2021
  4. Apr 28, 2021
  5. Apr 21, 2021
  6. Apr 19, 2021
  7. Apr 15, 2021
  8. Apr 13, 2021
  9. Apr 01, 2021
  10. Mar 31, 2021
    • Cam Saul's avatar
      Fix SAML redirect to with certain URLs e.g. /collection/root (#15410) · 18d1e9cf
      Cam Saul authored
      * Fix SAML redirect to /collection/root/
      
      * Test util HTTP client should automatically URL-encode query parameters.
      
      * Simplify HTTP client
      
      * Minor tweaks
      
      * Remove *url-encode-query-parameters?*
      
      * experimental CI fix: cache build script deps
      
      * Fix typo
      
      * Fix Circle config again
      
      * Fetch BE deps if deps.edn files change
      
      * Use CI executor for be-deps, so we have the Clojure CLI
      Unverified
      18d1e9cf
    • Jeff Evans's avatar
      Fix Oracle SSL tests (#15260) · c938fb05
      Jeff Evans authored
      Fix Oracle SSL tests
      
      Define new test for Oracle SSL connectivity, in oracle_test.clj, similar to how things work in mysql_test.clj
      
      Add new test util macro, with-env-keys-renamed-by, to support running tests with environ keys temporarily renamed
      
      Using new test macro from both MySQL and Oracle SSL connectivity tests
      
      Removing now unneeded be-tests-oracle-ssl-ee CircleCI job
      
      Removing now unneeded test-selector parameter for test-driver orb in CircleCI config.yml
      
      Updating JVM_OPTS to use a trust store that starts with cacerts and adds the RDS root CA, rather than one only
      containing the RDS root CA
      Unverified
      c938fb05
  11. Mar 24, 2021
    • Jeff Evans's avatar
      Support SSL server certificate parameter for MySQL (#15172) · 54f6a5e7
      Jeff Evans authored
      Adding ssl-cert config field to MySQL DB details map, to hold the server cert chain in PEM format (similar to what is done in MongoDB driver)
      
      Updating MySQL driver init to map :ssl-cert into :serverSslCert for the JDBC url, when ssl is in use and cert is provided (the MariaDB driver we are using accepts PEM format certificates inline directly for the param value, so no need to shepherd into a temp file)
      
      Adding new test to mysql_test.clj to run a single test while connecting via SSL with PEM cert
      
      Update CircleCI config:
       - use extra-env to set all the MySQL SSL instance DB related vars (for an RDS instance, currently)
       - adding the rds-combined-ca-bundle.pem certificate to resources/certificates
       - loading that cert bundle from resources directory via env var
      
      Adding to/fixing assertion in connection-spec-test for :ssl
      Unverified
      54f6a5e7
  12. Mar 23, 2021
  13. Mar 17, 2021
  14. Mar 12, 2021
    • Ariya Hidayat's avatar
    • Robert Roland's avatar
      Clean up sync scheduling (#15043) · 6668b4ee
      Robert Roland authored
      It's possible for the scheduler to get in a weird state if the sync
      fails while it executes.
      
      This change makes it *only* recreate a job/task if the schedule has
      changed or if it is missing. Previously, clearing the state at every
      start had bad effects if the JVM had terminated during the sync.
      
      Adds a vector of Exception classes that signal a "fatal" exception
      during sync for a specific database. If these exceptions occur, the sync
      for that database stops and will pick up next time.
      
      This will have to be expanded per driver, but I don't see a way around
      that, as each driver will have its own, unique way of failing.
      
      metabase/metabase#14817
      Unverified
      6668b4ee
  15. Mar 11, 2021
    • Jeff Evans's avatar
      Add support for connecting to Oracle with SSL (#15078) · 7b24bc98
      Jeff Evans authored
      Update Oracle driver to have the `ssl` (boolean) option, with the expectation that any keystore/truststore params have been set as JVM parameters
      
      Updating CircleCI config to allow for the following parameters to the `test-driver` orb:
      - `extra-env`: a string that will be prepended to the `lein test` invocation, in order to set environment variables specifically for that test run.  Expected to look like `VAR_NAME=a VAR_NAME_2=b`. Defaults to blank (i.e. nothing).
      - `test-selector`: a string that represents the Leiningen test [selectors](https://cljdoc.org/d/leiningen/leiningen/2.9.5/api/leiningen.test#test). Defaults to `:all` (i.e., run all tests).
      
      Adding RDS root CA truststore file to our resources so that CircleCI (and anyone else, really) can refer to it
      
      Defining new `be-tests-oracle-ssl-ee test-driver` task, and is identical to it except for the env vars required to connect via SSL instead (by specifying the RDS root CA trust store).  It only runs a few Oracle driver specific tests, not the full suite, since we are really only concerned with connectivity here.
      
      Updating Oracle driver docs to discuss relevant JVM params and configuration
      Unverified
      7b24bc98
  16. Mar 10, 2021
  17. Mar 05, 2021
    • Cam Saul's avatar
      Shared CLJ/CLJS lib (#14980) · cca03d22
      Cam Saul authored
      * Shared CLJ/CLJS lib (PoC/WIP)
      
      * PoC 2.0
      
      * Fixes :wrench:
      
      * More test fixes :wrench:
      
      * Bump shadow-cljs version
      
      * Fix more stuff
      
      * Need to ^:export the exports
      
      * CI fixes :wrench:
      
      * Add eslintignore
      
      * Ignore cljs files for FE code coverage
      
      * Try prefixing CLJS -> JS import with goog:
      
      * Revert indentation change
      
      * No goog:
      
      * Add .prettierignore
      
      * Use advanced build for now for JS tests unit we can figure out how to make it work
      Unverified
      cca03d22
  18. Feb 26, 2021
  19. Feb 25, 2021
    • Cam Saul's avatar
      Optimize relative datetime filters (#14835) · 538e5e38
      Cam Saul authored
      1. Rename optimize-datetime-filters middleware -> optimize-temporal-filters (it's more accurate, because this also
      optimizes date or time filter clauses)
      
      2. optimize-temporal-filters middleware now optimizes relative-datetime clauses (which represent a moment in time
      relative to when the query is ran, e.g. "last month") in addition to absolute-datetime clauses (which represent an
      absolute moment in time, e.g. 2021-02-15T14:40:00-08:00) . This middleware rewrites queries so we filter against
      specific temporal ranges without casting the column itself, meaning we can leverage indexes on that column. See #11837
      for more details
      
      3. Added new validate-temporal-bucketing middleware that throws an Exception if you try to do something that makes no
      sense, e.g. bucket a DATE field by :time or a TIME field by :month. This is a better situation then running the query
      and waiting for the DB to complain. (In practice, I don't think the FE client would let you generate a query like this
      in the first place)
      
      4. Fix random test failures for MySQL in task-history-cleanup-test
      Unverified
      538e5e38
    • Tim Macdonald's avatar
      Search: Use number of occurrences in a dashboard (#14946) · 65e3ba19
      Tim Macdonald authored
      * Use dashboard count in search scoring
      
      [Fixes #14945]
      
      * Fix sorting priority bug
      
      (thanks, Dan!)
      
      * Show (hidden) scores in search results for debugging purposes
      
      * Bump memory limit for SQL Server on CI
      
      c.f. https://metaboat.slack.com/archives/C5XHN8GLW/p1614272426000400
      Unverified
      65e3ba19
    • Ariya Hidayat's avatar
  20. Feb 23, 2021
  21. Feb 08, 2021
  22. Feb 05, 2021
  23. Feb 02, 2021
  24. Feb 01, 2021
  25. Jan 13, 2021
  26. Jan 08, 2021
  27. Jan 07, 2021
    • Cam Saul's avatar
      metabase.db & dump/load refactor (#14275) · 1728104b
      Cam Saul authored
      * Split metabase.db into connection, connection-pool-setup, env, setup, and util
      
      * Remove old logging string
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * Deprecate parse-connection-string
      
      * Remove application-db-mock-id
      
      * Full support for MB_DB_CONNECTION_URI for application DB without parsing
      
      * Remove *allow-potentailly-unsafe-connections*
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * Test fixes :wrench:
      
      * Refactor load/dump commands
      
      * New metabase.cmd.copy namespace
      
      * More tweaks etc.
      
      * :wrench:
      
      * :wrench: 2000
      
      * Test fix :wrench:
      
      * :wrench:
      
      * Make linter happy
      
      * Test fix
      
      * Fix typo
      
      * Use correct skip key for backend tests
      Unverified
      1728104b
  28. Dec 29, 2020
    • Nemanja Glumac's avatar
      Convert integration tests to Cypress (#14174) · fef0664a
      Nemanja Glumac authored
      This completes one step towards removing Enzyme.
      The complete list of all tests is at #13657.
      
      * Run each test in isolation
      
      * Convert `EditUserModal.integ.spec.js` to Cypress
      
      * Convert `PeopleListingApp.integ.spec.js` to Cypress
      
      * Convert `GroupDetailApp.integ.spec.js` to Cypress
      
      * Delete `GroupsListingApp.integ.spec.js`
      
      It was already covered in Cypress.
      
      * Delete `NewUserModal.integ.spec.js`
      
      It was already covered in Cypress.
      
      * Convert `UserActivationModal.integ.spec.js`
      
      * Convert `UserPasswordResetModal.integ.spec.js`
      
      * Convert `UserSettings.integ.spec.js`
      
      * Remove integration tests
      
      * Remove integration tests from CI
      
      * Fix linter errors
      
      * Delete `AuditTable.integ.spec.jsx`
      
      * Clean up `people.cy.spec.js`
      
      * Update assertion that makes sure XHR didn't happen
      
      * Remove redundant command from PR template
      
      Note: `yarn-lint` already runs `yarn flow`.
      https://github.com/metabase/metabase/pull/14174#discussion_r549790198
      
      * Remove explicit mention of timezones in `developers-guide.md`
      Unverified
      fef0664a
  29. Dec 16, 2020
    • Cam Saul's avatar
      CI: Check Liquibase 000_migrations.yaml against core.spec (#14097) · 6d9a7355
      Cam Saul authored
      * add step to validate Liquibase migrations to CI
      
      * addColumn should only allow one column.
      
      * Only allow one column added per addColumn change
      
      * Add strict-mode for change sets
      
      * Check that migrations are in order/IDs are unique
      
      * Fix CI
      
      * Tests for the linter!!
      
      * Require remarks when adding new Tables
      
      * Fix CI
      Unverified
      6d9a7355
  30. Dec 09, 2020
Loading