Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 08, 2022
  2. Jun 07, 2022
  3. Jun 06, 2022
  4. Jun 03, 2022
    • Ryan Laurie's avatar
      Dual Slider Component (#23085) · 6ba6e487
      Ryan Laurie authored
      * add generic range slider input
      Unverified
      6ba6e487
    • Ryan Laurie's avatar
      Bulk Filter Modal: Inline Boolean Filter Input (#23011) · ba247045
      Ryan Laurie authored
      * add boolean filtering inline
      Unverified
      ba247045
    • Nemanja Glumac's avatar
      Repro #22518: Changing model definition will not show changes until after... · c266bba0
      Nemanja Glumac authored
      Repro #22518: Changing model definition will not show changes until after browser refresh (#23149) [skip ci]
      
      * Add repro for #22518
      
      * Reinforce the test
      
      * Skip repro
      Unverified
      c266bba0
    • Gustavo Saiani's avatar
    • Nemanja Glumac's avatar
      [E2E] Fix permissions pin flake (#23144) · 9ac13380
      Nemanja Glumac authored
      Unverified
      9ac13380
    • Braden Shepherdson's avatar
      Add a test to check that all exported models have a portable unique name (#23081) · 21c6cb7f
      Braden Shepherdson authored
      Add a test to check that all exported models have a portable unique name
      
      Either an external name (eg. a database path) or an entity_id column.
      Unexported models are explicitly listed as such here.
      
      This makes it impossible to forget to address a unique ID for any new
      model.
      
      Related to epic #22641
      Unverified
      21c6cb7f
    • Maz Ameli's avatar
    • Alexander Lesnenko's avatar
      remove metabot group (#23140) · f3e6878c
      Alexander Lesnenko authored
      Unverified
      f3e6878c
    • Nemanja Glumac's avatar
    • dpsutton's avatar
      License improvements (#23120) · 3ad532b9
      dpsutton authored
      * Switch from classpath to basis for license information
      
      Previously we were chopping the classpath up and starting from there so
      we just had a sequence of strings pointing at jars. Now using the basis
      so we use a _much_ nicer map like
      
      ```clojure
      {org.bouncycastle/bcprov-jdk15on
       {:mvn/version "1.70",
        :deps/manifest :mvn,
        :dependents
        [buddy/buddy-core
         org.bouncycastle/bcutil-jdk15on
         org.bouncycastle/bcpkix-jdk15on],
        :parents
        #{[buddy/buddy-sign buddy/buddy-core]
          [buddy/buddy-sign
           buddy/buddy-core
           org.bouncycastle/bcpkix-jdk15on
           org.bouncycastle/bcutil-jdk15on]
          [buddy/buddy-sign
           buddy/buddy-core
           org.bouncycastle/bcpkix-jdk15on]},
        :paths
        ["/Users/dan/.m2/repository/org/bouncycastle/bcprov-jdk15on/1.70/bcprov-jdk15on-1.70.jar"]}
       ...}
      
      ```
      
      So we now have a true name for the dependency, a path to it, and a
      version. No need to string munge on the classpath.
      
      * Read pom with `maven-model`
      
      rather than us trying to parse the xml, use a maven model on it. Note
      there is another level we can go to that would be aware of parent poms
      but we don't need the overkill here. That's far heavier than what we
      need to do in this instance.
      
      Note this also reorders the algo:
      previously
      - license in jar
      - backfill
      - license from pom
      
      Now:
      - license from jar
      - license from pom
      - backfill
      
      Possible we will want to actually just skip the license from pom bit
      since it only gives us a name and a url and not the full text. We could
      match on these and identify them with the resources used from the
      backfill if we like.
      
      Another important change is that this no longer throws if it cannot find
      a pom for a jar. This came up for the following lib:
      
      ```
      ;; deps.edn
      com.google.cloud.sql/postgres-socket-factory
      {:mvn/version "1.6.0"} ; Secure Google Cloud SQL postgres connections
      
      ;; override:
      "com.github.jnr"             {"jffi$native" {:resource "apache2_0.txt"}}
      ```
      Which was from a 3rd party PR.
      
      * Way to generate libs that need overrides
      
      * Remove unused fns, add tests, cleanup docstring
      
      * Don't leave tap> in
      
      Two poms blow up with BOM errors
      
      - jakarta.activation-1.2.1.pom
      - jakarta.activation-api-1.2.2.pom
      
      > UTF-8 BOM plus xml decl of iso-8859-1 is incompatible
      > (position: START_DOCUMENT seen <?xml version="1.0" encoding="iso-8859-1"... @1:41)
      
      It has a parent pom and not a license so we wouldn't find it anyways.
      Unverified
      3ad532b9
Loading