This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jun 08, 2022
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Jun 07, 2022
-
-
Case Nelson authored
* Include :features whether or not db is initialized On restart, drivers may not be initialized but admins still need to know what features are available. Always include features on db post-select. * Driver can be null when not selected * Remove intitialized check for :details as well Both driver.u/features and driver/normalize-db-details eventually call `dispatch-on-initialized-driver` which will call `initialize-driver-if-needed`, removing the need for the check. * Unregistered drivers can make it in here, but they can be abstract so driver/available is not apropriate
-
Howon Lee authored
Do trivial identity for passthrough of symbols for nested field column instead of default processing (#23136) Should whack both #23026 and #23027. Previous (default) behavior of the reducible query that gets the limited contents of the JSON to break out the nested field columns is to lowercase identifiers. This is root cause of #23026 and #23027. But we want the proper case of those identifiers in order to be modifying the query correctly when we query the JSON. So we set the reducible query to just pass through the identifiers instead of default behavior.
-
Alexander Lesnenko authored
-
Ryan Laurie authored
-
Nemanja Glumac authored
-
dpsutton authored
-
Luiz Arakaki authored
-
Alexander Polyankin authored
-
Diogo Mendes authored
* Adding conditional to GHA E2E Test * Adding missing ` * Running if as suggested * Update matrix * Correcting logic * Removing typo * Removing duplicated run * Updating to the new launch name * Update with master
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Ikko Ashimine authored
unqiue -> unique
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Benoit Vinay authored
* Mode moved into its own package * Misc code clena up * Comment added back in * modes set to TS * getMode method WIP * getMode clean up * ObjectLiteral type added * Fix types for Mode * ObjectLiteral replaced where necessary * FilterPopover commit issue Please enter the commit message for your changes. Lines starting * ObjectLiteral replaced with TS Record * ObjectLiteral removed
-
- Jun 06, 2022
-
-
Ariya Hidayat authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
metamben authored
Fixes #22626.
-
Natalie authored
-
Noah Moss authored
-
Dalton authored
* Move date formatting code to utils file * Add parameter formatting util * Replace component format fn usage * Add exception for parameters mapped to sql variables * Remove now unused format functions
-
Nemanja Glumac authored
-
Alexander Polyankin authored
-
dpsutton authored
CVE info: Package: com.google.oauth-client:google-oauth-client Installed Version: 1.31.5 Vulnerability CVE-2021-22573 Severity: HIGH Fixed Version: 1.33.3 ``` . metabase/bigquery-cloud-sdk /Users/dan/projects/work/metabase/modules/drivers/bigquery-cloud-sdk . com.google.cloud/google-cloud-bigquery 1.135.4 . [truncated] . com.google.oauth-client/google-oauth-client 1.31.5 . metabase/googleanalytics /Users/dan/projects/work/metabase/modules/drivers/googleanalytics . com.google.apis/google-api-services-analytics v3-rev20190807-1.32.1 . com.google.api-client/google-api-client 1.32.1 . com.google.oauth-client/google-oauth-client 1.31.5 ``` I looked into bumping com.google.apis/google-api-services-analytics-v3-rev20190807-1.32.1 but as far as I can tell from https://search.maven.org/artifact/com.google.apis/google-api-services-analytics this is the most recent version so we have to just target the transitive dep. For bigquery, it seems we are pretty far behind. 1.135.4 was released in July 2021, the current version is 2.13.1 released in June. https://mvnrepository.com/artifact/com.google.cloud/google-cloud-bigquery I'm hesitant to bump this for a CVE but we need to prioritize this upgrade. After this PR: ``` clj -Stree -A:drivers . metabase/bigquery-cloud-sdk /Users/dan/projects/work/metabase/modules/drivers/bigquery-cloud-sdk . com.google.cloud/google-cloud-bigquery 1.135.4 . [truncated] X com.google.oauth-client/google-oauth-client 1.31.5 :older-version . com.google.oauth-client/google-oauth-client 1.33.3 . metabase/googleanalytics /Users/dan/projects/work/metabase/modules/drivers/googleanalytics . com.google.apis/google-api-services-analytics v3-rev20190807-1.32.1 . com.google.api-client/google-api-client 1.32.1 X com.google.oauth-client/google-oauth-client 1.31.5 :older-version ``` With the `X` meaning not included and 1.33.3 being top level included so using that version.
-
Gustavo Saiani authored
-
Case Nelson authored
* Handle deletable state when enabling persistence When enabling persistence all models are supposed to be set to creating unless they have been explicitly turned "off". Before, we were only looking for new models without attached PersistedInfos when enabling, but missed deletable PersistedInfos that needed to be re-enabled. It's the correct thing to do during the refresh as you wouldn't want refresh to re-enable but it's incorrect when enabling. * Remove unecessary thread-last
-
Nemanja Glumac authored
-
- Jun 03, 2022
-
-
Ryan Laurie authored
* add generic range slider input
-
Ryan Laurie authored
* add boolean filtering inline
-
Nemanja Glumac authored
Repro #22518: Changing model definition will not show changes until after browser refresh (#23149) [skip ci] * Add repro for #22518 * Reinforce the test * Skip repro
-
Gustavo Saiani authored
-
Nemanja Glumac authored
-
Braden Shepherdson authored
Add a test to check that all exported models have a portable unique name Either an external name (eg. a database path) or an entity_id column. Unexported models are explicitly listed as such here. This makes it impossible to forget to address a unique ID for any new model. Related to epic #22641
-
Maz Ameli authored
-
Alexander Lesnenko authored
-
Nemanja Glumac authored
-
dpsutton authored
* Switch from classpath to basis for license information Previously we were chopping the classpath up and starting from there so we just had a sequence of strings pointing at jars. Now using the basis so we use a _much_ nicer map like ```clojure {org.bouncycastle/bcprov-jdk15on {:mvn/version "1.70", :deps/manifest :mvn, :dependents [buddy/buddy-core org.bouncycastle/bcutil-jdk15on org.bouncycastle/bcpkix-jdk15on], :parents #{[buddy/buddy-sign buddy/buddy-core] [buddy/buddy-sign buddy/buddy-core org.bouncycastle/bcpkix-jdk15on org.bouncycastle/bcutil-jdk15on] [buddy/buddy-sign buddy/buddy-core org.bouncycastle/bcpkix-jdk15on]}, :paths ["/Users/dan/.m2/repository/org/bouncycastle/bcprov-jdk15on/1.70/bcprov-jdk15on-1.70.jar"]} ...} ``` So we now have a true name for the dependency, a path to it, and a version. No need to string munge on the classpath. * Read pom with `maven-model` rather than us trying to parse the xml, use a maven model on it. Note there is another level we can go to that would be aware of parent poms but we don't need the overkill here. That's far heavier than what we need to do in this instance. Note this also reorders the algo: previously - license in jar - backfill - license from pom Now: - license from jar - license from pom - backfill Possible we will want to actually just skip the license from pom bit since it only gives us a name and a url and not the full text. We could match on these and identify them with the resources used from the backfill if we like. Another important change is that this no longer throws if it cannot find a pom for a jar. This came up for the following lib: ``` ;; deps.edn com.google.cloud.sql/postgres-socket-factory {:mvn/version "1.6.0"} ; Secure Google Cloud SQL postgres connections ;; override: "com.github.jnr" {"jffi$native" {:resource "apache2_0.txt"}} ``` Which was from a 3rd party PR. * Way to generate libs that need overrides * Remove unused fns, add tests, cleanup docstring * Don't leave tap> in Two poms blow up with BOM errors - jakarta.activation-1.2.1.pom - jakarta.activation-api-1.2.2.pom > UTF-8 BOM plus xml decl of iso-8859-1 is incompatible > (position: START_DOCUMENT seen <?xml version="1.0" encoding="iso-8859-1"... @1:41) It has a parent pom and not a license so we wouldn't find it anyways.
-