Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 11, 2024
  2. Nov 08, 2024
  3. Nov 07, 2024
  4. Nov 06, 2024
    • github-automation-metabase's avatar
      Filter out Empty Rows from Pivot Exports (#49512) (#49638) · 1d5dd2c3
      github-automation-metabase authored
      
      * Pivot Measures Order Used in Pivot Exports
      
      Fixes #48442
      
      A pivot table can have any number of measures, and the user can order these by dragging in the UI. Before this PR,
      that order was ignored and measures would alway be in index order, which is confusing for any user who needs the
      measures to be displayed in a particular order, especially if they've re-ordered them in the pivot viz settings UI.
      
      A test has been added to check that measure order is used.
      
      A few minor changes to the pivot qp and post-processor
       - measure indices are looked up in the pivot qp and added in viz-settings order
       - the pivot measures are only added if the qp has not already added them.
       - pivot-opts Malli spec has been made in the namespace, adjusted to allow `nil` as a valid pivot-opts output, and
       used in relevant functions
      
      * address review points.
      
      * add a rows order test
      
      * Filter out Empty Rows from Pivot Exports
      
      Fixes #49353
      
      The linked issue is not actually related to pivot export size but is instead related to the 'Min of Created At: Month'
      aggregation; the default aggregation function was `+`, so it broke when the date string was encountered.
      
      That was fixed.
      
      As I was trynig to keep the export small if possible, I noticed that in some cases empty rows are appended, so I added
      the filter so that if a pivot row's values are completely empty, it doesn't add it.
      
      Finally, this PR also adds the 'sub section totals' which I noticed were missing from the exports. This comes up when
      you have 3+ pivot-rows configured, so you can see the subtotals for the first pivot row and the subtotals nested
      within those sections for the second pivot row, and so on.
      
      * add test for non-numeric values
      
      * Make sure the new name refs match on aggregations not just breakouts
      
      * cljfmt
      
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
    • github-automation-metabase's avatar
      [serdes] meaningful API status codes (#49610) (#49616) · 1be414a1
      github-automation-metabase authored
      
      previously import would return 200 w/o regard if it was successful or not
      
      fixes #49602
      
      Co-authored-by: default avatarAlexander Solovyov <alexander@solovyov.net>
      Unverified
      1be414a1
    • github-automation-metabase's avatar
      Fix :pivot-measures with column names (#49575) (#49614) · d658d05f
      github-automation-metabase authored
      
      * Fix :pivot-measures with column names
      
      * Fix the test
      
      * Update src/metabase/query_processor/pivot.clj
      
      
      
      * Add a test
      
      * Add a test
      
      ---------
      
      Co-authored-by: default avatarAlexander Polyankin <alexander.polyankin@metabase.com>
      Co-authored-by: default avatarBraden Shepherdson <braden@metabase.com>
      Unverified
      d658d05f
    • github-automation-metabase's avatar
      Fix flaky #31274 repro (#49601) (#49613) · e1ff879e
      github-automation-metabase authored
      
      * Remove @flaky tag
      
      * Fix flake
      
      * Refactor
      
      * Use getDashboardCard
      
      * Shorten text
      
      * Fix flake
      
      * Revert previous changes
      
      * Revert "Revert previous changes"
      
      This reverts commit 16b56f26.
      
      * Fix flake
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Unverified
      e1ff879e
Loading