Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 14, 2023
    • Kamil Mielnik's avatar
      User friendly error message when combining series that cannot be visualized together (#33119) · 71fdba7e
      Kamil Mielnik authored
      * Use named import for ErrorView
      
      * Export ErrorView and ErrorViewProps from Visualization
      
      * Define AddSeriesModalErrorView
      
      * Make ErrorView component configurable in Visualization by introducing errorView prop
      
      * Use AddSeriesModalErrorView thanks to new errorView prop
      
      * Fix export type syntax
      
      * Remove the dot for consistency with other error messages
      
      * Rename AddSeriesModalErrorView to ErrorView and extract it to a separate file
      
      * Allow translating the custom error message
      
      * Don't show custom ErrorView when there is only one series (or none)
      
      * Add a test case for a single incomplete chart
      
      * Inline: dashcardData
      
      * Add a reproduction e2e test for #32231
      
      * Add explicit assertion for the error message
      
      * Add a test case for default error message when there is only 1 series
      
      * Remove redundant setup functions
      
      * Wait for series query endpoint
      
      * Rename ErrorView to VisualizationErrorView
      
      * Rename VisualizationErrorView to MultipleSeriesErrorView
      
      * Improve assertions
      
      * Use editDashboard helper
      
      * Use data-testid for AddSeriesModal
      
      * Refactor errorView prop into errorMessageOverride
      - Do not export ErrorViewProps and Error out of Visualization
      Unverified
      71fdba7e
Loading