Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 22, 2023
    • Cam Saul's avatar
      Parallelize QP tests (August 2023 attempt) (#33068) · d54caf88
      Cam Saul authored
      * Parallel QP tests; linter improvements; move QP test fns
      
      * Cleanup
      
      * Move query->expected-cols
      
      * Fix QP test namespace
      
      * Test fix :wrench:
      
      * Fix merge issues
      
      * Revert unrelated changes
      
      * Test fix :wrench:
      
      * Fix some things that are actually ^:parallel safe
      
      * Remove Oracle logic for destroying DBs from different sessions since we don't test on AWS anymore
      
      * Use ReentrantReadWriteLock for getting + creating test datasets to avoid race conditions
      
      * Add non-`metabase.test` versions of things to the disallowed list for `^:parallel` tests
      Unverified
      d54caf88
  2. Aug 15, 2023
  3. Aug 09, 2023
  4. Aug 06, 2023
    • Cam Saul's avatar
      QP: use Malli (#32657) · 18c1b198
      Cam Saul authored
      * QP: use Malli
      
      * Fix schema names
      
      * Fix missing namespaces
      
      * Fix busted stuff
      
      * Simplify the new schema
      
      * Test fix :wrench:
      
      * Test fixes :wrench:
      
      * MongoDB fixes :wrench:
      
      * FAST mu/defn
      
      * Malli registry
      
      * Misc fixes
      
      * Some cleanup
      
      * Misc cleanup and test fixes :wrench:
      
      * mu/disable-enforcement
      
      * Test fix
      
      * Fix Cljs version of `disable-enforcement`
      
      * Misc improvements
      
      * Update tests
      
      * Fix Kondo warnings
      
      * Fix Kondo warnings
      
      * Fix busted Malli schema
      
      * PR feedback
      
      * Fix busted schema
      
      * Kondo fixx
      
      * Test fixes :wrench:
      
      * Use Malli version of `describe` now that PR was merged
      
      * Work around https://github.com/metosin/malli/issues/924
      
      * Test fixes :wrench:
      
      * Improvements
      
      * Test fix
      Unverified
      18c1b198
  5. Aug 03, 2023
  6. Jul 31, 2023
  7. Jul 20, 2023
  8. Jul 04, 2023
  9. Jun 30, 2023
  10. Jun 20, 2023
  11. Jun 16, 2023
  12. May 31, 2023
  13. May 24, 2023
  14. May 08, 2023
    • john-metabase's avatar
      Adds tools.cli command parsing and improved option behavior for serialization commands (#30435) · 7dbd457e
      john-metabase authored
      Commands can now specify a command-line arg spec to enable automatic argument parsing and improved help text.
      New commands should use this arg spec format and existing commands can be updated if desired.
      
      * Adds tools.cli command parsing and improved option behavior for v2 export and load
      * Fixes --no-collections export, empty settings export
      * Improves command error handling, adds help text on error
      * Lists valid commands when unknown command is given
      * Cleans up collection selection for generic export
      * Supports --user by email in serdes v2 export
      Unverified
      7dbd457e
  15. May 03, 2023
  16. Apr 27, 2023
  17. Apr 21, 2023
  18. Apr 18, 2023
  19. Apr 13, 2023
  20. Apr 12, 2023
    • dpsutton's avatar
      Revert "`clj -M:run` should not think it's running in `:dev` mode (#30004)" (#30043) · fc02e165
      dpsutton authored
      This reverts commit 8a11e382.
      
      The namespace `metabase.server.middleware.security` controls our content
      security policy header. In dev we allow connections to 8080 for webpack
      assets. Not dev we deny these.
      
      `clj -M:run` is dev since it is running the project from source, not a
      jar. This `mb.run.mode` was removed when we were fighting require issues
      for `metabase.query-processor-test.test-mlv2`. That's solved so we can
      restore the dev property to `:run`.
      Unverified
      fc02e165
  21. Apr 11, 2023
  22. Apr 05, 2023
  23. Mar 30, 2023
  24. Mar 22, 2023
  25. Mar 17, 2023
  26. Mar 14, 2023
  27. Mar 13, 2023
  28. Mar 10, 2023
  29. Mar 09, 2023
  30. Mar 08, 2023
  31. Mar 07, 2023
    • dpsutton's avatar
      Update tools.build and usage (#28977) · b549b291
      dpsutton authored
      Calling our basis function with just :oss or :ee we don't end up with an
      `:argmap` key.
      
      ```clojure
      uberjar=> (def basis (create-basis :oss))
      ,#'build.uberjar/basis
      uberjar=> (:argmap basis)
      nil          ;; nothing extra in oss
      
      uberjar=> (def basis (create-basis :ee))
      ,#'build.uberjar/basis
      uberjar=> (:argmap basis)
      {:extra-paths ["enterprise/backend/src"]}
      
      ;; and if other aliases are used:
      uberjar=> (def basis' (b/create-basis {:project "deps.edn" :aliases [:dev :test]}))
      ,#'build.uberjar/basis'
      uberjar=> (:argmap basis')
      {:extra-deps {lambdaisland/deep-diff2 {:mvn/version "2.7.169"},
                    methodical/methodical {:mvn/version "0.15.1"},
                    io.github.metabase/hawk {:sha
                    "45ed36008014f9ac1ea66beb56fb1c4c39f8342b"},
                    ....}
       :extra-paths ["dev/src"...]
       :jvm-opts ["-Dmb.run.mode=dev" ...]
       :exec-fn metabase.test-runner/find-and-run-tests-cli}
      ```
      Unverified
      b549b291
    • dpsutton's avatar
      Fix flaky test and test for a new case (#28757) · cc4601b1
      dpsutton authored
      
      * Fix flaky test and test for a new case
      
      flaky test was annoying. It would timeout after 45 seconds. And
      annoyingly, it times out on the _client_, not the server. So we don't
      get the proper error message we expect.
      
      And what's happening is that the backend just hooks up the pipe from
      it's request to the response. And if no bytes ever come across, we just
      twiddle our thumbs until the http request in the test gives up.
      
      The only reliable way i could think of to fix this is to spin up a
      webserver that just accepts and then ignores requests (which is what
      github did to us in the flaky test).
      
      Had to bump the ring adapter to get the newly exposed `:async-timeout
      60000` parameter. By default the webserver in the test has a timeout of
      30 seconds, which is shorter than the 45 second timeout for the test's
      request to the geojson endpoint.
      
      * add comment
      
      * clean up test server logic
      
      ---------
      
      Co-authored-by: default avatarNemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
      Unverified
      cc4601b1
Loading