Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 22, 2024
  2. Nov 21, 2024
    • Chris Truter's avatar
    • John Swanson's avatar
      Fix serdes of missing cards in click behavior (#50108) · 2f8a7c69
      John Swanson authored
      * Fix serdes of missing cards in click behavior
      
      When exporting a dashboard, we export its dashcards, including cards
      referenced inside its viz_settings.
      
      The problem is that viz_settings might have references to
      now-nonexistent cards.
      
      This is an initial stab at cleaning up the problem, specifically for
      click behavior. If Dashboard D has Dashcard DC, which has a
      click-behavior that links to Card C, then when we collect the
      descendants of D, we'll include a reference to C - even if C has been
      deleted.
      
      So this makes two changes: first, when calculating the descendants of a
      dashcard, don't include links to cards that don't exist. And, when
      exporting the click behavior, remove the whole thing entirely if the
      card it points to doesn't exist.
      Unverified
      2f8a7c69
  3. Nov 20, 2024
  4. Nov 19, 2024
  5. Nov 18, 2024
  6. Nov 15, 2024
  7. Nov 14, 2024
  8. Nov 13, 2024
  9. Nov 12, 2024
  10. Nov 11, 2024
  11. Nov 08, 2024
  12. Nov 06, 2024
  13. Nov 05, 2024
  14. Nov 01, 2024
    • Nick Fitzpatrick's avatar
      Dashboard verifications (#48956) · 4a6c1d26
      Nick Fitzpatrick authored
      
      * Adding moderation status to Dashboards
      
      * react sins
      
      * verification coll: subselect on card + dashboard
      
      * fix the 3 failing BE tests
      
      * add an api test for dashboard verification
      
      * verified dashboards are never stale
      
      * e2e tests
      
      * code cleanup
      
      * unit test and e2e test cleanup
      
      * PR Feedback
      
      * backend test fixes
      
      * Nick shouldn't touch clojure
      
      * type fix
      
      * indent
      
      * fix last 2 BE tests
      
      ---------
      
      Co-authored-by: default avatarBryan Maass <bryan.maass@gmail.com>
      Unverified
      4a6c1d26
  15. Oct 30, 2024
  16. Oct 28, 2024
  17. Oct 24, 2024
    • bryan's avatar
      AG housekeeping (#49047) · cca66d44
      bryan authored
      
      * upgrades is-airgapped? defn to defsetting airgap-enabled
      
      - uses the airgap-enabled settings value to remove Cloud section in
        SettingsEditor
      - "Metabase Enterprise Airgap" -> "Enterprise Airgap"
      
      * hide still need help section in airgap mode
      
      * move flag checking into selectors
      
      * fe lint
      
      * ts type check
      
      * use optional chaining and nullish coalescing
      
      * hide StillNeedHelp in ag mode
      
      * adding airgap-enabled to createMockSettings
      
      ---------
      
      Co-authored-by: default avatarNick Fitzpatrick <nickfitz.582@gmail.com>
      Unverified
      cca66d44
  18. Oct 22, 2024
  19. Oct 18, 2024
  20. Oct 17, 2024
  21. Oct 15, 2024
  22. Oct 14, 2024
  23. Oct 11, 2024
  24. Oct 10, 2024
    • Ngoc Khuat's avatar
      [Notification] System event notification (#47857) · fc43d3cd
      Ngoc Khuat authored
      * [Notification] Notification and subscription (#47707)
      
      * [Notification] Notification and subscription (#47707)
      
      * [Notification] Handlers + recipients (#47759)
      
      * [Notification] Channel template table and model (#47782)
      
      * [Notification] Render system event emails (#47859)
      
      * [Notification] Strict type for channel template and notification recipient (#47910)
      
      * [Notification] Event hydration (#47953)
      
      * [Notification] Send asynchronously (#48200)
      Unverified
      fc43d3cd
  25. Oct 08, 2024
    • Nicolò Pretto's avatar
      Unverified
      537ba417
    • Cam Saul's avatar
      :race_car::rocket::race_car::rocket: :race_car::rocket: SHAVE 7 MINUTES OFF OF NON-CORE DRIVER TEST RUNS IN CI :race_car::rocket::race_car::rocket: :race_car::rocket: (#47681) · cd4d7646
      Cam Saul authored
      * Parallel driver tests PoC
      
      * Set fail-fast to false for now
      
      * Try splitting up non-driver tests to see how broken tests are
      
      * Whoops fix plain BE tests
      
      * Ok nvm I'll test this in another branch
      
      * Fix fail-fast
      
      * Experiment with the improved Hawk split logic
      
      * Fix some broken/flaky tests
      
      * Experiment: try splitting MySQL 8 tests into FOUR jobs
      
      * Divide other Postgres and MySQL tests up and use num-partitions = 2
      
      * Another test fix :wrench:
      
      * Flaky test fix :wrench:
      
      * Try making more stuff fast
      
      * Make athena fast??
      
      * Fix a few more things
      
      * Test fixes? :wrench:
      
      * Fix configs
      
      * Fix Mongo job syntax
      
      * Fix busted test from #46942
      
      * Fix Mongo config again
      
      * wait-for-port needs to specify shell I guess
      
      * More cleanup
      
      * await-port can't have a timeout-minutes I guess
      
      * Let's only parallelize MySQL for now.
      
      * Cleanup action
      
      * Cleanup wait-for-port action
      
      * Fix another flaky test
      
      * NOW driver tests will be FAST
      
      * Need to mark driver tests too
      
      * Fix wrong tag
      
      * Use Hawk 1.0.5
      
      * Fix busted metabase.public-settings-test/landing-page-setting-test
      
      * Fix busted `metabase.api.database-test/get-database-test` etc. (hopefully)
      
      * Fix busted `metabase.sync.sync-metadata.fields-test/sync-fks-and-fields-test` for Oracle
      
      * Maybe this fixed `metabase.query-processor.middleware.permissions-test/e2e-ignore-user-supplied-perms-test` maybe not
      
      * Fix busted metabase.api.dashboard-test/dependent-metadata-test because endpoint had differemt sort order than test
      
      * Ok my test fix did not work
      
      * Fix metabase.sync.sync-metadata.fields-test/sync-fks-and-fields-test for Redshift
      
      * Better test name
      
      * More test fixes :wrench:
      
      * Schema fix
      
      * PR feedback
      
      * Split off test partitioning into separate PR
      
      * Fix failing Oracle tests
      
      * Another round of test fixes, hopefully
      
      * Fix failing Redshift tests
      
      * Maybe the last round of test fixes
      
      * Fix Oracle
      
      * Fix stray line
      Unverified
      cd4d7646
  26. Oct 07, 2024
    • metamben's avatar
      Implement better partitioning and sorting in window functions (#48028) · de50ba71
      metamben authored
      Implement better partitioning and sorting in window functions
      Unverified
      de50ba71
    • Case Nelson's avatar
      feat: move auth providers behind ee token (#48245) · eaabfa79
      Case Nelson authored
      * feat: move auth providers behind ee token
      
      Fixes #48235
      
      Introduces new premium feature `database-auth-providers`.
      Moves fetch-auth behind defenterprise - oss will always return an empty
      map.
      Add metabase.util.http to test outbound http requests.
      
      * Fix broken refs
      
      * Drop defmethod as adhoc overrides aren't desirable outside ee
      
      * Drop unessary require
      
      * Fix token and tests
      
      * Fix tests
      
      * Fix formatting
      
      * Fix var cast exception
      
      * Fix connection test
      
      * Move test to ee namespace
      
      * Move more tests behind enterprise
      
      * Fix checked-section hiding
      Unverified
      eaabfa79
Loading