Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jan 27, 2023
  2. Jan 26, 2023
  3. Jan 25, 2023
  4. Jan 24, 2023
  5. Jan 23, 2023
    • john-metabase's avatar
      Fix cached UI-generated queries in MongoDB (#27656) · 33cc23f1
      john-metabase authored
      * Fixes MongoDB OrderedMap encoding with nippy
      * Removes flatland/ordered from build-drivers deps
      33cc23f1
    • Tim Macdonald's avatar
      Upgrade clj-kondo to version 2023.01.20 (#27819) · 436846f0
      Tim Macdonald authored
      This version fixes a bug where Malli was generating types unknown to
      Kondo and Kondo was flagging an erroneous type mismatch. See the
      changelog for more details:
      
      https://github.com/clj-kondo/clj-kondo/blob/master/CHANGELOG.md#20230120
      436846f0
    • dpsutton's avatar
      Fix failing bigquery test (#27837) · 866602e9
      dpsutton authored
      Bigquery was checking that we can set a project-id in the db details of
      a bigquery database. Normally this comes from the json token:
      
      ```
      export MB_BIGQUERY_CLOUD_SDK_TEST_SERVICE_ACCOUNT_JSON='{
        "type": "service_account",
        "project_id": "metabase-bigquery-driver", // <- ordinarily source of truth
        "private_key_id": "keykeykeykeykeykeykeykey",
        "private_key": "-----BEGIN PRIVATE KEY----- ...."
      ```
      
      The db details normally connects to project-id
      "metabase-bigquery-driver" and this test swaps out to
      "bigquery-public-data" with a schema filter on chicago_taxi_trips.
      
      to prove it works it selects from that dataset:
      
      ```
      (mt/first-row
        (mt/run-mbql-query taxi_trips
          {:filter [:= [:field (mt/id :taxi_trips :unique_key) nil]
                       "67794e631648a002f88d4b7f3ab0bcb6a9ed306a"]}))
      ```
      
      The test fails because this row seems to no longer be in the
      results. The query isn't failing, it's just returning no rows (and
      presumably because the row with this id from 2014 is no longer in the
      dataset.)
      
      I ran the same with with a limit 4, see it's working and grab one of
      those rows and use the id as in the filter clause.
      
      old: "67794e631648a002f88d4b7f3ab0bcb6a9ed306a" ("2014-01-12T00:45:00Z")
      new: "ff0b96c0cada768361b1c9341e11905254644afb" ("2016-09-20T07:15:00Z")
      866602e9
    • Ryan Laurie's avatar
      Resizable Pivot Table Data Columns (#27725) · d0d06533
      Ryan Laurie authored
      * add PivotTable unit tests
      
      * obey the linter
      
      * measure leftHeader cell content
      
      * test cell data width detection
      
      * extract static properties
      
      * convert to functional component
      
      * cleanup refs
      
      * extract cellRenderers
      
      * extract size and position getter functions
      
      * replace item measurement
      
      * convert rowToggleIcon to typescript
      
      * convert PivotTable to typescript
      
      * remove unused hasCustomColors
      
      * update tests to typescript
      
      * fix rebase
      
      * User Resizable Pivot Table Columns (#27692)
      
      * move column widths to state
      
      * add drag resizing
      
      * only get initial header widths on row change
      
      * better column change handling
      
      * return if there are no valid rowIndexes
      
      * address review comments
      
      * add drag resizing
      
      * address review comments
      
      * allow data/value columns to be resized
      
      * update tests
      
      * use map for value col storage
      d0d06533
    • Alexander Polyankin's avatar
      Fix the test (#27826) · b8647f3b
      Alexander Polyankin authored
      b8647f3b
    • Anton Kulyk's avatar
      Extend router mocking and test public page theming (#27820) · c30c1f5d
      Anton Kulyk authored
      * Add `router` config to `renderWithProviders`
      
      * Add tests for `EmbedFrame's` theming
      
      * Rename `router` to `initialRouterState`
      
      * Rename router state opts
      c30c1f5d
    • Alexander Polyankin's avatar
    • Anton Kulyk's avatar
      Clean up `EmbedFrame` component (#27746) · 69cae74c
      Anton Kulyk authored
      * Move `EmbedFrame` to its own directory
      
      * Clean up `LogoBadge`
      
      * Extract styled components
      
      * Clean up `EmbedFrame`
      
      * Replace `MetabaseSettings` with selector
      
      * Sort props
      
      * Don't check for `setParameterValue`
      
      https://github.com/metabase/metabase/pull/27746#discussion_r1081797694
      
      * Adjust styles
      69cae74c
    • metamben's avatar
      Simplify the calculation of mongo column types (#27752) · 7babd398
      metamben authored
      * Simplify the calculation of mongo column types
      
      * Remove TODO, since driver.common/class->base-type is being used
      7babd398
    • metamben's avatar
    • Nemanja Glumac's avatar
    • Ryan Laurie's avatar
      Actions on dashboards (redux) (#27815) · 9ca4af5b
      Ryan Laurie authored
      
      * update dashboard + card + parameters to support actions
      
      * Add ActionViz Components
      
      * add ActionParameterInputForm
      
      * Add AddActionSidebar and ActionPicker
      
      * move ActionParametersInputModal
      
      * remove page and app references
      
      * reorganize utils
      
      * update types
      
      * check dashboard eligibility for actions access
      
      * fix typos
      
      * remove reference to list viz
      
      * show all models in action picker
      
      * allow delete actions to submit with no form fields
      
      * remove unused testing functions
      
      * add ActionViz unit tests
      
      * add ActionParametersInputForm unit tests
      
      * update dashboard + card + parameters to support actions
      
      * add ActionParameterInputForm
      
      * move ActionParametersInputModal
      
      * check dashboard eligibility for actions access
      
      * Fix native query editor mock in `ActionCreator` tests (#27794)
      
      * Update `NativeQueryEditor` mock
      
      * Mock `NativeQueryEditor` before registering viz
      
      * more cleanup
      
      * add more tests
      
      * move api mock to setup function
      
      * click the correct click icons
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      9ca4af5b
    • dpsutton's avatar
      Exclude tests in drivers (#27658) · c659e767
      dpsutton authored
      We can now filter out any ns tag for tests.
      c659e767
    • Anton Kulyk's avatar
      Fix `LogoBadge` `dark` prop value (#27796) · 8373f121
      Anton Kulyk authored
      8373f121
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Allowing users to hide logo on embedding (#27391) · ee1c956f
      Mahatthana (Kelvin) Nomsawadi authored
      * First draft of allowing users to hide logo on embedding
      
      * Add lotsa E2E tests
      
      * Change non-hovered side bar toggle color when hiding logo
      
      Because previously we never had an option to hide the logo. We won't
      see non-hovered side bar toggle on desktop, but now we can so it would
      make more sense to make non-hovered and hovered state have different
      colors
      
      * Fix failed test, not sure why this happens though
      
      * Ensure we don't show empty app bar when logo is disabled
      
      * Fix hiding app bar even when side_nav is enabled
      
      * Remove nested component selector in styled components
      
      * Moving show hide logic to JS
      
      * Address review: Make prop name easier to read
      
      * Address review: Remove more nested component selector
      
      * Address review: completely remove nested component selector
      
      From AppBarLeftContainer
      
      * Address review: Duplicate first test from E2E to unit
      
      * Make test better, fix types, remove mocks
      
      * Completely move the first test from E2E to unit
      
      * Move the 2nd test
      
      * Move the rest of the desktop E2E test to unit
      
      * Move mobile E2E tests to unit
      
      * Remove unused import
      
      * Address review: Better function name
      
      * Address feedback: Remove type casting
      
      * Address review: Don't rely on app code in metabase-types
      
      * Address feedback: Fix aria-label isn't human friendly.
      
      * Address review: Fix wrong required type property
      
      * Address feedback: follow test convention
      
      - name `setup`
      - mock endpoint in `setup` function
      
      * Better collection endpoint mock maybe?
      
      * Address PR comment
      ee1c956f
  6. Jan 21, 2023
Loading