This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Dec 18, 2024
-
-
github-automation-metabase authored
* add percentages to sankey tooltip * another tooltip variant * specs * lint Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Phoomparin Mano <poom@metabase.com> Co-authored-by:
Phoomparin Mano <phoomparin@gmail.com>
-
github-automation-metabase authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
backported "fix(sdk): migrate to custom redux context to allow using the sdk on host apps that use redux" (#51414) * step1: add MetabaseReduxProvider and make our hooks + connect fn use it step1: add MetabaseReduxProvider and make our hooks + connect fn use it * step 2: codemod * step 3: manual fixes * step 4: e2e test for sdk --------- Co-authored-by:Nicolò Pretto <info@npretto.com>
-
- Dec 17, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Dec 16, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Phoomparin Mano <poom@metabase.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Phoomparin Mano <phoomparin@gmail.com>
-
github-automation-metabase authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com>
- Dec 13, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
* save only grid on fixed width dashboards * split export pdf into pages * trim dashboard export pdf into pages * specs * add padding to pdf pages * dark mode Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
* Fix #51020 * Add a repro for #51020 * Improve test name * Update comment and naming * Improve diff * Add repro for when primary key is not called 'id' * Update repro * Drop prefetchesInitialValues & getValuesForUpdate It's unclear what the real intention behind these two was, but it's clear that it made two differences: (1) It decreased the probability of overwriting someone else's changes (if someone else saved them after we opened the form) (2) It decreases the payload sent over the wire (1) We can ignore this, as this problem is prevalent everywhere in our app (2) This is negligible Dropping these is simpler than enhancing getValuesForUpdate with extra logic for primary keys (and who knows what else) * Break beforeEach into 2 * Remove no longer valid test Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Dec 12, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
* add bug report to command palette and profile menu add bug report to command palette and profile menu * refactor and update diagnostic window modal * add analytics to track bug reporter modal activity * add file id to to the upload-file method * add the ability to collect browser information for diagnostic window * implement feedback from PR comments * Update frontend/src/metabase/components/ErrorPages/ErrorDiagnosticModal.tsx * implement feedback from PR comments #2 * rename "file a bug" to "report an issue" * resolve conflict * fix lint issues * fix bad merge conflict resolution * fix failing onboarding tests --------- Co-authored-by:
Filip Hric <filip@filiphric.sk> Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
* Prevent newly opened items from expanding outside viewport * Expand the unti test coverage * Use the existing helper * Change scroll view to center This works better because it ensures that the top bar doesn't cover the element. * Update frontend/src/metabase/home/components/Onboarding/Onboarding.tsx * Extract the `stopVideo` function * Fix the type name * Set the top scroll margin on the `main` element --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
github-automation-metabase authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
- Dec 11, 2024
-
-
github-automation-metabase authored
* feat(sdk): use public-facing question type in event handlers (#50867) * introduce public metabase question type * revise internal question type * update stories * use public question type in dashboard card plugins * add tests for transforming question properties * add tests for question description * re-export the MetabaseQuestion type * fix lint imports * change publicQuestion to sdkQuestion * name cannot be null if the card is present * reduce collection browser flake --------- Co-authored-by:
Phoomparin Mano <poom@metabase.com> Co-authored-by:
Phoomparin Mano <phoomparin@gmail.com>
-
github-automation-metabase authored
Co-authored-by:
Phoomparin Mano <poom@metabase.com> Co-authored-by:
Phoomparin Mano <phoomparin@gmail.com>
-
- Dec 10, 2024
-
-
github-automation-metabase authored
* Add new user-level setting * Add selector * Make link dismissible from the sidebar * Transfer the onboarding link to the main "gear" menu * Add E2E test to cover the link dismissal behavior * Add tests for the settings menu link * Fix tests * Provide useful comment in the e2e test * Provide contextual explanations to translators Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
github-automation-metabase authored
* Properly handle other users personal collections in collection picker (#50605) * Properly handle other users personal collections in collection picker * fixing types and unit test * e2e adjustments --------- Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
github-automation-metabase authored
* Fix embed loader not translated with #locale * Fix unit tests * Add E2E tests * Fix a case where the lcoale is failed to load * Simplify conditions in `LocaleProvider` * Make E2E tests faster --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
github-automation-metabase authored
Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
- Dec 09, 2024
-
-
github-automation-metabase authored
* fix scatter chart tooltip shows irrelevant info * remove outdated spec as we always show the tooltip_column setting * fix missing tooltip on the total bar on waterfall charts Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
- Dec 06, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
* fix pie chart ignores negative values * fix incorrect handling of zero only values * fix rebase Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
* Always show embed sharing option for admins (#50513) * Always render the public link option This is possible because metabase#50504 * Always render the embed option * Fix unit tests * Fix E2E tests * Correct test semantic * Hide Embed option for non-admins * New Embed modal (#50580) * Open "Compare options" in a new tab * Add an external link icon to interactive embed option when it should * Add disabled state to SDK * Add a disable state to static and interactive embedding * Add interactive embedding disabled state * Implement disabled link * Prepare folder for testing * Fix tests and add SDK tests * Add interactive embedding tests * Correct test desribe block levels * Add static embedding tests * Add premium interactive embedding tests * Add enterprise tests (EE without tokens) * Fix the rest of the failed unit tests * Update E2E tests * Fix a case where OSS see disabled interactive embedding This should be impossible as interactive embedding isn't available on OSS, so we should not display the disabled state. * Address review * Address review Co-Authored-by:
Poom <poom@poom.dev> --------- * Update Interactive Embedding Admin Settings page (#50693) * Add a quick start link to interactive embedding settings page * Update UTM tags for interactive embedding card * Don't show interactive embedding option as enabled on OSS * Fix unit tests * Add a new test --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
- Dec 05, 2024
-
-
github-automation-metabase authored
* fix scatter chart tooltip shows irrelevant info * remove outdated spec as we always show the tooltip_column setting Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
- Dec 04, 2024
-
-
github-automation-metabase authored
* Add delay helper * Remove delays in storybook * Use skippable delay in ListField and SingleSelectListField * Use skippable delay in ExplicitSize * Remove waitTimeContext in storybook * Remove waitTimeContext altogether * Add documentation to delay * Remove all context references in ExplicitSize * Update flaky snapshots Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
github-automation-metabase authored
* Add trial banner * Use the semantic "warning" color for background * Simplify the "reappearance" logic * Refine the banner logic - Pass the bare minimum information (expiry timestamp) to the `TrialBanner` - Take timezones into account - Introduce utilities - Add unit tests * Update the remaining tests * Clean up * Unbreak my `defsetting`
* Add comments * Defer var assignment * Fix failing tests * Adjust the types in order to match `master` * Move the logic up to the parent component * Convert the `index` component to TS * Fix typo in the JSDoc * Fix another typo * Make the return statement more readable * Remove redundant test Co-authored-by:Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Dec 03, 2024
-
-
github-automation-metabase authored
* hides clean up ui on sample collections * commit unsaved changes * pr feedback Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com>
-
github-automation-metabase authored
* Fix the help link * Update data stack image * Fix the link appearance Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
github-automation-metabase authored
* Add new selectors * Adjust the onboarding checklist for non-admins * Add unit tests for non-admins * Rename the control knob * Fix the forgotten test * Stop guarding the route for admins only * Translate `alt` tags * Translate `alt` tags * Add e2e coverage for non-admins * Refine selectors * Improve the route guard * Increase E2E coverage for route guards --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
* add tests for css rules not scoped to the sdk * fix(sdk): adds mb-wrapper class and scope css to it * fix typo * add .mb-wrapper to the body on storybook diff --git a/.storybook/preview.tsx b/.storybook/preview.tsx index 52a0d45125d..a4b3a86f4a5 100644 --- a/.storybook/preview.tsx +++ b/.storybook/preview.tsx @@ -42,15 +42,20 @@ const globalStyles = css` export const decorators = isEmbeddingSDK ? [] // No decorators for Embedding SDK stories, as we want to simulate real use cases : [ - renderStory => ( - <EmotionCacheProvider> - <ThemeProvider> - <Global styles={globalStyles} /> - <CssVariables /> - {renderStory()} - </ThemeProvider> - </EmotionCacheProvider> - ), + renderStory => { + if (!document.body.classList.contains("mb-wrapper")) { + document.body.classList.add("mb-wrapper"); + } + return ( + <EmotionCacheProvider> + <ThemeProvider> + <Global styles={globalStyles} /> + <CssVariables /> + {renderStory()} + </ThemeProvider> + </EmotionCacheProvider> + ); + }, ]; function CssVariables() { Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
github-automation-metabase authored
Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
* do not show column selection error on empty datasets * add more specs to chart-definition logic * fix entry nodes tooltip and click behavior values * fix nodes formatting * do not show sankey data settings on dashboards * do not initiallt open sankey data columns selects * hide sankey tooltip on scroll * drop incorrect types * set sankey node limit * prevent clicks on edges close tooltips on native sankey questions * tweak copy * update sankey spec according to fixes * revert changed settings behavior * fix unit specs Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
* use css variables for skeleton background color * apply theme to folder color * replace theme.white with themeColor * use name of folder chevron color * add background-inverse color mapping * Revert "add background-inverse color mapping" This reverts commit d0b546c5. * avoid overriding folder chevron color in emotion * use Mantine style overrides for NavLink Co-authored-by:
Phoomparin Mano <poom@metabase.com>
-
- Nov 29, 2024
-
-
github-automation-metabase authored
* Migrate Slack channel picker field to use mantine autocomplete * Fix limit size * Fix limit size Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-