This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 17, 2024
-
-
Kamil Mielnik authored
-
- Oct 16, 2024
-
-
Oisin Coveney authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Don't open sidesheet on SDK dashboards * Add E2E test * Fix `className` not passed * Fix unit tests * Fix E2E tests
-
- Oct 15, 2024
-
-
Raphael Krut-Landau authored
-
Aleksandr Lesnenko authored
-
Anton Kulyk authored
* Add default value for `hiddenIndices` * Add e2e test
-
Uladzimir Havenchyk authored
* fix circular deps in query_builder/components * js -> ts
-
adam-james authored
* Incremental Pivot Processing for Exports WIP Fixes pivot exports for CSV and xlsx. The CSV export should use less memory by incrementally building up the data structure and aggregating necessary row data right away, so the memory overhead becomes only as large as the total pivot result. In cases where the pivot rows/cols do combine into many many columns and rows, this can still be a large set of data, but it should behave much better now in most cases. The Excel export is a little more straightforward: create the export rows in the same fashion, streaming one row at a time, and just post-process the sheet to add the pivot table in one shot at the end. * WIP adding row totals. * aggregate totals as rows are added Row, column, section, and grand totals are all aggregated as each row is added. This means the final step of building pivot output becomes just an exercise of lookups/arrangement, no further aggregation is needed. * CSV pivot works per-row, export respects formatting This is a big step forward; we don't need to hold the entire dataset in memory, we instead aggregate a row's data into the pivot datastructure, which only holds onto: - unique values for each pivot-row in a sorted set - unique values for each pivot-col in a sorted set - grand total for each measure N values, where N is number of measures, ususally 1 or 2 - row totals for each combination of each pivot-row * N measures - col totals for each combination of each pivot-col * N measures - totals for each 'section', determined by unique values of first pivot-row * N measures - values for each measure in every 'cell'; Row Combos * Col Combos * N Measures So, there can still be a decent amount of data to store; but it will never hold onto all of the 'raw rows' from the dataset. We can never completely guarantee that Row Combos * Col Combos * N Measures remains small, but two things let us move forward anyway: - there's now visible feedback in the app that the download is running (or if it's failed) - Pivot table utility diminishes rapidly with huge output anyway; users still need to curate/set up their data - effectively to improve the table's utility, so we can assume that a slow-to-download pivot table is also slow to - use/less effective, and will likely be something the user doesn't want (as often). * some test fixes * now, if we export 'raw pivot rows', they don't show pivot-grouping and they also don't include the 'extra' rows for totals/subtotals/grand totals (any row with pivot-grouping > 0). This means that now the non-pivot version of a pivot table export will match what a user sees if they change the viz to a regular table. * remove old test * re-incorporate some changes from master * fix csv for non-pivots due to oversight in my changes This is just a temporary change, I think I should clean up this bit of the code a little, I can probably make it a little more readable and use some cleaner logic regarding if the rows are 'raw pivot rows' or not. * start moving format_rows to POST bod, add pivot_results too There's still wiring work to do, but this starts to add format_rows and pivot_results to POST body for the various API endpoints. Also modify tests to improve coverage/consistency across downloads and alerts/subscriptions. The tests will not pass on this commit, but fixes will be incoming * native pivot tables in xlsx * add precondition to pass migration linter * try to get migrations fixed * pasing pivot-results through api and attachments * fix tests for format_rows in BODY vs query param * tests! * might have the tests all fixed now * the pivoted export now respects col/row totals settings * add test coverage for public questions and dashboards * col and row totals work as expected * build-pivot refactor for clarity * docstring change + tiny refactor in helper fn * see if dashcard download works with format_rows * csv pivot handles nil values * pass format_rows and pivot_results in :params not :body * fix some other tests * pivot-grouping col filtered out of xlsx * pivot-grouping-col removed for all rows * configurable pivot exports and attachments (#47880) * exports fe * specs * ui * specs * format/unformatted now works for xlsx * format test changes for xlsx formatting * embedding endpoints accept pivot_results * cljfmt and eslint fix * empty * embedding test should have formatting defaulted to true * embed test fixes * Use `Chip` for export settings widget * downloads e2e test fix * fix public download limit test * public card download defaults * fix public download defaults in some tests * Fix visual test --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Romeo Van Snick authored
* Remove 'Save as new question' toggle when saving questions from editing a metrics' ad-hoc question * Allow visitQuestion to work for metrics * Use visitQuestion in metric test * Add test for #48555 (showing the 'Save as new?' ui for metrics) * Add issue info to repro * Use visitMetric, visitModel and visitQuestion helpers in createQuestion * Move check to make it more clear what the save ui does * Use cy.button for Done button * Remove unnecessary .within * Sign in as normal user * Add missing dataset alias
-
Romeo Van Snick authored
* Rename Common Metrics to Metrics * Rename Basic Metrics to Summaries * Update chill mode button copy to 'Add a summary or metric' * Rename 'Pick the metric you want to see' button to include summary * Fix type in test * Rename Summaries to Basic functions * Fix test * Undo cross-version test changes
-
- Oct 14, 2024
-
-
Raphael Krut-Landau authored
-
Raphael Krut-Landau authored
-
Raphael Krut-Landau authored
-
Uladzimir Havenchyk authored
-
Cam Saul authored
* Collapse `metabase.shared.*` namespaces * Fix Kondo warnings * Does updating the stories-data keys fix the failing tests? * Appease msgcat * Appease msgcat * Fix typo * Make the build happy * Appease fslint
-
Romeo Van Snick authored
* Add eslint-plugin-jest-formatting * Turn on jest formatting for unit.spec and cy.spec files * Fix e2e test formatting * Fix unit test formatting * Fix formatting in frontend/test * Remove commented out code Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Fix more files * Fix more lint --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Romeo Van Snick authored
* Add repro for #44171 * Do not save viz settings for metrics * Lowercase description Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * Rename variable to be more descriptive * Use visitDashboard * Fix typo in excludeVisualisationSettings * Check the request does not contain visualization_settings too * Allow visitQuestion to work for metrics --------- Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
Oisin Coveney authored
-
- Oct 11, 2024
-
-
Oisin Coveney authored
-
Romeo Van Snick authored
* Add 'Create metric' button to empty metrics page * Add e2e test for 'Create metric' button * Remove duplicate main on Browse page * Add docs link * Split off common test for BrowseMetrics * Add whitespace Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Use cy.button Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Hide Create metric button when the user does not have data access * Use findByText for link * Add test for hiding the 'Create metric' button when the user does not have data access * Fix unit tests * Improve copy Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Add whitespace Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Add explanatory comment for enterprise --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
Nick Fitzpatrick authored
* adding snowplow event for archiving stale items * adding total_items_archived to cleanup events
-
Oisin Coveney authored
-
- Oct 10, 2024
-
-
Nick Fitzpatrick authored
* Moving diagnostic state to redux, adding CP action * changing key binding * adding e2e test * adjusting e2e test * type adjustment
-
Alexander Polyankin authored
-
Oisin Coveney authored
-
Oisin Coveney authored
-
Nicolò Pretto authored
* don't set enable-embedding and setup-embedding-autoenabled in setup actions + cleanup * update jest test * shouldn't expect the secret key to be there either
-
Nicolò Pretto authored
-
- Oct 09, 2024
-
-
Nemanja Glumac authored
* Use more granular permissions * Simplify the "upload spreadsheet" button logic * Simplify the "add database" button logic * Go back to using the existing `databases` prop * Conditionally display `UploadInput` * Refine `canUpload` logic * Reduce prop drilling * Make visual logic more "reader-friendly" * Fix and expand tests * Pass down the existing prop `hasDataAccess` * Remove the Metabase "learn" link * Move sub-components out of the render
-
Romeo Van Snick authored
* Update copy on metrics page * Update copy in empty metric builder * Fix e2e test
-
Oisin Coveney authored
-
- Oct 08, 2024
-
-
Alexander Polyankin authored
-
Aleksandr Lesnenko authored
* track iframe creation * Update Loki Snapshots * Update frontend/src/metabase/visualizations/visualizations/IFrameViz/utils.unit.spec.ts Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Aleksandr Lesnenko authored
* isomorphic viz settings computation * stories * drop duplicated static formatter * drop formatValue from the renderingContext * clean up * stories * fix static charts stories * clean up mocked env * update sunburst formatters * no longer injecting formatValue * exclude modules without name * Update Loki Snapshots * Update Loki Snapshots --------- Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Ryan Laurie authored
* update setting copy * update settings context strings * fix milestone check
-
Nick Fitzpatrick authored
* collection of UI updates to the alert modal * remiving unused es lint directive * adding tag to cypress test
-
Nemanja Glumac authored
* [MS 1.1] Better Onboarding via First-Time UX (#48202) * Add new `learn` icon * Add initial visual elements WIP * Add a menu WIP * Use named export instead of a named one * Encapsulate the menu item logic * Redo the styling * Add todo notes * Get rid of the `style` prop where possible * Fix CSS logic for the container * Collapse section when the sidebar is closed * Use Mantine prop instead of the `style` * Fix the translation issue * Collapse section completely when the sidebar is closed * Remove hard coded color reference from SVG * Simplify element positioning * Collapse sidebar when closed * Fix E2E tests unscoped selectors * Rename props * Extract `SidebarOnboardingSection` logic into a separate component * Allow only admins to add data * Remove "Add your own data" button * Simplify menuitem component * Add initial unit tests * Use predefined vars for the CSV button subtitle * Show Upload CSV modal * Enable file uploads * Improve file organization * Tidy up types * Add analytics * Remove "Upload CSV" button from the sidebar * Fix "unmocked GET request" * Make menu usable on small screens * Make sure sidebar is scrollable
-
Chris Truter authored
Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
Alexander Polyankin authored
* Fix query_metadata not including native queries * Fix query_metadata not including native queries * fix tests
-
Nicolò Pretto authored
* update embedding homepage now that we don't auto-enable embedding * more cleanup and a test "Enable interactive embedding"
-