This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jan 09, 2024
-
-
Mark Bastian authored
* Multiple Cypress Reporters This PR modifies our Cypress reporter to support multiple reporters, currently pretty mochawesome reports and junit xml files. This was enabled using the [cypress-multi-reporters](https://www.npmjs.com/package/cypress-multi-reporters) reporter. Additional reporters are added via yarn packages: - [mocha-junit-reporter](https://www.npmjs.com/package/mocha-junit-reporter) - [mochawesome](https://www.npmjs.com/package/mochawesome) which was already installed One of the biggest challenges here is simply getting the config keys right, primarily `mochaJunitReporterReporterOptions` as opposed to the more sane `mochaJunitReporterOptions`, but I guess that the legacy of Java (
). Also be aware that `mochawesomeReporterOptions` is NOT the same as `mochaAwesomeReporterOptions` but `mochaJunitReporterReporterOptions` is not `mochJunitReporterReporterOptions` for obvious reasons. For future reference, note that multiple `mochawesome` reporters are available. Read more [here](https://glebbahmutov.com/blog/the-awesome-battle/) in the event that one of them is mochawesomer than the other and we want to level up. Closes #37195 * Adding feedback per @iethree. * Updated lock file -
Jeff Bruemmer authored
-
Cal Herries authored
-
Alexander Polyankin authored
-
Ngoc Khuat authored
-
Alexander Polyankin authored
-
Roman Abdulmanov authored
-
Nemanja Glumac authored
-
- Jan 08, 2024
-
-
Cam Saul authored
-
Chris Truter authored
-
adam-james authored
* Fix static viz funnel chart rendering by changing row idx values Pass into the js code the row data that the funnel component expects. This means changing a row from for example, [0 120] to something like: ["January" 120] when :funnel.rows exists in the viz-settings map. Also add some helpers to the render test utils ns which will be used in the test. * Add funnel test * Add docstrings. Slight change in funnel render rows * Slight rewrite for readability.
-
Jerry Huang authored
-
Alexander Polyankin authored
-
Jerry Huang authored
* Fix collection nil * address comments
-
Case Nelson authored
* Remove field_id * Remove legacy-card-or-table-id * Remove find_visible_column_for_legacy_ref
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Ngoc Khuat authored
-
Uladzimir Havenchyk authored
-
Chris Truter authored
-
Lena authored
-
Cal Herries authored
-
Jerry Huang authored
* add collection/list endpoint * add children * address changes * address change * fix test * fix like * address comments * Update src/metabase/api/collection.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> * address changes * exclude other user collections in the sql query * fix logic * fix acrhive * make remove-other-users-personal-collections cleaner * fix tests * fix errors * fix other test * add test * fix merge * fix formatting * address comments --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- Jan 07, 2024
-
-
Ngoc Khuat authored
-
- Jan 05, 2024
-
-
Raphael Krut-Landau authored
* When creating a new model, don't call /api/model-index because that returns error code 400 * Add two unit tests of DatasetEditor * Fixes #31671
-
Case Nelson authored
* Don't coerce add-implicit-clauses Fixes #33861 Renames `::nest-query/outer-select` to `qp/ignore-coercion` since it was already applied outside nest-query and currently only controls that aspect. * Fix whitespace * Only add ignore-coercion if temporal-unit or binning are present * Fix tests * Only add ignore-coercion flag when coercion strategy is present
-
Jeff Bruemmer authored
-
Jerry Huang authored
-
shaun authored
* add reproducing e2e spec * show failed button state and error message * add failed button and error message to e2e spec * Use findByLabelText and findByRole rather than cy.get * Add role=alert and aria-label to FormErrorMessage --------- Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
Alexander Polyankin authored
-
Braden Shepherdson authored
Previously date arithmetic was only supported with a single date or datetime +/- 0 or more intervals. This adds a new flavour of temporal arithmetic - subtracting two `:type/Date` or two `:type/DateTime` values yields a `:type/Interval`. Fixes #37263.
-
Alexander Polyankin authored
-
Noah Moss authored
-
andriibeee authored
* Remove unused empty dependency * Sync yarn.lock
-
Nemanja Glumac authored
#37233 made it possible to get rid of the temporary placeholder method name `_getMLv2Query` and replace with with the `query`. * Rename `_getMLv2Query` method to `query` * Update all references of `_getMLv2Query` to `query`
-
Nemanja Glumac authored
-
Kamil Mielnik authored
* Rename query to legacyQuery * Use step.query * Port ExpressionStep to MLv2 * Use named export for ExpressionStep * Move setup to the top of the file * Add expressions parameter to createQueryWithClauses * Update ExpressionStep unit tests * Add a test for adding expressions * Format code * Add typing for openSteps and remove default parameter to prevent accidental omission * Rename arguments * Remove NotebookStep['update'] and update NotebookStepUiComponentProps['updateQuery'] * Remove NotebookStep['update'] from test util * Add metadata argument to NotebookStepFn * Remove unused NotebookStep['clean'] * Change previewQuery type to Query * Update NotebookStep['revert'] to work with MLv2 only * Use revert: null properly * Clear breakouts before aggregations * Update NotebookStepDef['active'] to work with MLv2 only * Update NotebookStepDef['valid'], remove NotebookStepFn * Remove TODO * Update STEP.valid calls * Port #36507 to master * Migrate STEP.valid * Format code * Rename topLevelQuery to query and stagedQuery to legacyQuery * Use INotebookStep["id"], simplify handleQueryChange * Use database from metadata instead of question * Format code * Apply expressions before aggregations * Improve typing in tests * Fix expression name uniqueness * Fix Lib.fields typing * Use dropStageIfEmpty when removing expressions * Fix unique name computation * Port hasData * Add stageIndex argument to NotebookStepDef['valid'] * Port query.isSourceQuery() * Add junit.xml to .gitignore - see https://github.com/metabase/metabase/pull/35929 * Make unit tests run * Improve revert typing * Update unit tests * Update unit tests * Update unit tests * Rename filterStep1 to filterStep and filterStep2 to postAggregationFilterStep * Update unit tests * Update unit tests * Update unit tests * Update unit tests * Convert unit tests to TS * Simplify getQuestionStepsForMBQLQuery * Refactor tests * Remove test for new queries - a Lib.Query object cannot exist without the "data step" * Lift database to reuse it * Port getQuestionSteps * Skip e2e test for metabase#19745 due to metabase#36574 - See https://github.com/metabase/metabase/issues/36574 - See https://metaboat.slack.com/archives/C04CYTEL9N2/p1702063378269379 - See https://metaboat.slack.com/archives/C0643FZ5E83/p1702365832126429?thread_ts=1702362649.548849&cid=C0643FZ5E83 * Update comment * Revert type change * Revert "Use dropStageIfEmpty when removing expressions" This reverts commit d529503e793c93ecdc006f0ecf20c874f8cd091b. * Format code * Skip 19745 tests * Format code * Use dropStageIfEmpty instead of cleanNesting * Try to drop only the updated stage * Use stageIndex instead of -1 in preview3 * Format code * Ignore question.isStructured() check * Finish migrating getQuestionSteps * Migrate query.clean in Notebook to MLv2 * Use reduceRight instead of reverse + reduce * Fix typo * Move hasBreakouts computation until after the redundant stage is removed * Update e2e sandboxing test to assert showing permissions error instead of magically dropping an unsupported join - @see https://metaboat.slack.com/archives/C01LQQ2UW03/p1704294434403599 --------- Co-authored-by:
Tamás Benkő <tamas@metabase.com> Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
- Jan 04, 2024
-
-
adam-james authored
* Add number-viz test to pulse integration test. This is a currently failing test. The first card succeeds because the 'narrowing' to 1 field is done in the query directly, so the expected single value is shown. The second (currently failing) card has the viz for a 'number' applied but the query isn't 'narrowed' at all, so we see the failure. * Fix the :scalar render to look at the column specified in :scalar.field * Addressed feedback: improved get-col-by-name impl. and added test comment
-