Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Apr 26, 2023
    • Tim Macdonald's avatar
      Upload CSVs (#30256) · a06e640e
      Tim Macdonald authored
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * Add CSV uploads feature and have postgres and H2 support it (#29636)
      
      * Add csv uploads feature and have postgres support it
      
      * Add h2 support
      
      * CSV: schema detection (#29650)
      
      * CSV / Admin Upload Settings (#29709)
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * Add CSV uploads feature and have postgres and H2 support it (#29636)
      
      * Add csv uploads feature and have postgres support it
      
      * Add h2 support
      
      * Add defsettings
      
      * Add table prefix setting
      
      * add data upload settings
      
      * Add newline
      
      * update settings mock
      
      * Whether or not uploads are enabled
      
      ---------
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * Create table and insert rows from CSV uploads for postgres (#29677)
      
      * WIP create table and insert rows
      
      * Add newline
      
      * Use multimethods
      
      * WIP
      
      * Fix postgres
      
      * Fix postgres impl
      
      * Use detect-schema and add test
      
      * Fix load-from-csv arglists
      
      * Undo whitespace change
      
      * Use empty db instead
      
      * Add table and field tests
      
      * Remove prn
      
      * Uniquify names
      
      * newline
      
      * Add test for float
      
      * Add a test for the table contents
      
      * Tidy load-from-csv
      
      * Drop the table if loading the csv fails
      
      * Drop the table only if loading the csv fails
      
      * whitespace
      
      * Address SQL injection vulnerability
      
      * Use the slugified file-name as the table-name
      
      * Fix kondo
      
      * Using absolute path instead of relative
      
      * Fix kondo
      
      * Detect types for empty CSV files appropriately (#29754)
      
      * Create models from CSV uploads (#29966)
      
      * Wire up CSV uploads, sync the new table
      
      Still need to create a model
      
      * Check database support for CSV uploads better
      
      * Another test
      
      * Create model after sync
      
      * Fix request with formData
      
      * Fix tests
      
      * Fix tests
      
      * Revert "Fix request with formData"
      
      This reverts commit 66f146a41cf42feb34dbb03ed8566fa4220d0642.
      
      * Add whitespace
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@tsmacdonald.com>
      
      * Fix postgres support for uploads (#29922)
      
      * Check write perms for collection (#29976)
      
      * Rename metabase.csv -> metabase.upload (#29975)
      
      * Rename metabase.csv -> metabase.upload
      
      * Add docstring
      
      * Rename alias for release.common.upload
      
      ---------
      
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * WIP - 29598 csv status toast (#29757)
      
      * temp
      
      * generalize StatusListing types
      
      * Putting a pin in this for now
      
      * poorly done typing
      
      * generalizing upload function names
      
      * point to real API
      
      * Fixing Storybook
      
      * Permissions for Status Listing
      
      * use formdata and fix types
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      
      * Don't support redshift (#29981)
      
      * Handle uploads to the root collection (#29985)
      
      * Allow the uploads schema to be nil (for MySQL, etc.) (#29987)
      
      * CSV upload: fix stack overflow in detect-schema (#29983)
      
      * Fix stack overflow error on detect schema
      
      * map + vec -> mapv
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      
      * reload collection data after upload (#30009)
      
      * MySQL support for uploads (#29829)
      
      * Add MySQL support for uploads
      
      * Rename arg to upload-type
      
      * Use new ns name
      
      * Allow no table-name prefix to be specified and fix tests
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@tsmacdonald.com>
      
      * Fix setting descriptions (#30023)
      
      * Batch CSV insertion for better performance (#30028)
      
      * CSV upload e2e tests (#30005)
      
      * add CSV upload e2e tests
      
      * update tests
      
      * H2 support for uploads (#29828)
      
      * Add uploads support for H2
      
      * Rename arg
      
      * whitespace
      
      * Use new metabase.upload ns name
      
      * Fix tests for H2
      
      * Make table and field matching case insensitive
      
      * Fix kondo error
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@tsmacdonald.com>
      
      * Clear CSV upload state after a while (#30014)
      
      * clear upload status after 5s
      
      * make async behavior clearer
      
      * CSV Upload Dates and Datetimes Types (#30076)
      
      * Simple dates
      
      * Simple datetimes
      
      * Fix coalesce for date and datetime
      
      * Add mysql and h2 types
      
      * Fix test
      
      * Misc cleanup
      
      * Fix test
      
      ---------
      
      Co-authored-by: default avatarTim Macdonald <tim@tsmacdonald.com>
      
      * Fix Kondo (rebase gone wrong)
      
      * MySQL test fix
      
      * Fix order of Metabot setting
      
      * adding unit tests to upload actions and reducers (#30161)
      
      * adding unit tests to upload actions and reducers
      
      * use fetch-mock
      
      * Adding component unit test
      
      * Check CSV Upload permissions on the frontend (#30094)
      
      * CSV / Admin Upload Settings (#29709)
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * allow formData uploads
      
      * basic CSV uploads from collections
      
      * add dropzone support for collections
      
      * Add CSV uploads feature and have postgres and H2 support it (#29636)
      
      * Add csv uploads feature and have postgres support it
      
      * Add h2 support
      
      * Add defsettings
      
      * Add table prefix setting
      
      * add data upload settings
      
      * Add newline
      
      * update settings mock
      
      * Whether or not uploads are enabled
      
      ---------
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * properly check if user can upload to a collection
      
      * do some db checking
      
      * don't check admin status for upload notification
      
      * misc cleanup
      
      * fix rebase
      
      * add loggedin check to statusListing
      
      also combines container + view component into a single file
      
      * update unit tests
      
      * update tests
      
      ---------
      
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * Csv/misc bugfixes (#30219)
      
      * Support empty header names
      
      * Handle long CSV names more appropriately
      
      Handle duplicate column names in CSVs
      
      * Test fix
      
      * Partition CSV inserts a little more intelligently
      
      * Test fix
      
      * Remove 'duplicate' from duplicated column names
      
      * More intelligent sampling
      
      * Add comment re. Postgres table-name-length-limit
      
      * Quote column names, clean up tests
      
      When unquoted, we couldn't use reserved words (true, false, group, etc.)
      as column names
      
      * Fix test
      
      Now that we quote things, H2 is case-sensitive
      
      * Use dialect-appropriate quoting
      
      Also clean up some card-filtering tests so they work with a dirty DB
      
      * Fix deduplication
      
      * Remove use of setting/get
      
      * Remove unneeded migration
      
      ---------
      
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      
      * Fix test (#30383)
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <iethree@gmail.com>
      Co-authored-by: default avatarCal Herries <39073188+calherries@users.noreply.github.com>
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarCallum Herries <hi@callumherries.com>
      Co-authored-by: default avatarNick Fitzpatrick <nick@metabase.com>
      Unverified
      a06e640e
  2. Apr 25, 2023
  3. Apr 24, 2023
    • Natalie's avatar
      docs - update env vars (#30341) · dc883b53
      Natalie authored
      Unverified
      dc883b53
    • Case Nelson's avatar
      [MLv2] Fix inner native query key (#30162) · 69b5b407
      Case Nelson authored
      * [MLv2] Fix inner native query key
      
      * Unskip tests
      
      * Move rename-keys because source-query uses :native and native query uses :query to point at sql, so we have to see how the stage is used
      
      * Don't touch parameters in conversion
      Unverified
      69b5b407
    • metamben's avatar
      Implement breakoutable-columns (#30316) · 4dfd1809
      metamben authored
      Implement breakoutable-columns
      Unverified
      4dfd1809
    • Jerry Huang's avatar
      Replace user google_auth and ldap_auth columns with sso_source values (#30169) · 188125ec
      Jerry Huang authored
      * initial changes
      
      * fix test
      
      * add ldap
      
      * fix tests
      
      * update migrations
      
      * swap
      
      * swap ldap
      
      * fix test
      
      * update test
      
      * fix test
      
      * fix test
      
      * address comments
      
      * update
      Unverified
      188125ec
    • Luiz Arakaki's avatar
      bump snowflake to 3.13.30 (#30336) · a442c05c
      Luiz Arakaki authored
      Unverified
      a442c05c
    • Case Nelson's avatar
      [MLv2] Remove invalid query parts when summarizing (#30300) · 9fd5e283
      Case Nelson authored
      * [MLv2] Remove invalid query parts when summarizing
      
      * Address PR feedback
      Unverified
      9fd5e283
    • Mark Bastian's avatar
      Better 429 error code handling from OpenAI (#30327) · a3af5094
      Mark Bastian authored
      Adding better handling for 429s due to billing issues. Probably worth investigating all of the openai failure modes in the future for even better UI ergonomics. We could also just return the OpenAI message, but that would feel kind of non-Metabasey since we're exposing a 3rd party error message.
      Unverified
      a3af5094
    • metamben's avatar
      Generate unique aliases for operations in aggregations (#30302) · d7962863
      metamben authored
      Fixes #30262.
      Unverified
      d7962863
    • Cal Herries's avatar
      Toggle JSON unfolding by field (again) (#29751) · da930dfa
      Cal Herries authored
      
      * Use type/JSON instead of type/SerializedJSON
      
      * Tidy migration
      
      * Update migration
      
      * Fix rollback migration for h2
      
      * whitespace
      
      * Add test for migration
      
      * Fix test
      
      * Add rollback
      
      * whitespace
      
      * Test JSONB type as well as JSON
      
      * Don't fingerprint JSON columns
      
      * Remove comment, that might be wrong in the future
      
      * Update test
      
      * Add tests for fingerprinting
      
      * Use base-type JSON for fingerprinting base query
      
      * Add test for visibility-type=details-only
      
      * undo .
      
      * Change migration id
      
      * Fix migration test
      
      * Merge master
      
      * Exclude mariadb from tests
      
      * Make is-mariadb? public
      
      * Migration for adding nfc_enabled
      
      * Add nfc_enabled to field settings
      
      * Update describe-nested-field-columns to only unfold fields that have not been disabled
      
      * Remove spy
      
      * Tidy
      
      * Fix
      
      * Clear nested fields immediately if folding is disabled
      
      * Clear nested fields on nfc_enabled change
      
      * Trim trailing whitespace
      
      * Tidy
      
      * Fix
      
      * Add enable-json-unfolding-test
      
      * Move to field api test
      
      * nfc_enabled -> json_unfolding
      
      * Tidy test
      
      * Make json-unfolding in database details just the default for new settings
      
      * Restore original visibility-type logic
      
      * Fix
      
      * Sync field json_unfolding according to db json_folding
      
      * Rename to json-unfolding-default
      
      * Add test for the case when the json-unfolding is false for the database
      
      * Implement default json unfolding for first sync
      
      * Update comment
      
      * Update comment
      
      * Restore PUT field
      
      * Migration for populating json_unfolding for mysql and postgres
      
      * Remove migration and use default on the frontend instead
      
      * Update json-unfolding database setting copy
      
      * Move Unfold JSON setting under semantic type setting
      
      * Separate sentences with spaces
      
      * Capitalize
      
      * Restore handleChangeSemanticType
      
      * Use base_type TYPE.JSON instead
      
      * Change order of migrations
      
      * Add h2 migration
      
      * Add test for migration
      
      * Update test description
      
      * Remove validCheckSum
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * Use ?? instead of ||
      
      * Fix tests
      
      * Remove outdated serdes stuff
      
      * Remove unnecessary and
      
      * Fix mysql migration
      
      * Remove unused require
      
      * Fix test
      
      * Add false default value for json_unfolding
      
      * Fix json-unfolding nil case
      
      * Other suggestions
      
      * whitespace
      
      * Tidy describe-nested-field-columns
      
      * Update comment
      
      * Remove unused clear-nested-fields!
      
      * Remove unused return value
      
      * Fix H2 migration to use base_type not database_type
      
      * Always set json-unfolding during sync
      
      * Fix test
      
      * Fix test
      
      * Fix test
      
      * Add comment explaining nested-field-column support for MySQL
      
      * Fix tests
      
      * Fix tests
      
      * Fix test
      
      * Fix test
      
      * Default json_unfolding to false for new fields
      
      * Fix merge
      
      * Add json_unfolding to mock tables
      
      * Don't capitalize prepositions
      
      * Update setting description
      
      * whitespace
      
      * whitespace
      
      * Fix fetch_metadata
      
      * Fix fetch_metadata
      
      * Fix tests
      
      * Fix test
      
      * Fix clj-kondo
      
      * Remove postgres database-supports test
      
      * Fix postgres test
      
      * Fix postgres test
      
      * Fix mysql migration
      
      * Fix clj-kondo
      
      * Don't test mariadb
      
      * Fix mysql test
      
      * Fix mysql json-unfolding nil case
      
      * Add comments to test
      
      * Add upterm step to mariadb test
      
      * Move upterm step before tests
      
      * Fix postgresql migration
      
      * move upterm step to test-driver action
      
      * Remove upterm step from drivers.yml
      
      * Comment out everything else in test-driver
      
      * Fix mariadb migration
      
      * Remove upterm action
      
      * Whitespace
      
      * Only handle JSONObjects with JSON_VALUE, not JSONArray
      
      * Fix fields.sync_metadata/update-field-metadata-if-needed!
      
      * Add comment explaining `json-unfolding-default`
      
      * Add comment for JSON_VALUE test
      
      * Update json-unfolding-default-true-test to use fresh db
      
      * Fix test descriptions
      
      * Don't capitalize setting display name
      
      * Fix update json_unfolding
      
      * Fix unfolding json for only one JSON column, not all
      
      * Add e2e test for JSON unfolding setting
      
      * Fix test
      
      * whitespace
      
      * Fix test
      
      * Fix json-unfolding for nested field columns
      
      * Fix mysql and postgres tests for nested field columns
      
      * Coerce nil json-unfolding to false for sync_metadata
      
      * Add test for nil json-unfolding for sync_metadata
      
      * Fix test
      
      * Don't update json_unfolding from intial sync
      
      * Add json_unfolding to update-field-test
      
      * Fix tests
      
      * Use cypress-testing-library commands
      
      * Fix e2e test
      
      * Fix e2e test
      
      * Add json-simple to deps
      
      * Update uberjar.yml
      
      * import org.json.simple
      
      * Replace SQL migrations and H2 UDF with a clojure migration
      
      * Remove json-simple from deps
      
      * Restore uberjar.yml
      
      * Rename to set-json-unfolding!
      
      * Make the DB JSON unfolding setting override the field setting, instead of being a default.
      
      * Remove unused var
      
      * Fix error
      
      * Remove custom clojure migration
      
      * Fix migration
      
      * Fix migration again
      
      * Fix migration and kondo
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      Unverified
      da930dfa
    • Roman Abdulmanov's avatar
    • Oisin Coveney's avatar
    • Roman Abdulmanov's avatar
      [CI] Rename escalation label trigger (#30310) · 4882baf4
      Roman Abdulmanov authored
      Renamed Label to meet best practices.
      Unverified
      4882baf4
    • Roman Abdulmanov's avatar
      Add notification on escalation label (#30309) · 4b849e00
      Roman Abdulmanov authored
      [ci skip]
      Unverified
      4b849e00
  4. Apr 21, 2023
Loading