Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>

Co-authored-by: Natalie <nat@metabase.com>

* Add a test case for #28981

* Always open ActionParametersInputModal when clicking an action
- update unit tests to reflect this behavior

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* open metabase links in same iFrame when embedding

* unit test link behavior

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>

* recent_views stored in user local setting (#29631)

* First pass at recent_views stored in user local setting

This modifies the view log event handler to write a user's views to their local settings map (stored as json in the
appdb).

some notes on what causes a view

:card-query
 - occurs when collection with pinned cards/models is opened. maybe shouldn't count as a view

:card-read
 - happens when you view a card, like, load it in the UI and are looking at it

:card-read AND :card-query
 - happens when you view a model, like, load it in the UI and are looking at it

:dashboard-read
 - happens when you view a dashboard

:card-create
 - when you save a card
 - this will probably cause double counts because it will save and then trigger a :card-read right away too

:table-read
 - when viewing a table.
 - when selecting a db/table in dropdowns in the Question editor

I think we need the view log topics to be much smaller: #{:card-read :dashboard-read :table-read}

* WIP test for the recent_views user local setting.

This isn't totally correct yet. I think it doesn't clean up after itself correctly. That's pending.

And, I have to investigate because :table-read isn't working either. Still worth pushing this progress!

* Test that works! All potential view events need :actor_id

* Working test for /api/recent_views

* Order of views in user-local recent-views works now

If a user views something they've recently viewed, the homepage order doesn't change. Now it will, as in, the most
recently viewed item will always be the first item in the vector.

* One time recent_views expensive query done in the user-recent-views getter

The logic of filling the recent-views setting was first written in the activity api namespace. Now it's handled where
the setting is defined, which lets anyone else consuming the setting not worry about filling it if its empty.

The setting can be reset with `nil` which will cause the query to run again. Otherwise, if the list of recent items is
an empty vector, that is considered valid and will not re-run the query.

Updating the setting per view is handled still in the view log handler, implemented in the private function `update-users-recent-views!`.

* Add `most-recently-viewed-dashboard` setting

The most recently viewed dashboard for that user, in the past 24 hours.

This is not meant to be a permanent solution to providing this bit of info for the user, rather, it's a 'stop gap'
while the audit tables are reworked.

* Add test for most recent dashboard setting

* Pass :context to the view log fns

This lets us filter out views triggered by pinned cards.

* Fix tests failing after adding :context to view metadata

* See if card-query can help us filter out pinned item views

* Tests should send :card-query events

* Since we use :card-query, we have to filter out dashboard context too

This should prevent views being recorded if someone just opens a dashboard.

* ViewLog Cleanup to see if it'll let other tests pass

* fix build

* clean ns and fix build

---------

Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* backport 30321 with lots of custom code that take from 47

* rm src/metabase/lib/isa.clj

* fix isa_test

* Use display name from card for implicit actions

* Remove fields arg from generateFieldSettingsFromParameters

* Update implicit action test to include display-name

* Tidy

* Fix unit tests

* Fix e2e test

* Only include display-name in the parameters for implicit action types

* Use `field.displayName()`

* Fix some tests

* Attempt to fix test

* Fix ActionParametersInputForm unit tests

* Only generate field settings from parameters if action.type is implicit

* Fix e2e tests

* Fix unit tests

* Fix tests

Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>

* CI: Prerelease workflow improvements (#30819)

- Abort if the intended version conflicted with a past release
- Bail out if the commit hash isn't part of a release branch

* CI prerelease workflow: pretend to be the intended version (#30915)

---------

Co-authored-by: Ariya Hidayat <ariya@metabase.com>

Co-authored-by: Roman Abdulmanov <roman@metabase.com>

* Remove activity (#29056)

* remove activity frontend

* remove the activity page code

* remove GET api/activity/ route + tests

* regen dox for activity routes

- Not for GET /api/activity/ which has been removed.

* nix more things only used for GET /api/activity/

* pull out more only-used-for-get-api/activity/ code

* force namespace to be loaded (?) to be found

---------

Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>
Co-authored-by: Bryan Maass <bryan.maass@gmail.com>
Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>

* fix ns requires in api/activity + test

* remove most-recently-viewed-dashboard-views-test

* linter fix

---------

Co-authored-by: Kyle Doherty <5248953+kdoh@users.noreply.github.com>
Co-authored-by: Bryan Maass <bryan.maass@gmail.com>

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com>

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>

Fixes #29678.

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

This test requires the DB to support nested order by clauses which Trino does not.

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* Fix sample database not appearing in DatabaseBrowser without page refresh

- Fixes https://github.com/metabase/metabase/issues/29496



* Add an e2e test for #30871

* Add an extra step in e2e test

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>

Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com>

Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

[ci skip]

* Keep original join-aliases in expected columns

Fixes #30648.

The root cause of the bug was that the result_metadata generated for MBQL
queries returned escaped join-aliases, which in BigQueries case means that
spaces are converted underscores (_). These wrong join aliases could not be
resolved in later stages and resulted in incorrect references.

Normally, the escaped aliases are replaced by original ones in the post
processing step, but the post processing is not executed when calculating
expected columns.

This PR makes sure the original aliases are restored in the expected columns.

* Keep source_alias and display_name intact too

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* Fix custom mapping doesn't work on dashboard (#30217)

* fix selecting pinned items in collections

* update e2e test

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

* Alternative GEOJSON.io fix (#30675)

* Alternative GEOJSON.io fix

rather than not testing, just accept that we might get an expected
location back or we might get nil. This actually represents how the
application will behave and will seamlessly work as the service improves
or continues throwing errors:

```shell
❯ curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73,185.233.100.23"
<html>
<head><title>500 Internal Server Error</title></head>
<body>
<center><h1>500 Internal Server Error</h1></center>
<hr><center>openresty</center>
</body>
</html>

❯ curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73"
[{"area_code":"0","organization_name":"GOOGLE","country_code":"US",
  "country_code3":"USA","continent_code":"NA","ip":"8.8.8.8",
  "region":"California","latitude":"34.0544","longitude":"-118.2441",
  "accuracy":5,"timezone":"America\/Los_Angeles","city":"Los Angeles",
  "organization":"AS15169 GOOGLE","asn":15169,"country":"United States"},
 {"area_code":"0","organization_name":"GOOGLE-FIBER","country_code":"US",
 "country_code3":"USA","continent_code":"NA","ip":"136.49.173.73",
 "region":"Texas","latitude":"30.2423","longitude":"-97.7672",
 "accuracy":5,"timezone":"America\/Chicago","city":"Austin",
 "organization":"AS16591 GOOGLE-FIBER","asn":16591,"country":"United States"}]
```

Changes are basically

```clojure
(schema= (s/conditional some? <original-expectation-schema>
                        nil?  (s/eq nil)
         response-from-geojson)
```

* Filter to login error messages

```clojure
(into [] (map (fn [[log-level error message]] [log-level (type error) message]))
      error-messages-captured-in-test)
[[:error
  clojure.lang.ExceptionInfo
  "Error geocoding IP addresses {:url https://get.geojs.io/v1/ip/geo.json?ip=127.0.0.1}"]
 [:error clojure.lang.ExceptionInfo "Authentication endpoint error"]]
 ```

* check timestamps with regex

seems like they fixed the service

```shell
curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73,185.233.100.23"
[{"country":"United States","latitude":"34.0544","longitude":"-118.2441","accuracy":5,"timezone":"America\/Los_Angeles","ip":"8.8.8.8","organization":"AS15169 GOOGLE","country_code3":"USA","asn":15169,"area_code":"0","organization_name":"GOOGLE","country_code":"US","city":"Los Angeles","continent_code":"NA","region":"California"},{"country":"United States","latitude":"30.2423","longitude":"-97.7672","accuracy":5,"timezone":"America\/Chicago","ip":"136.49.173.73","organization":"AS16591 GOOGLE-FIBER","country_code3":"USA","asn":16591,"area_code":"0","organization_name":"GOOGLE-FIBER","country_code":"US","city":"Austin","continent_code":"NA","region":"Texas"},{"country":"France","latitude":"48.8582","longitude":"2.3387","accuracy":500,"timezone":"Europe\/Paris","ip":"185.233.100.23","organization":"AS198985 AQUILENET","country_code3":"FRA","asn":198985,"area_code":"0","organization_name":"AQUILENET","country_code":"FR","continent_code":"EU"}]
```

whereas a few hours ago that returned a 500. And now the timestamps are different

```
;; from schema
"2021-03-18T19:52:41.808482Z"
;; results
"2021-03-18T20:52:41.808482+01:00"
```

kinda sick of dealing with this and don't want to deal with a schema
that matches "near" to a timestamp.

* Restore these

i copied changes over from tim's fix and it included these fixes. But
now the service is fixed and these are the original values from cam's
original fixes

* ping CI

* add links to paid features section

* add readme link

* update links

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

# Conflicts:
#	.github/workflows/rerun-workflows.yml

Co-authored-by: Natalie <nat@metabase.com>

Co-authored-by: Natalie <nat@metabase.com>

* Ignore provided metadata on new cards (#30640)

* Ignore provided metadata on new cards

Fixes #30610

Removed an optimization that was put in place for copying cards that
trusted the front end to pass in the correct result_metadata. Now, on
new cards we ignore the passed in metadata and recalculate fresh. On
models, however, we recalculate fresh metadata and combine it with the
provided metadata.

* Update test based on PR feedback

* Fix backported toucan v toucan2 model ref

---------

Co-authored-by: Case Nelson <case@metabase.com>

Co-authored-by: Natalie <nat@metabase.com>

Co-authored-by: Natalie <nat@metabase.com>

* initial fix

* unskip repro

* use as-admin in more places

* macro tweak and unit tests

* tweak macro again and add a sandboxing test

* fix test