Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 14, 2022
  2. Jul 12, 2022
    • Noah Moss's avatar
      First pass at parameters in Markdown cards (#23641) · e136f430
      Noah Moss authored
      * first pass at parameters in text cards on FE
      
      * trying to get translations working
      
      * relative datetime formatting
      
      * copy changes and 'Text card' header
      
      * default text when no params
      
      * hide header for text cards with height of 1 with params when in param mapping mode
      
      * show UI text in mobile mode
      
      * minor fixes
      
      * enforce that a text card variable can only be mapped to one parameter
      
      * more value formatting
      
      * noop
      
      * fix backend tests
      
      * add back a couple pieces of frontend logic commented out
      
      * misc cleanup
      
      * attempt at adding a FE unit test
      
      * revert unit test, doesn't work
      
      * add a couple of basic cypress tests and fix a couple of bugs
      
      * basic unit tests for cljc
      
      * fix error
      
      * expanded unit tests
      
      * simplify ns
      
      * add cypress test for instance language translation
      
      * basic handling for a couple cases of :date/all-options
      
      * trs docstring clarification
      
      * whitespace tweaks
      
      * fix cypress test
      
      * minor refactor of tag-names
      
      * move cljc file from utils to new parameters dir
      
      * reorder functions
      
      * fix lint
      
      * add test assertion that locale is correctly reset back to english, and add a comment
      
      * fix bug where existing parameter mapping target was not being found
      
      * clojure logic tweaks
      
      * move text card header text to the Text component config
      
      * simplify header logic, and pull out isLoading into a function to reduce complexity
      
      * address alex's css feedback
      
      * fix trs comment
      Unverified
      e136f430
  3. Jun 29, 2022
  4. Jun 26, 2022
  5. Jun 21, 2022
  6. Jun 13, 2022
  7. Jun 02, 2022
  8. Jun 01, 2022
  9. May 17, 2022
    • adam-james's avatar
      Whitelabelling users font family font setting (#22791) · 856c46e2
      adam-james authored
      
      * Add font utilities to derive list of available fonts from font dirs
      
      This PR adds two defsettings to facilitate Enterprise users' ability to set the font for their instance. The
      'available-fonts' can be grabbed by the frontend to populate the dropdown menu. The 'application-font' setting can be
      written by the frontend to save the chosen font.
      
      * Adding some fonts and font selector
      
      * Send  (("dirname", "font name"),) to frontend
      
      Instead of only sending a list of names, send a tuple of `[directory-name, Display Name]`
      
      * Adding half of the fonts
      
      * Font list derived from font directory/font file names
      
      This is an attempt to derive the 'Display Name' of a font by comparing the directory name to the file names. '_' is
      replaced with spaces, but '-' exists in the 'Lato' font directory name, and we may have naming confusion in the
      future. Basically, I want to be liberal with what font directory/file names we can receive.
      
      Not certain this is the right approach yet, but it will work and correctly provides names based on the fonts available.
      
      * Adding remaining fonts
      
      * Using Default Font family in visual components
      
      * Small change to fix some lint warnings
      
      * Removing Noto Sans JP
      
      * Move logging
      
      * Alter hardcoded font path
      
      * Added cypress test
      
      * Change Cypress Test to look for correct text
      
      * Added unit tests for fonts.clj, and simplified creating display name
      
      The display name approach is simple -> underscores become spaces, and names are split on dashes/first word is taken
      from the split.
      
      This might not be robust to future font installations, but will be a good v1
      
      * adding visual test
      
      * fixing cypress test
      
      * Actually add the unit tests
      
      * Fix lint problems
      
      * Add setter to application-font to prevent invalid font setting
      
      * Addressing PR review points
      
      - fixed 'normalize-font-dirname' description
      - 'contains-font-file?' returns true/false
      - 'available-fonts-test' now properly uses 'is'
      
      * Make font-path private
      
      * Lint error.
      
      * Modified fonts to use java.io/resource to hopefully work in a jar
      
      * Simplified Lato folder name
      
      * PR Cleanup
      
      * Address some backend feedback
      
      * Lint error from reflection with .toString on a path
      
      I removed the explicit .toString inside the lamdba functino and str/includes still works.
      
      * no longer need u.files in test ns
      
      Co-authored-by: default avatarNick Fitzpatrick <nick@metabase.com>
      Unverified
      856c46e2
    • Howon Lee's avatar
  10. May 16, 2022
    • adam-james's avatar
      Add font utilities to derive list of available fonts from font dirs (#22612) · f106ebfd
      adam-james authored
      
      * Add font utilities to derive list of available fonts from font dirs
      
      This PR adds two defsettings to facilitate Enterprise users' ability to set the font for their instance. The
      'available-fonts' can be grabbed by the frontend to populate the dropdown menu. The 'application-font' setting can be
      written by the frontend to save the chosen font.
      
      * Adding some fonts and font selector
      
      * Send  (("dirname", "font name"),) to frontend
      
      Instead of only sending a list of names, send a tuple of `[directory-name, Display Name]`
      
      * Adding half of the fonts
      
      * Font list derived from font directory/font file names
      
      This is an attempt to derive the 'Display Name' of a font by comparing the directory name to the file names. '_' is
      replaced with spaces, but '-' exists in the 'Lato' font directory name, and we may have naming confusion in the
      future. Basically, I want to be liberal with what font directory/file names we can receive.
      
      Not certain this is the right approach yet, but it will work and correctly provides names based on the fonts available.
      
      * Adding remaining fonts
      
      * Using Default Font family in visual components
      
      * Removing Noto Sans JP
      
      * Small change to fix some lint warnings
      
      * Move logging
      
      * Alter hardcoded font path
      
      * Added cypress test
      
      * Change Cypress Test to look for correct text
      
      * adding visual test
      
      * fixing cypress test
      
      * Added unit tests for fonts.clj, and simplified creating display name
      
      The display name approach is simple -> underscores become spaces, and names are split on dashes/first word is taken
      from the split.
      
      This might not be robust to future font installations, but will be a good v1
      
      * Actually add the unit tests
      
      * Fix lint problems
      
      * Add setter to application-font to prevent invalid font setting
      
      * Addressing PR review points
      
      - fixed 'normalize-font-dirname' description
      - 'contains-font-file?' returns true/false
      - 'available-fonts-test' now properly uses 'is'
      
      * Make font-path private
      
      * Lint error.
      
      * PR Cleanup
      
      Co-authored-by: default avatarNick Fitzpatrick <nick@metabase.com>
      Unverified
      f106ebfd
  11. Apr 23, 2022
  12. Apr 22, 2022
  13. Apr 20, 2022
  14. Apr 15, 2022
  15. Apr 01, 2022
  16. Mar 31, 2022
  17. Mar 21, 2022
  18. Mar 02, 2022
  19. Jan 28, 2022
  20. Jan 24, 2022
  21. Jan 14, 2022
  22. Dec 27, 2021
  23. Dec 24, 2021
  24. Dec 03, 2021
  25. Nov 29, 2021
  26. Nov 15, 2021
  27. Oct 22, 2021
  28. Jul 12, 2021
  29. May 13, 2021
  30. Jan 07, 2021
  31. Dec 09, 2020
    • Robert Roland's avatar
      Dashboard subscriptions work, squashed (#13390) · dd2ecc51
      Robert Roland authored
      
      * Dashboard subscriptions work, squashed
      
      This test namespace differs in EE and OSS
      
      Without other changes from EE, this won't work
      
      so, for now, I've restored the pure OSS version of this test
      
      redo wording on existing subscription cards
      
      hacks? to address some timing issues where the render loop executes
      before properties are available (loaded from the server)
      
      links to configure pulse types
      
      Display a link to configure email or slack when they aren't already
      
      Fix the am/pm picker
      
      set up a new schedule tooltip
      
      The sidebar can appear and disappear from the Sharing popover
      
      run prettier on everything
      
      email recipients now does the "name [and n other]" thing
      
      Dashboard subscriptions work, squashed
      
      redo wording on existing subscription cards
      
      hacks? to address some timing issues where the render loop executes
      before properties are available (loaded from the server)
      
      styling for email not configured state
      
      add styling for slack unconfigured state
      
      disable cursor-pointer if email or slack isn't configured
      
      Implement cancel button for the sidebar (#13741)
      
      Dashboard subscription UX enhancements:
      
      * Implement cancel button for the sidebar
      
      * Don't return duplicate dashboard subscriptions
      
      * Move sidebar cancellation into Redux
      
      * Add close icon
      
      * Fix popover behavior
      
      Dashboard Subscriptions: Fix build (#13859)
      
      * Frontend lint fixes
      
      * Fix failing email tests
      
      * Revert some of the snapshot changes
      
      * regenerate snapshots
      
      * done fixing FE tests?
      
      * Make `dashboard_card_id` optional in CardRef schema
      
      * Fix test setup in pulse model test
      
      * Fix collection API test
      
      * Order pulses by name
      
      * Cypress fixes/skips
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      
      Subscribe to dashboards send test email (#13886)
      
      * Frontend lint fixes
      
      * Fix failing email tests
      
      * Revert some of the snapshot changes
      
      * regenerate snapshots
      
      * done fixing FE tests?
      
      * Make `dashboard_card_id` optional in CardRef schema
      
      * Fix test setup in pulse model test
      
      * Fix collection API test
      
      * Order pulses by name
      
      * Cypress fixes/skips
      
      * uggh cypress
      
      * Add button to send test email for dashboard subscriptions
      
      * Disable test email with no recipients
      
      * Refactor SendTestEmail
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      
      Fix failing collection tests (#13891)
      
      * Move dashboard embedding button (#13928)
      
      * Revert migration 277 (as in master)
      
      styling and hover tweaks for subscription cards (#14003)
      
      Fix positioning of create and close buttons (#13999)
      
      * fix positioning of create and close buttons
      
      * Update frontend/src/metabase/sharing/components/SharingSidebar.jsx
      
      * Update frontend/src/metabase/sharing/components/SharingSidebar.jsx
      
      * import Flex
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      Co-authored-by: default avatarKyle Doherty <kyle.l.doherty@gmail.com>
      
      Add deprecation warning to Pulse create/edit page (#13954)
      
      * add pulse deprecation warning
      
      * remove unused Link component
      
      * kyle comments
      
      * Update frontend/src/metabase/pulse/components/PulseEdit.jsx
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      * Update frontend/src/metabase/pulse/components/PulseEdit.jsx
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      * Update frontend/src/metabase/pulse/components/PulseEdit.jsx
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      More dash subscription styling tweaks (#14006)
      
      * change hovers for email and slack delivery options
      
      * calm down, delete button
      
      * style csv and xlsx options as buttongroup
      
      * settings spacing tweaks
      
      Dashboard subscription attachment question selection (#13950)
      
      * Move email attachment into its own component
      
      Add appropriate checkbox behavior
      
      Set pulseCards appropriately
      
      * Delete PulseCards when dashboard card removed
      
      Co-authored-by: default avatarCam Saul <github@camsaul.com>
      Unverified
      dd2ecc51
  32. Oct 23, 2020
  33. Aug 13, 2020
  34. Jul 20, 2020
  35. Feb 18, 2020
  36. Jan 09, 2020
  37. Dec 06, 2019
  38. Oct 01, 2019
    • Kyle Doherty's avatar
      Bundle fonts (#10963) · 869356c9
      Kyle Doherty authored
      * remove Google Fonts usage
      
      * local Lato in resources/frontend_client/app/fonts
      
      * create assets/fonts aliases, update publicPath, use absolute paths in css
      
      * add svg to extensions
      
      * update flow config to account for frontend_client assets
      
      * add explicit .svg extension to no_results usage
      
      * remove google fonts references from CSP headers
      Unverified
      869356c9
Loading